thatcher
f0c7870f4e
cleaning up new setting as applied to collections
2013-03-14 07:22:26 -04:00
thatcher
b9741daaaf
removing debug console log statement per ventero's review notes
2013-03-14 07:22:26 -04:00
thatcher
537ea0b844
simplifying zoom settings so scroll and click arent significantly different
2013-03-14 07:22:26 -04:00
thatcher
464cf076a6
simplifying zoom settings so scroll and click arent significantly different
2013-03-14 07:22:26 -04:00
thatcher
a5421917a4
minZoomImageRatio should not be less than minPixelRatio to avoid blurry full zoom out. Its worth noting now that several options are 'coupled' but dont have logic which addresses the coupling so as to avoid ill affects from settings that dont make sense for how they are coupled.
2013-03-14 07:22:26 -04:00
thatcher
86e27c18f7
what was initally a feature branch to work on just canvas prerender, evolved into a feature branch focused on broader ideas discussed in issue #4 - I've basically been able to reduce time spent in drawTile by half. good stuff, thanks to dustmoo for getting us looking into this
2013-03-14 07:22:26 -04:00
thatcher
fe0cafea21
improved caching follows existing use of tile.unload to delete prerendered canvas
2013-03-14 07:22:26 -04:00
thatcher
2be165fa70
niave implementation of prerender for canvas, the first optimization discussed here: http://www.html5rocks.com/en/tutorials/canvas/performance/
2013-03-14 07:22:25 -04:00
thatcher
417a93d5ae
Merge branch 'master' of https://github.com/openseadragon/openseadragon
2013-03-12 20:15:36 -04:00
thatcher
b3146683f2
applying patch provided by eikeon for position parameter constructor of TileSource. At some point I hope to deprecate most of these constructors that have more than two positional parameters.
2013-03-12 20:12:08 -04:00
Ian Gilman
b4ddb5a953
Improved build banners, including making them visible in minified version
2013-03-11 11:52:30 -07:00
Chris Thatcher
c164e8fac5
Merge pull request #24 from openseadragon/fullscreen
...
Fullscreen native javascript support now available. will increment build id and publish. Thanks ventero and iangilman for your reviews.
2013-03-07 20:57:11 -08:00
thatcher
5203cc14b0
removing extra whitespace per pull request review
2013-03-07 23:50:27 -05:00
thatcher
f107aaf0e8
removing debug console log statement per ventero's review notes
2013-03-06 21:53:20 -05:00
thatcher
6285a779f3
cleaning up event names, reducing demo cases to just addHandler interface, normalizing event data to express more idiomatic javascript pattern of passing object instead of invoking callback with positional parameters
2013-03-06 17:34:12 -05:00
thatcher
3801326e40
pulling full screen api detection out into is own file per ians suggestion
2013-03-06 15:36:52 -05:00
thatcher
75f7589312
simplifying zoom settings so scroll and click arent significantly different
2013-03-06 07:43:12 -05:00
thatcher
0bdc4383bd
simplifying zoom settings so scroll and click arent significantly different
2013-03-06 07:35:47 -05:00
thatcher
e04813e477
minZoomImageRatio should not be less than minPixelRatio to avoid blurry full zoom out. Its worth noting now that several options are 'coupled' but dont have logic which addresses the coupling so as to avoid ill affects from settings that dont make sense for how they are coupled.
2013-03-06 06:44:55 -05:00
thatcher
096b02d1c8
addressing typo in comment pointed out by @iangilian
2013-03-06 06:03:05 -05:00
thatcher
9503fac39d
merging, not sure why I get a conflict on this, must be doing something wrong in my work flow
2013-03-06 05:55:53 -05:00
thatcher
61a844bdc0
what was initally a feature branch to work on just canvas prerender, evolved into a feature branch focused on broader ideas discussed in issue #4 - I've basically been able to reduce time spent in drawTile by half. good stuff, thanks to dustmoo for getting us looking into this
2013-03-06 05:51:31 -05:00
thatcher
11a0f3b315
improved caching follows existing use of tile.unload to delete prerendered canvas
2013-03-05 07:30:37 -05:00
houseofyin
a432a38d3d
23 Initial attempt a this feature along with a demo page
2013-03-04 15:19:35 -05:00
thatcher
2fc6cc3876
niave implementation of prerender for canvas, the first optimization discussed here: http://www.html5rocks.com/en/tutorials/canvas/performance/
2013-03-01 09:23:47 -05:00
Chris Thatcher
fc479b5ecb
Merge pull request #26 from openseadragon/memoizelevelscale
...
memoize default implementation of getLevelScale
2013-03-01 06:18:08 -08:00
thatcher
274df71c0a
refs #22 use Math.pow per houseofyin and memoize implementation of getLevelScale per acdha
2013-03-01 08:42:06 -05:00
thatcher
6d4d7cc8c6
niave implementation of prerender for canvas, the first optimization discussed here: http://www.html5rocks.com/en/tutorials/canvas/performance/
2013-03-01 08:14:35 -05:00
thatcher
b560a06c30
correcting comment per ventero's review
2013-02-28 16:19:04 -05:00
thatcher
e56632c96f
blendTime needs to be equal to animationTime to avoid blurred images
2013-02-28 15:56:50 -05:00
thatcher
2819ff14e5
reverting a couple changes to core openseadragon options unrelated to issue #2 . will explore these in #4 were they have already been referenced.
2013-02-28 15:55:24 -05:00
thatcher
807cdd337c
cant set blendTime to 0, causes strange behavior in navigator and lip tile sources. should have made the basic config changes in #2 and #3 in a diferent branch related to #4 . will do before pulling
2013-02-28 15:55:24 -05:00
thatcher
6d3ddd8095
by feel, best performance, changed immediateRender to true, springStiffness to 7 - issue #2
2013-02-28 15:55:24 -05:00
thatcher
5b6a2f5873
basic implementation of issue #2
2013-02-28 15:55:24 -05:00
thatcher
5dd8798f7f
addressing venturo's review notes
2013-02-28 15:34:44 -05:00
thatcher
a4477cd765
better encapsulation of native fullscreen api
2013-02-28 15:34:44 -05:00
thatcher
d6cdd4028c
removing unneccessary if
2013-02-28 15:34:43 -05:00
thatcher
a18460a310
reverting a couple changes to core openseadragon options unrelated to issue #3 . will explore these in #4 were they have already been referenced.
2013-02-28 15:34:43 -05:00
thatcher
d4b02e1aba
managed to get a more complete, though hacky, implementation of #3 . the big sticky point was how firefox and safari beahved when switching between applications when already in full screen mode. because we didnt have an event listener for fullscreenchange, and because those browsers released full screen on application or window change (think alt+tab or cmd+tab), you would come back to a empty document. more work left here to make this worth merging into master
2013-02-28 15:34:43 -05:00
thatcher
f602a682f7
basic implementation of enhancement request from issue #3
2013-02-28 15:34:43 -05:00
thatcher
2f938766b3
Merge branch 'master' of https://github.com/openseadragon/openseadragon
2013-02-28 14:38:12 -05:00
thatcher
015e94efa4
found typo in source, thie was supposed to be this
2013-02-28 14:37:32 -05:00
thatcher
361052656c
patch for pinch zoom point. initial two point touch midpoint is used for duration of pinch-zoom operation. references #17
2013-02-27 06:57:06 -05:00
thatcher
2372968518
refs #4 - have noticed navigator is often blurry when rendered. changing blendTime can alleviate or worsen this issue if it is more or less than the animationTime (respectively). Im setting this to the value equal to animationTime as a hot patch while we figure out why these two variables are coupled.
2013-02-26 23:52:23 -05:00
Hal Blackburn
3eac183d8c
Fix handling of touchmove events on Android
...
Dragging the canvas did not work on Android devices as the === check for
lastTouch and the current event was always evaluating to false.
Presumably Safari on iOS re-uses the same Touch object for touchmove
events with the same finger, whereas Chrome/Firefox on Android creates
new Touch objects for each event (so the === evaluates false). The code
now compares Touch.identifier to ensure the new touch event is from the
same finger as the initiating touchstart.
2013-02-26 11:50:11 +00:00
thatcher
070a48f6c8
fixing jsdocs that caused recursion
2013-02-19 22:53:54 -05:00
Ian Gilman
9569ff1215
Removed JS Hint globals comment, since it's now in grunt
2013-02-14 12:04:47 -08:00
Ian Gilman
4e51b642ef
Now properly setting version in build
2013-02-14 12:02:17 -08:00
thatcher
fda24f343a
added dozens of event hooks based on input from macreery's branch
2013-02-13 19:44:23 -05:00
thatcher
d8a3ccf5e8
dont compute NaN for opacity because FF doesnt like that, per macreery's branch, thanks
2013-02-13 17:20:05 -05:00
thatcher
27d2898818
added removeAllHandlers per macreery's branch, finally implemented removeHandler
2013-02-13 17:11:33 -05:00
thatcher
e851de80b8
added class names to viewer canvas and container per macreery's branch
2013-02-13 16:50:23 -05:00
thatcher
685f58d663
adding support for positional arguments for minLevel and maxLevel in DziTileSource per macreery's branch
2013-02-13 16:27:17 -05:00
thatcher
0540e834b4
refactoring after lint left an error related to drawer and overlays
2013-02-13 09:05:35 -05:00
thatcher
a0fd2b3324
added inital support for moving to a nodejs build with grunt. build only includes concant and lint. fixed all lint warning where appropriate and added lint inline ignores where appropriate. when build script is complete we will start transition to new repo. also currently researching how to prune unfriendly portion of history that make repo large due to large binary files in web app. I like git well enough but using branches for web apps unrelated to code base has made me weary once again of social web fads that force convention without long term consideration of cost.
2013-02-12 22:40:08 -05:00
thatcher
855e753225
some overlays work that had be be completed before finishing tile layers. added brief example of how to how host tiles of zoom.it
2013-02-10 22:53:51 -05:00
thatcher
aecf576c06
finished initial development of iiif info xml and json support, added example to site
2013-02-09 15:58:43 -05:00
thatcher
3f20018c75
correction for recent change which computed a highestLevel for drawer with max instead of min operation
2013-02-09 12:21:51 -05:00
thatcher
d2d5828d8f
adding support for several new tile sources including iiif, osm and tms (osm and tms are thanks to seajax-utils project)
2013-02-08 15:45:22 -05:00
thatcher
576c00b37d
adding support for several new tile sources including iiif, osm and tms (osm and tms are thanks to seajax-utils project)
2013-02-08 09:21:28 -05:00
thatcher
792165fdf9
accidently left alwaysBlend global defaul set to true during development. Looking forward to our new org based repo where I'll be constrained more than my current wild-west repo, sorry. corrections also to pan constrainment details which came to the forefront while working on collections zoom and panconstraints. Added new ui feature page to demo basics.
2013-02-05 21:26:40 -05:00
thatcher
b1cdaaa845
found an IE specific error in some styles set for collections visualizations
2013-02-01 15:35:46 -05:00
thatcher
808354dd6f
Merge branch 'master' of github.com:thatcher/openseadragon
2013-02-01 15:19:05 -05:00
thatcher
f863f5fcae
changing drawHTML routine to avoid ie rendering issue
2013-02-01 15:18:53 -05:00
ygra
354c0f8d57
Fixed comment typos
2013-01-31 19:18:32 +01:00
thatcher
bd135904b6
Merge branch 'master' of github.com:thatcher/openseadragon
2013-01-31 12:30:36 -05:00
thatcher
6efc348b8a
finished collection support for html drawers
2013-01-31 12:30:13 -05:00
Ian Gilman
527682d5a6
Merge branch 'master' into lint
...
Fixed Conflicts:
openseadragon.js
src/drawer.js
2013-01-31 09:26:55 -08:00
thatcher
063bce8171
fixing some work in progress for collections visualizations
2013-01-30 20:23:45 -05:00
thatcher
9fc4388ac9
Merge branch 'master' of github.com:thatcher/openseadragon
2013-01-30 16:51:46 -05:00
thatcher
f6ee93b70c
improving custom tile source examples are work for layers begins being supported
2013-01-30 16:51:37 -05:00
Ian Gilman
c6597213a1
Using square bracket notation for keyword
2013-01-29 10:06:39 -08:00
Ian Gilman
7a55b6cf77
JS Hint work (mostly semicolons at this point)
2013-01-29 09:32:58 -08:00
Ian Gilman
624fbd97b9
Comment typo
2013-01-28 10:24:13 -08:00
iangilman
d23851d5e5
Merge pull request #15 from Ventero/imageload
...
Pass the correct object to image load callbacks.
2013-01-28 10:21:36 -08:00
Ian Gilman
5e24432349
Comment tweak
2013-01-28 10:11:14 -08:00
iangilman
0fddd1a61d
Merge pull request #26 from Ventero/patch-1
...
Make sure navigator has non-negative width/height
2013-01-28 10:04:39 -08:00
Ventero
8f085c83ca
Update documentation for Drawer#loadImage.
...
Additionally, improve name of the parameter passed to the complete
listener.
2013-01-25 20:36:41 +01:00
Ventero
9b6de523c7
Add TODO comment about magic number
2013-01-25 19:56:07 +01:00
iangilman
1c577ec40a
Merge pull request #14 from Ventero/navimages
...
Allow overriding the default navImages prefix url
2013-01-25 10:55:15 -08:00
Ventero
9620272ebb
Make sure navigator has non-negative width/height
...
Older versions of IE throw if we try to assign a negative width/height.
Fixes #24 .
2013-01-25 14:17:35 +01:00
iangilman
718082998b
Merge pull request #16 from Ventero/disprect
...
Use correct option name (displayRects, not dispRects) in DziTileSource.
2013-01-24 10:38:01 -08:00
thatcher
215395abb4
merged build.xml
2013-01-23 23:03:00 -05:00
thatcher
15c35c93fd
0.9.90 adds support for a debug mode and real heterogeneous collection visualizations. straight html div/image support for both features is in process but incomplete
2013-01-23 23:00:11 -05:00
iangilman
1331530cb6
Merge pull request #13 from Ventero/fixes
...
Allow different Deep Zoom schema namespaces.
2013-01-16 13:31:00 -08:00
thatcher
ab35e86776
bug patches for lazy load on image reference strip
2012-10-13 02:39:42 -04:00
thatcher
8fab8b5051
better lazy loading for image reference strip and more options for managing additional html content that is available in full page mode and normal mode
2012-10-12 23:40:59 -04:00
Ventero
31716bf56d
Use correct option name (displayRects, not dispRects) in DziTileSource.
2012-09-29 14:20:20 +02:00
Ventero
bb0ac1f9d1
Pass the correct object to image load callbacks.
...
Previously, the image object was passed on to onTileLoad regardless
if it loaded successfully or not. In case an image failed to load,
this would result in trying to draw a non-existing image onto the
canvas, which (at least in Firefox) throws a DOM exception and results
in the drawer being stuck mid-update.
2012-09-29 12:31:51 +02:00
Ventero
5c74c7b415
Always clear the image load timeout job.
2012-09-29 12:31:46 +02:00
Ventero
197244e185
Allow different Deep Zoom XML namespaces.
...
While the official XML namespace according to the xsd is
http://schemas.microsoft.com/deepzoom/2008 , DZIs generated with the
Deep Zoom Composer use http://schemas.microsoft.com/deepzoom/2009 ,
so this should be supported as well.
2012-09-28 20:07:05 +02:00
Ventero
0aba38c88c
Fix a typo in the documentation for options.prefixUrl.
2012-09-28 20:06:14 +02:00
Ventero
76a16464a2
Allow overriding the default navImages prefix url.
2012-09-28 20:06:02 +02:00
thatcher
bebc7a64ff
overflow was rendering scroll bar in IE for navigator and imagereference strip
2012-09-11 12:31:42 -04:00
thatcher
e7785fe636
found error related to minPixelWidth being set incorrectly for navigator and image reference strip so it loaded too many level which hurt performance
2012-09-07 08:55:19 -04:00
thatcher
79d048ac81
add lazy load to drag too, not just scroll
2012-09-05 11:35:42 -04:00
thatcher
1c200aca9c
finished lazy loading implementation of image reference strip, really helps initial render time with large image sets
2012-09-05 10:52:57 -04:00
thatcher
a638076c76
custom tile source should pass whole object to constructor to allow idiomatic pattern of extension of tile source with arbitrary properties
2012-08-29 20:55:36 -04:00
thatcher
1d1cbc6f56
custom tile source should pass whole object to constructor to allow idiomatic pattern of extension of tile source with arbitrary properties
2012-08-29 20:53:42 -04:00
thatcher
ddedd35db9
patch for substantial error in computing boundary and home poisition when width is greater that height
2012-08-29 20:48:45 -04:00
thatcher
104a814af0
adding prototype image reference strip, fixing IE error related to checking for instanceof XMLDocument, fixing aspect ratio error when image is wider than tall
2012-08-29 14:46:34 -04:00
thatcher
c41f6a464e
Substantial rework of TileSource and Viewer.openTileSource to allow simpler introspect of the intended TileSource implementation based on the configuration object details. Also major www updates to simplify and unify the informational site by building it via simple templates. Improved examples and documentation. Added support for xml, json, jsonp, and inline configuration of supported tile sources.
2012-06-05 07:52:00 -04:00
thatcher
107a5efabf
patch for recursive function call causing ie8 errors - oops. Also completed support for jsonp dzi format/protocol which is useful for running openseadragon from the filesystem as well, see main gh-pages index.html for example
2012-04-12 13:20:24 -04:00
thatcher
e595ad2381
Adding ability to bind to buttons to custom interface elements, also use screen size detection to avoid using canvas on small devices since is more cpu intensive. Added version check for IE specific implementations to avoid using them for IE 9 and made most IE implementation differences a one-time process instead of an if/else which is evaulated on every call to the function.
2012-04-10 17:02:24 -04:00
thatcher
05f3c1d811
several bug fixes and enhancements. legacy tile source issue discovered and corrected for images with width greater than height. adding basic support for sequenced tile sources including previous and next buttons. added mouse drag and scroll interactions for viewport navigator.
2012-04-03 03:08:27 -04:00
thatcher
94247b7225
Additional patches for keyboard accessibility
2012-03-20 21:58:23 -04:00
thatcher
825023aaf6
IE specific patch for navigator (styleFloat), also keyboard accessibility patches for firefox
2012-03-20 15:30:29 -04:00
thatcher
2e821a7dc6
IE specific patches
2012-03-20 15:00:25 -04:00
thatcher
10a0db14f7
thanks to josh1093 for finally translating the typo I couldn't make sense of when refactoring. 1 less TODO in the code base, thanks josh.
2012-03-20 03:38:27 -04:00
thatcher
75c3e02b9e
missing reference to closure level object VIEWERS, blame me, editor issue
2012-03-20 02:44:31 -04:00
thatcher
8509811c38
added correct float css syntax for navigator in firefox and older IE
2012-03-20 02:26:34 -04:00
thatcher
6443d57e09
corrected major performance issue discovered in navigator becuase minPixelRatio was set to Zero. This caused images to be loaded ad infinitum in the navigator, oops.
2012-03-19 19:03:58 -04:00
thatcher
ddaddb7f42
keyboard accessibile buttons finally
2012-03-16 11:36:28 -04:00
thatcher
4ddab463e6
error in restore from fullpagemode when toolbar option is not used. sorry, should have noticed...
2012-03-09 21:44:14 -05:00
thatcher
4b81b64fc6
Added support for specifying arbitrary element (by id) to serve as a docking 'toolbar' for navigation buttons. Added example. Also avoids loading nav images if navigation is not enabled. 0.9.25
2012-03-09 11:04:28 -05:00
thatcher
8883e358de
0.9.21 adds support for optional viewport navigator feature. see new example page
2012-03-06 22:20:00 -05:00
thatcher
3f6e8abbfc
Significant improvments to API documentation. Allow what was an object literal OpenSeadragon to be used a function which provides a simplified interface for constructing a Viewer and TileSource by simple, documented configuration settings. Major performance improvements for touch on iPhone, hopefully all mobile devices.
2012-03-01 08:38:15 -05:00
thatcher
32c950e661
more normalizing of where configurable options are located.
2012-02-28 10:01:45 -05:00
thatcher
c610a9239b
Several issues with button and buttongroup states likely a result of the refactoring were flushed out and corrected.
2012-02-28 08:07:56 -05:00
thatcher
8dc4c63f64
cleaning up config related strategies. still not happy with current implementation, though now only Viewer and Viewport directly reference a .config
2012-02-27 18:29:00 -05:00
thatcher
e73ed421e4
prefixUrl configuration option was mangled as prefixURL in OpenSeadragon.Button leading to general inconsistency.
2012-02-27 16:50:22 -05:00
thatcher
26fb61cc65
Expanding support for improved simple configuration options. Allows OpenSeadragon Viewer to be more flexibly created without direct use of API, rather focuses more on inversion of control by introspection of options passed to OpenSeadragon constructor.
2012-02-27 06:56:29 -05:00
thatcher
1a7c96732f
Fixed issued that caused flicker when using the new LegacyTileSource! Also improves performance for dzi's and other tiled images since the issue was actually in the Drawer and a result of a mistake during the refactor. This is awesome imho! Please check out the new example page to see it in action.
2012-02-23 07:18:28 -05:00
thatcher
3619ff7930
Thanks to josh1093 @ github for this one. see ticket https://github.com/thatcher/openseadragon/issues/1
2012-02-22 23:43:00 -05:00
thatcher
7255b0c594
Added support for legacy tile sources. A legacy tile source is a simple image pyramid that is created from a set of image derivatives of a while image that are increasing in size. Currently there is a modest issue that is unresolved when zooming out, the viewer has a small range in between tile source levels which appears blank. The issue is being worked on but this progress point is still worth saving.
2012-02-22 23:02:54 -05:00
thatcher
5a4e19dc1f
config option urlBase was never used. Connected it to image buttons so entire button image path didnt need to be configured. See example on http://thatcher.github.com/openseadragon/ to see how this simplified setup.
2012-02-18 13:13:05 -05:00
thatcher
14708326a0
0.9.3 includes complete skeletal jsdoc annotation, still only about 70-75% coverage in terms of complete and useful documentation for general API
2012-02-15 14:50:27 -05:00
thatcher
5245698864
removed window.location.hash debug message accidently left when committing touch event support
2012-02-09 22:54:27 -05:00
thatcher
05b8cb82fd
finished support for touch events, works great on the ipad, a little slow on iphone (I think we can scale drag and zoom better based on viewport size). Awesome
2012-02-09 22:16:09 -05:00
thatcher
1739294700
Cleaned up more of MouseTracker making properties intended to be private, private, and similarly with methods. saved documentation on meaning of private properties and methods where it was already done. MouseTracker api is proably clean enough to try to add touch screen event support now.
2012-02-02 19:12:45 -05:00
thatcher
ec77bb2a78
finally managed to clean up MouseTracker, actually uses the prototype pattern. probably too many public methods but that can be cleaned up later.
2012-02-01 16:56:04 -05:00
thatcher
5cba11c91c
replaced all references of elmt with element ( or Elmt with Element )
2012-01-31 21:01:37 -05:00
thatcher
2410b01943
finsihed removing psuedo private methods from Drawer and added many jsdoc strings, labeled 0.8.26
2012-01-31 15:59:09 -05:00
thatcher
012255d622
added jsdoc some files to project, added 'doc' task to build, started to annotate code with docs
2012-01-25 14:14:02 -05:00
thatcher
0b09cc8859
found some variables leaked globally in viewer.js - continued very minor formatting clean up in preperation of adding docs
2012-01-24 08:03:50 -05:00
thatcher
a8730a9f00
mostly superficial formating. removing $.Strings and putting it directly in $. more clean up of the Drawer update related functions
2012-01-23 22:48:45 -05:00
thatcher
bc50a7df04
finally managed to untie the knot that was Drawer _updateActual. incremented build to 0.8.20
2012-01-18 21:52:22 -05:00
thatcher
f325804ff6
work-in-progress refactor of Drawer.prototype._updateActual
2012-01-18 20:15:54 -05:00
thatcher
b3d1fcdbb4
0.8.19 - missing comment commit
2012-01-17 23:13:29 -05:00
thatcher
d38bc75180
moved all functions in OpenSeadragon.Utils to OpenSeadragon object literal to remove 'utility' anti-pattern. removed src/utils.js from build and deleted physical file. added important TODO notes to avoid overhead from browser vendor/version checks in functions, defining them once instead. incremented build id to 0.8.18
2012-01-17 18:30:41 -05:00
thatcher
8424c78c4b
renamed psuedo-private accessor _getNumTiles to actual private numberOfTiles
2012-01-11 18:32:17 -05:00
thatcher
c8b4197f79
removed duplicate definition of Drawer.prototype._compareTiles
2012-01-11 18:25:35 -05:00
thatcher
0041e32cbb
removed all psuedo-private properties from Drawer instance in favor of direct access.
2012-01-11 18:22:13 -05:00
thatcher
8f67eb6f14
finished cleaning up Viewport methods
2012-01-04 19:45:47 -05:00
thatcher
21753e6800
removed psuedo private accessors and properties in favor of direct access. cleaned up some formatting for readability
2012-01-04 18:14:20 -05:00
thatcher
878269e0e9
modifying public property names in spring.js, currentValue and currentTime are now current.point and current.time
2012-01-03 17:54:20 -05:00
thatcher
55f1e47156
removed remaining psuedo-private properties from spring.js
2012-01-03 17:44:52 -05:00
thatcher
3bff4fe532
removing psuedo-private accessors from Spring class
2011-12-29 18:18:09 -05:00
thatcher
1e21c898bf
removing psuedo-private accessors from Spring class
2011-12-29 18:16:51 -05:00
thatcher
dc841a6294
commented out unreported profiling code. removed psuedo private properties and accessors of Profiler preferring direct property access. will eventuall reconnect profiler via AOP and include 'profile' option in Viewer which is false by default
2011-12-29 17:14:42 -05:00
thatcher
3d08482144
removed identity assignment
2011-12-27 18:23:07 -05:00
thatcher
d145c129a0
removed null method Drawer.prototype.idle
2011-12-27 18:20:45 -05:00
thatcher
8ba072a1a9
removed ImageLoader abstraction (loadImage is noe method of Drawer) since its constructor was only called once and the resulting object was kept psuedo-private.
2011-12-27 18:17:24 -05:00
thatcher
e591acfadb
removed Job abstraction since it's constructor was only called in one place internally and the resulting object was private. removed file and reference in build.
2011-12-27 18:01:20 -05:00
thatcher
7854e14257
removed unused closure private methods.
2011-12-27 16:54:01 -05:00
thatcher
8e7973c094
removed now empty NavControl class and file.
2011-12-27 16:38:56 -05:00
thatcher
103c545beb
finally managed to remove final psuedo-private method _multiUpdate from Viewer, moving it into private closure scope.
2011-12-22 20:47:21 -05:00
thatcher
4d4016dbea
moved psuedo private method _updateOnce of Viewer in closure scoped private function
2011-12-22 20:36:17 -05:00
thatcher
44a997b03b
removed NavControl abstraction since it is only applied in Viewer. Made all psuedo-private _methods closure private functions which still use $.delegate ( $.delegate is a pattern I still dislike and eventually hope to remove if possible ).
2011-12-22 20:08:06 -05:00
thatcher
b061a4d830
removed initialize anti pattern from constructor in favor of doing initialization in constructor in navcontrol.js
2011-12-22 19:30:52 -05:00
thatcher
114a26b1a9
found some lingering references to 'this' in private closure methods.
2011-12-20 07:44:33 -05:00
thatcher
345e5f3e6c
completed first pass at refactor of buttons.js, next will be mousetracker so we can attack some significant anti-patterns that spill over into places like buttons.js because the MouseTracker doesnt have an idiomatic constructor. It may also be worth applying the MouseTracker as a mixin to avoid the extra .tracker property indirection.
2011-12-20 07:39:02 -05:00
thatcher
381763c19e
doh! had changed file name and class name of eventhandlerlist to just eventhandler and guess to forgot to add it back to git. plus other commits including version build id increment
2011-12-16 22:14:10 -05:00
thatcher
acfd3d0280
removed more psuedo-private methods and properties in favor of direct accessors or closure private methods. moved raiseEvent to EventHandler interface
2011-12-16 18:29:16 -05:00
thatcher
1395157adf
removed this._button from Button and renamed it to this.element since thats what this.get_element returned. may eventually move to a more jquery like pattern of extending the element with the methods of Button.
2011-12-16 17:56:38 -05:00
thatcher
7d4ffaa769
refactored EventHandlerList to just EventHandler and am prefering a mix-in on the prototype to avoid excess indirection via psuedo-private properties.
2011-12-14 18:22:02 -05:00
thatcher
01153bcb91
remove add_foo remove_foo methods in favor of adding them directly via this._events.addHandler etc. made some notes on how to replace this._events in general by mixing-in EventHandlerList to the object prototype so this.addHandler can be used directly.
2011-12-14 17:54:42 -05:00
thatcher
d7de748434
removed initialize anti-pattern in favor of using constructor. combined Button constructor arguments into idiomatic single options object
2011-12-14 17:40:22 -05:00
thatcher
7f7589e939
minor refactor of mousetracker.js
2011-12-13 20:04:38 -05:00
thatcher
f482c0fb56
removed psuedo-privacy anti-patterns from job.js in favor of simple pinning and public properties.
2011-12-13 19:10:27 -05:00
thatcher
de14271399
removed psuedo-privacy anti-patterns from imageloader.js in favor of simple pinning and public properties.
2011-12-13 18:51:35 -05:00
thatcher
c7706ba66c
removed initialize anti-pattern from dzitilesource constructor.
2011-12-13 18:34:12 -05:00
thatcher
a7050af619
removed super class prototype extension patterns from DziTileSource in favor of more concise $.extend
2011-12-13 18:29:25 -05:00
thatcher
f1882259e2
removed _DziTileSourceHelper anti-pattern in favor of direct object literal containing helper methods
2011-12-13 18:24:04 -05:00
thatcher
9642ca18e7
removed DziError from codebase. It provided no functionality not inherent in the javascript built-in Error.
2011-12-13 18:17:46 -05:00
thatcher
ced59b9827
removed empty dzi.js from src directory
2011-12-13 18:06:06 -05:00
thatcher
9b5cf799bf
removed _init anti-pattern from drawer constructor
2011-12-13 18:01:43 -05:00
thatcher
c35ee2bca9
moved only relevant object literal from controlanchor.js into control.js, deleted controlanchor.js and removed it from the build
2011-12-13 17:57:40 -05:00
thatcher
c9034f3f96
removed now empty config.js from the build
2011-12-13 17:49:59 -05:00
thatcher
dc29100f67
removed identity assignment, strange.
2011-12-13 17:43:29 -05:00
thatcher
97d2f0c765
removed overlayplacement.js and moved it's only relevant object literal directly into overlay.js
2011-12-13 17:38:36 -05:00
thatcher
7cac08a2f4
found local variable navControl that should have been a property of Viewer. removed getNavControl accessor in favor of direct property access
2011-12-13 07:24:34 -05:00
thatcher
3e39bccbbe
simplified beforeOpen, open, close in Viewer
2011-12-12 22:40:02 -05:00
thatcher
760d89a1b1
found reference to this._innerTracker so made actually put innerTrack as Viewer property in constructor. it was just a local variable. made _innerTracker use innerTrack since it isnt really private.
2011-12-12 17:40:49 -05:00
thatcher
d4740545c5
moved examples folder to gh-pages branch. fixed some refactor bugs that affected fullpage toggle. added copy to folder spcific in build.properties as WWW so the distributable openseadragon.js can be copied to gh-pages branch running locally. unearthed the ability to make controls fade (which apparently they were supposed to do by default)
2011-12-12 17:22:01 -05:00
thatcher
5dd00910f8
this is a weird one, enjoy... duplicate method and implementations
2011-12-07 21:41:07 -05:00
thatcher
1726a878c1
moving many psuedo private methods to actual closure private methods. moving many psuedo private properties and public accessors to simple public properties. see changeset for details.
2011-12-07 21:10:13 -05:00
thatcher
193ed95435
modified Viewer constructor to accept idiomatic options argument while still supporting backward compatible positional args. documented positional args and options arg. Remove Config function allowing all configuration to occur via Viewer options (which is the only place Config was called directly). removed several pointless get_x set_x function in place of direct property access.
2011-12-06 20:26:06 -05:00
thatcher
e830ec6567
cleaning up button group internal api. use options object to configure and avoid private methods and using the OpenSeaDragon delegate pattern where possible.
2011-12-06 14:48:20 -05:00
thatcher
531f73356b
changed default image path to correspond to shorter /images instead of /Scripts/images
2011-12-06 07:46:16 -05:00
thatcher
38a89c451b
removed OpenSeadragon.format because it was only called once in the entire codebase, and didnt actually format a string. Instead just be direct and return string. corrected treatment of prefixUrl at that location since it was ignored otherwise.
2011-12-06 07:41:43 -05:00
thatcher
b871f6c2bf
removed global variable SIGNAL. moved it into OpenSeadragon namespace
2011-12-06 07:21:30 -05:00
thatcher
916ada5f02
Added simple ant build. Broke main file into composite parts in src directory. Concatenated release is still included in the project as a release artifact.
2011-12-05 22:50:25 -05:00
