Commit Graph

126 Commits

Author SHA1 Message Date
thatcher
8dc4c63f64 cleaning up config related strategies. still not happy with current implementation, though now only Viewer and Viewport directly reference a .config 2012-02-27 18:29:00 -05:00
thatcher
e73ed421e4 prefixUrl configuration option was mangled as prefixURL in OpenSeadragon.Button leading to general inconsistency. 2012-02-27 16:50:22 -05:00
thatcher
26fb61cc65 Expanding support for improved simple configuration options. Allows OpenSeadragon Viewer to be more flexibly created without direct use of API, rather focuses more on inversion of control by introspection of options passed to OpenSeadragon constructor. 2012-02-27 06:56:29 -05:00
thatcher
1a7c96732f Fixed issued that caused flicker when using the new LegacyTileSource! Also improves performance for dzi's and other tiled images since the issue was actually in the Drawer and a result of a mistake during the refactor. This is awesome imho! Please check out the new example page to see it in action. 2012-02-23 07:18:28 -05:00
thatcher
3619ff7930 Thanks to josh1093 @ github for this one. see ticket https://github.com/thatcher/openseadragon/issues/1 2012-02-22 23:43:00 -05:00
thatcher
7255b0c594 Added support for legacy tile sources. A legacy tile source is a simple image pyramid that is created from a set of image derivatives of a while image that are increasing in size. Currently there is a modest issue that is unresolved when zooming out, the viewer has a small range in between tile source levels which appears blank. The issue is being worked on but this progress point is still worth saving. 2012-02-22 23:02:54 -05:00
thatcher
5a4e19dc1f config option urlBase was never used. Connected it to image buttons so entire button image path didnt need to be configured. See example on http://thatcher.github.com/openseadragon/ to see how this simplified setup. 2012-02-18 13:13:05 -05:00
thatcher
14708326a0 0.9.3 includes complete skeletal jsdoc annotation, still only about 70-75% coverage in terms of complete and useful documentation for general API 2012-02-15 14:50:27 -05:00
thatcher
5245698864 removed window.location.hash debug message accidently left when committing touch event support 2012-02-09 22:54:27 -05:00
thatcher
05b8cb82fd finished support for touch events, works great on the ipad, a little slow on iphone (I think we can scale drag and zoom better based on viewport size). Awesome 2012-02-09 22:16:09 -05:00
thatcher
1739294700 Cleaned up more of MouseTracker making properties intended to be private, private, and similarly with methods. saved documentation on meaning of private properties and methods where it was already done. MouseTracker api is proably clean enough to try to add touch screen event support now. 2012-02-02 19:12:45 -05:00
thatcher
ec77bb2a78 finally managed to clean up MouseTracker, actually uses the prototype pattern. probably too many public methods but that can be cleaned up later. 2012-02-01 16:56:04 -05:00
thatcher
5cba11c91c replaced all references of elmt with element ( or Elmt with Element ) 2012-01-31 21:01:37 -05:00
thatcher
2410b01943 finsihed removing psuedo private methods from Drawer and added many jsdoc strings, labeled 0.8.26 2012-01-31 15:59:09 -05:00
thatcher
012255d622 added jsdoc some files to project, added 'doc' task to build, started to annotate code with docs 2012-01-25 14:14:02 -05:00
thatcher
0b09cc8859 found some variables leaked globally in viewer.js - continued very minor formatting clean up in preperation of adding docs 2012-01-24 08:03:50 -05:00
thatcher
a8730a9f00 mostly superficial formating. removing $.Strings and putting it directly in $. more clean up of the Drawer update related functions 2012-01-23 22:48:45 -05:00
thatcher
bc50a7df04 finally managed to untie the knot that was Drawer _updateActual. incremented build to 0.8.20 2012-01-18 21:52:22 -05:00
thatcher
f325804ff6 work-in-progress refactor of Drawer.prototype._updateActual 2012-01-18 20:15:54 -05:00
thatcher
b3d1fcdbb4 0.8.19 - missing comment commit 2012-01-17 23:13:29 -05:00
thatcher
d38bc75180 moved all functions in OpenSeadragon.Utils to OpenSeadragon object literal to remove 'utility' anti-pattern. removed src/utils.js from build and deleted physical file. added important TODO notes to avoid overhead from browser vendor/version checks in functions, defining them once instead. incremented build id to 0.8.18 2012-01-17 18:30:41 -05:00
thatcher
3bfb693872 incremented build 2012-01-11 23:58:30 -05:00
thatcher
8424c78c4b renamed psuedo-private accessor _getNumTiles to actual private numberOfTiles 2012-01-11 18:32:17 -05:00
thatcher
c8b4197f79 removed duplicate definition of Drawer.prototype._compareTiles 2012-01-11 18:25:35 -05:00
thatcher
0041e32cbb removed all psuedo-private properties from Drawer instance in favor of direct access. 2012-01-11 18:22:13 -05:00
thatcher
4eba38dd86 imcrementing build id 2012-01-04 19:46:46 -05:00
thatcher
8f67eb6f14 finished cleaning up Viewport methods 2012-01-04 19:45:47 -05:00
thatcher
21753e6800 removed psuedo private accessors and properties in favor of direct access. cleaned up some formatting for readability 2012-01-04 18:14:20 -05:00
thatcher
878269e0e9 modifying public property names in spring.js, currentValue and currentTime are now current.point and current.time 2012-01-03 17:54:20 -05:00
thatcher
55f1e47156 removed remaining psuedo-private properties from spring.js 2012-01-03 17:44:52 -05:00
thatcher
1e21c898bf removing psuedo-private accessors from Spring class 2011-12-29 18:16:51 -05:00
thatcher
dc841a6294 commented out unreported profiling code. removed psuedo private properties and accessors of Profiler preferring direct property access. will eventuall reconnect profiler via AOP and include 'profile' option in Viewer which is false by default 2011-12-29 17:14:42 -05:00
thatcher
2b8fd1941d 0.8.16 2011-12-27 20:58:43 -05:00
thatcher
27189ae583 removed identity assignment 2011-12-27 20:58:16 -05:00
thatcher
d145c129a0 removed null method Drawer.prototype.idle 2011-12-27 18:20:45 -05:00
thatcher
8ba072a1a9 removed ImageLoader abstraction (loadImage is noe method of Drawer) since its constructor was only called once and the resulting object was kept psuedo-private. 2011-12-27 18:17:24 -05:00
thatcher
e591acfadb removed Job abstraction since it's constructor was only called in one place internally and the resulting object was private. removed file and reference in build. 2011-12-27 18:01:20 -05:00
thatcher
7854e14257 removed unused closure private methods. 2011-12-27 16:54:01 -05:00
thatcher
8e7973c094 removed now empty NavControl class and file. 2011-12-27 16:38:56 -05:00
thatcher
6769432851 incremented release build counter. 0.8.15 2011-12-22 20:48:27 -05:00
thatcher
103c545beb finally managed to remove final psuedo-private method _multiUpdate from Viewer, moving it into private closure scope. 2011-12-22 20:47:21 -05:00
thatcher
4d4016dbea moved psuedo private method _updateOnce of Viewer in closure scoped private function 2011-12-22 20:36:17 -05:00
thatcher
44a997b03b removed NavControl abstraction since it is only applied in Viewer. Made all psuedo-private _methods closure private functions which still use $.delegate ( $.delegate is a pattern I still dislike and eventually hope to remove if possible ). 2011-12-22 20:08:06 -05:00
thatcher
b061a4d830 removed initialize anti pattern from constructor in favor of doing initialization in constructor in navcontrol.js 2011-12-22 19:30:52 -05:00
thatcher
114a26b1a9 found some lingering references to 'this' in private closure methods. 2011-12-20 07:44:33 -05:00
thatcher
345e5f3e6c completed first pass at refactor of buttons.js, next will be mousetracker so we can attack some significant anti-patterns that spill over into places like buttons.js because the MouseTracker doesnt have an idiomatic constructor. It may also be worth applying the MouseTracker as a mixin to avoid the extra .tracker property indirection. 2011-12-20 07:39:02 -05:00
thatcher
381763c19e doh! had changed file name and class name of eventhandlerlist to just eventhandler and guess to forgot to add it back to git. plus other commits including version build id increment 2011-12-16 22:14:10 -05:00
thatcher
acfd3d0280 removed more psuedo-private methods and properties in favor of direct accessors or closure private methods. moved raiseEvent to EventHandler interface 2011-12-16 18:29:16 -05:00
thatcher
1395157adf removed this._button from Button and renamed it to this.element since thats what this.get_element returned. may eventually move to a more jquery like pattern of extending the element with the methods of Button. 2011-12-16 17:56:38 -05:00
thatcher
7d4ffaa769 refactored EventHandlerList to just EventHandler and am prefering a mix-in on the prototype to avoid excess indirection via psuedo-private properties. 2011-12-14 18:22:02 -05:00
thatcher
01153bcb91 remove add_foo remove_foo methods in favor of adding them directly via this._events.addHandler etc. made some notes on how to replace this._events in general by mixing-in EventHandlerList to the object prototype so this.addHandler can be used directly. 2011-12-14 17:54:42 -05:00
thatcher
d7de748434 removed initialize anti-pattern in favor of using constructor. combined Button constructor arguments into idiomatic single options object 2011-12-14 17:40:22 -05:00
thatcher
7f7589e939 minor refactor of mousetracker.js 2011-12-13 20:04:38 -05:00
thatcher
f482c0fb56 removed psuedo-privacy anti-patterns from job.js in favor of simple pinning and public properties. 2011-12-13 19:10:27 -05:00
thatcher
de14271399 removed psuedo-privacy anti-patterns from imageloader.js in favor of simple pinning and public properties. 2011-12-13 18:51:35 -05:00
thatcher
c7706ba66c removed initialize anti-pattern from dzitilesource constructor. 2011-12-13 18:34:12 -05:00
thatcher
a7050af619 removed super class prototype extension patterns from DziTileSource in favor of more concise $.extend 2011-12-13 18:29:25 -05:00
thatcher
f1882259e2 removed _DziTileSourceHelper anti-pattern in favor of direct object literal containing helper methods 2011-12-13 18:24:04 -05:00
thatcher
9642ca18e7 removed DziError from codebase. It provided no functionality not inherent in the javascript built-in Error. 2011-12-13 18:17:46 -05:00
thatcher
ced59b9827 removed empty dzi.js from src directory 2011-12-13 18:06:06 -05:00
thatcher
c35ee2bca9 moved only relevant object literal from controlanchor.js into control.js, deleted controlanchor.js and removed it from the build 2011-12-13 17:57:40 -05:00
thatcher
c9034f3f96 removed now empty config.js from the build 2011-12-13 17:49:59 -05:00
thatcher
d702810ae7 removed overlayplacement.js from the build 2011-12-13 17:40:52 -05:00
thatcher
7cac08a2f4 found local variable navControl that should have been a property of Viewer. removed getNavControl accessor in favor of direct property access 2011-12-13 07:24:34 -05:00
thatcher
3e39bccbbe simplified beforeOpen, open, close in Viewer 2011-12-12 22:40:02 -05:00
thatcher
3c31094514 removing all get_x set_x patterns from constructor. just access (ie get/set) the property directly. 2011-12-12 17:45:43 -05:00
thatcher
760d89a1b1 found reference to this._innerTracker so made actually put innerTrack as Viewer property in constructor. it was just a local variable. made _innerTracker use innerTrack since it isnt really private. 2011-12-12 17:40:49 -05:00
thatcher
d4740545c5 moved examples folder to gh-pages branch. fixed some refactor bugs that affected fullpage toggle. added copy to folder spcific in build.properties as WWW so the distributable openseadragon.js can be copied to gh-pages branch running locally. unearthed the ability to make controls fade (which apparently they were supposed to do by default) 2011-12-12 17:22:01 -05:00
thatcher
5dd00910f8 this is a weird one, enjoy... duplicate method and implementations 2011-12-07 21:41:07 -05:00
thatcher
1726a878c1 moving many psuedo private methods to actual closure private methods. moving many psuedo private properties and public accessors to simple public properties. see changeset for details. 2011-12-07 21:10:13 -05:00
thatcher
193ed95435 modified Viewer constructor to accept idiomatic options argument while still supporting backward compatible positional args. documented positional args and options arg. Remove Config function allowing all configuration to occur via Viewer options (which is the only place Config was called directly). removed several pointless get_x set_x function in place of direct property access. 2011-12-06 20:26:06 -05:00
thatcher
e830ec6567 cleaning up button group internal api. use options object to configure and avoid private methods and using the OpenSeaDragon delegate pattern where possible. 2011-12-06 14:48:20 -05:00
thatcher
531f73356b changed default image path to correspond to shorter /images instead of /Scripts/images 2011-12-06 07:46:16 -05:00
thatcher
38a89c451b removed OpenSeadragon.format because it was only called once in the entire codebase, and didnt actually format a string. Instead just be direct and return string. corrected treatment of prefixUrl at that location since it was ignored otherwise. 2011-12-06 07:41:43 -05:00
thatcher
b871f6c2bf removed global variable SIGNAL. moved it into OpenSeadragon namespace 2011-12-06 07:21:30 -05:00
thatcher
916ada5f02 Added simple ant build. Broke main file into composite parts in src directory. Concatenated release is still included in the project as a release artifact. 2011-12-05 22:50:25 -05:00