Commit Graph

1371 Commits

Author SHA1 Message Date
thatcher
f325804ff6 work-in-progress refactor of Drawer.prototype._updateActual 2012-01-18 20:15:54 -05:00
thatcher
b3d1fcdbb4 0.8.19 - missing comment commit 2012-01-17 23:13:29 -05:00
thatcher
d38bc75180 moved all functions in OpenSeadragon.Utils to OpenSeadragon object literal to remove 'utility' anti-pattern. removed src/utils.js from build and deleted physical file. added important TODO notes to avoid overhead from browser vendor/version checks in functions, defining them once instead. incremented build id to 0.8.18 2012-01-17 18:30:41 -05:00
thatcher
3bfb693872 incremented build 2012-01-11 23:58:30 -05:00
thatcher
8424c78c4b renamed psuedo-private accessor _getNumTiles to actual private numberOfTiles 2012-01-11 18:32:17 -05:00
thatcher
c8b4197f79 removed duplicate definition of Drawer.prototype._compareTiles 2012-01-11 18:25:35 -05:00
thatcher
0041e32cbb removed all psuedo-private properties from Drawer instance in favor of direct access. 2012-01-11 18:22:13 -05:00
thatcher
4eba38dd86 imcrementing build id 2012-01-04 19:46:46 -05:00
thatcher
8f67eb6f14 finished cleaning up Viewport methods 2012-01-04 19:45:47 -05:00
thatcher
21753e6800 removed psuedo private accessors and properties in favor of direct access. cleaned up some formatting for readability 2012-01-04 18:14:20 -05:00
thatcher
878269e0e9 modifying public property names in spring.js, currentValue and currentTime are now current.point and current.time 2012-01-03 17:54:20 -05:00
thatcher
55f1e47156 removed remaining psuedo-private properties from spring.js 2012-01-03 17:44:52 -05:00
thatcher
3bff4fe532 removing psuedo-private accessors from Spring class 2011-12-29 18:18:09 -05:00
thatcher
1e21c898bf removing psuedo-private accessors from Spring class 2011-12-29 18:16:51 -05:00
thatcher
dc841a6294 commented out unreported profiling code. removed psuedo private properties and accessors of Profiler preferring direct property access. will eventuall reconnect profiler via AOP and include 'profile' option in Viewer which is false by default 2011-12-29 17:14:42 -05:00
thatcher
2b8fd1941d 0.8.16 2011-12-27 20:58:43 -05:00
thatcher
27189ae583 removed identity assignment 2011-12-27 20:58:16 -05:00
thatcher
3d08482144 removed identity assignment 2011-12-27 18:23:07 -05:00
thatcher
d145c129a0 removed null method Drawer.prototype.idle 2011-12-27 18:20:45 -05:00
thatcher
8ba072a1a9 removed ImageLoader abstraction (loadImage is noe method of Drawer) since its constructor was only called once and the resulting object was kept psuedo-private. 2011-12-27 18:17:24 -05:00
thatcher
e591acfadb removed Job abstraction since it's constructor was only called in one place internally and the resulting object was private. removed file and reference in build. 2011-12-27 18:01:20 -05:00
thatcher
7854e14257 removed unused closure private methods. 2011-12-27 16:54:01 -05:00
thatcher
8e7973c094 removed now empty NavControl class and file. 2011-12-27 16:38:56 -05:00
thatcher
6769432851 incremented release build counter. 0.8.15 2011-12-22 20:48:27 -05:00
thatcher
103c545beb finally managed to remove final psuedo-private method _multiUpdate from Viewer, moving it into private closure scope. 2011-12-22 20:47:21 -05:00
thatcher
4d4016dbea moved psuedo private method _updateOnce of Viewer in closure scoped private function 2011-12-22 20:36:17 -05:00
thatcher
44a997b03b removed NavControl abstraction since it is only applied in Viewer. Made all psuedo-private _methods closure private functions which still use $.delegate ( $.delegate is a pattern I still dislike and eventually hope to remove if possible ). 2011-12-22 20:08:06 -05:00
thatcher
b061a4d830 removed initialize anti pattern from constructor in favor of doing initialization in constructor in navcontrol.js 2011-12-22 19:30:52 -05:00
thatcher
114a26b1a9 found some lingering references to 'this' in private closure methods. 2011-12-20 07:44:33 -05:00
thatcher
345e5f3e6c completed first pass at refactor of buttons.js, next will be mousetracker so we can attack some significant anti-patterns that spill over into places like buttons.js because the MouseTracker doesnt have an idiomatic constructor. It may also be worth applying the MouseTracker as a mixin to avoid the extra .tracker property indirection. 2011-12-20 07:39:02 -05:00
thatcher
381763c19e doh! had changed file name and class name of eventhandlerlist to just eventhandler and guess to forgot to add it back to git. plus other commits including version build id increment 2011-12-16 22:14:10 -05:00
thatcher
acfd3d0280 removed more psuedo-private methods and properties in favor of direct accessors or closure private methods. moved raiseEvent to EventHandler interface 2011-12-16 18:29:16 -05:00
thatcher
1395157adf removed this._button from Button and renamed it to this.element since thats what this.get_element returned. may eventually move to a more jquery like pattern of extending the element with the methods of Button. 2011-12-16 17:56:38 -05:00
thatcher
661eb225f9 should have incremented patch build number 2011-12-14 23:39:49 -05:00
thatcher
7d4ffaa769 refactored EventHandlerList to just EventHandler and am prefering a mix-in on the prototype to avoid excess indirection via psuedo-private properties. 2011-12-14 18:22:02 -05:00
thatcher
01153bcb91 remove add_foo remove_foo methods in favor of adding them directly via this._events.addHandler etc. made some notes on how to replace this._events in general by mixing-in EventHandlerList to the object prototype so this.addHandler can be used directly. 2011-12-14 17:54:42 -05:00
thatcher
d7de748434 removed initialize anti-pattern in favor of using constructor. combined Button constructor arguments into idiomatic single options object 2011-12-14 17:40:22 -05:00
thatcher
7f7589e939 minor refactor of mousetracker.js 2011-12-13 20:04:38 -05:00
thatcher
f482c0fb56 removed psuedo-privacy anti-patterns from job.js in favor of simple pinning and public properties. 2011-12-13 19:10:27 -05:00
thatcher
de14271399 removed psuedo-privacy anti-patterns from imageloader.js in favor of simple pinning and public properties. 2011-12-13 18:51:35 -05:00
thatcher
c7706ba66c removed initialize anti-pattern from dzitilesource constructor. 2011-12-13 18:34:12 -05:00
thatcher
a7050af619 removed super class prototype extension patterns from DziTileSource in favor of more concise $.extend 2011-12-13 18:29:25 -05:00
thatcher
f1882259e2 removed _DziTileSourceHelper anti-pattern in favor of direct object literal containing helper methods 2011-12-13 18:24:04 -05:00
thatcher
9642ca18e7 removed DziError from codebase. It provided no functionality not inherent in the javascript built-in Error. 2011-12-13 18:17:46 -05:00
thatcher
ced59b9827 removed empty dzi.js from src directory 2011-12-13 18:06:06 -05:00
thatcher
9b5cf799bf removed _init anti-pattern from drawer constructor 2011-12-13 18:01:43 -05:00
thatcher
c35ee2bca9 moved only relevant object literal from controlanchor.js into control.js, deleted controlanchor.js and removed it from the build 2011-12-13 17:57:40 -05:00
thatcher
c9034f3f96 removed now empty config.js from the build 2011-12-13 17:49:59 -05:00
thatcher
dc29100f67 removed identity assignment, strange. 2011-12-13 17:43:29 -05:00
thatcher
d702810ae7 removed overlayplacement.js from the build 2011-12-13 17:40:52 -05:00