Commit Graph

1957 Commits

Author SHA1 Message Date
Ian Gilman
cec0acafe1
Merge pull request #2328 from craigberry/master
Handle XML embedded in tilesource JSON
2023-04-04 14:48:52 -07:00
Craig A. Berry
bff93af17e Handle XML embedded in tilesource JSON
The existing check for whether the tilesource data is XML or JSON
looks for a tag anywhere in the response content, which incorrectly
flags the content as XML in the case where it is really JSON with
XML embedded in it.

This commit corrects that problem by requiring the tag to occur as
the first non-whitespace part of the content. This is basically a
poor person's well-formedness check since well-formed XML cannot
have non-whitespace content outside of the root node.

N.B. While malformed XML content with non-whitespace characters
before the first element has been getting identified as XML, it
has not been getting parsed correctly.  With current parsing
infrastructure, the content has been getting replaced by a parsing
error message.  With more up-to-date parsing infrastructure, it
will throw an error.  Either way we're not losing anything by failing
to identify malformed XML as XML.

Addresses issue #2325.
2023-03-30 16:38:35 -05:00
Rainer Simon
84d2dcf11d Applied touch rotate fix suggested in #2319 2023-03-25 18:38:58 +01:00
donotloveshampo
244e54da69
Fixed #2314 2023-03-17 16:27:12 +08:00
Ian Gilman
2ae9fb0e13
Merge pull request #2317 from pearcetm/after-resize-event
Add after-resize event
2023-03-16 13:22:50 -07:00
Tom
fb32cc7198 add after-resize event 2023-03-13 22:19:06 -04:00
Tom
a01c230b6e partial bugfix for #2312 2023-03-13 21:56:06 -04:00
Ian Gilman
cbb0a009e7
Merge pull request #2293 from pearcetm/zoom-constraints-fix
Take zoom constraint into account within _fitBounds
2023-03-10 13:49:41 -08:00
Mohit Bansal
8a201c12b4 add given button function to buttongroup 2023-02-28 01:05:22 +05:30
Mohit Bansal
f393547d9e add custom button 2023-02-27 23:52:29 +05:30
Mohit Bansal
795e85bebb update doc comments 2023-02-22 10:21:51 +05:30
Mohit Bansal
c05af1d38b add focus and blur event 2023-02-19 15:49:43 +05:30
Kevin Britten
8ec6e55304
Merge branch 'openseadragon:master' into docs/button-type-fix 2023-02-16 17:21:44 -05:00
Kevin Britten
cf3bf91b8d add type Element to documentation for custom ui buttons 2023-02-16 14:51:30 -05:00
Mohit Bansal
0ab81df9b8 remove unwanted property 2023-02-15 09:37:03 +05:30
Mohit Bansal
6be459e451 formatting 2023-02-13 23:13:08 +05:30
Mohit Bansal
78928e3510 add comment 2023-02-13 23:01:19 +05:30
Mohit Bansal
4909320089 correction of keyCode 2023-02-12 13:30:41 +05:30
Mohit Bansal
3a8738fd43 spacing && documentation 2023-02-12 12:43:41 +05:30
Mohit Bansal
dac697c74e formatting 2023-02-10 16:44:55 +05:30
Mohit Bansal
4bc9ea4573 add keypress handler's event 2023-02-09 12:55:44 +05:30
Mohit Bansal
cfa88b701f replace canvasKeyPressEventArgs to canvasKeyDownEventArgs 2023-02-08 19:22:27 +05:30
Tom
16fc72d8fb Take zoom constraint into account within _fitBounds when constraints = true and immediately = false 2023-02-07 18:12:26 -05:00
Mohit Bansal
f36d44dc67 Consolidate viewer keyboard handling into keydown handler 2023-02-07 03:31:57 +05:30
Aiosa
37d4f62ce9 Remove discouraging note on getCompletionCallback use docs. 2023-02-02 17:18:12 +01:00
Aiosa
57486732b1 Prevent early tile completion with call order instead of guard flag. Improve getCompletionCallback docs. 2023-02-01 10:25:10 +01:00
Aiosa
55e7d2439a Change completionCallback with 'tile-loaded' event to support original scenario of async completion notification with additional guarding flags. 2023-01-31 08:05:02 +01:00
Aiosa
81d86570da Typo in the stopping comparison condition. 2023-01-28 14:08:00 +01:00
Aiosa
947109718c Ensure tile-loaded event completionCallback is called only once. Check when context2D used after cache creation. 2023-01-28 08:42:07 +01:00
Damian Murawski
2484de5010
remove trailing space 2023-01-26 11:44:39 +01:00
Damian Murawski
8550b4fea5
fix problem with click precision on ReferenceStrip
temporary fix for #1992 . Just adding 4px which works in all use cases.
2023-01-25 23:15:12 +01:00
Ian Gilman
6f7e8c7a49
Merge pull request #2238 from Ughuuu/pr-1386-3
add loop for re-trying failed tiles [Take 3]
2023-01-24 15:15:58 -08:00
Dragos Daian
b4700d28bd Also add documentation for tileRetryDelay 2023-01-23 22:16:05 +01:00
Dragos Daian
f0f12c459e try fix with check for null and undefined 2023-01-23 22:10:23 +01:00
Dragos Daian
5d70a807da fix build error 2023-01-23 19:54:51 +01:00
Dragos Daian
77bc130636 Add tileRetryMax documentation. 2023-01-23 19:49:43 +01:00
Aiosa
377f2bd04f Merge branch 'master' of github.com:RationAI/openseadragon 2023-01-21 09:00:58 +01:00
Aiosa
7a7acdbe57
Merge branch 'openseadragon:master' into master 2023-01-21 08:00:29 +00:00
Aiosa
de00939d8d Revert async support and event breaking support in EventSource. 2023-01-21 09:00:24 +01:00
ambujsahu81
f3a76a267c add box-sizing property to the navigator display region 2023-01-20 18:26:54 +05:30
Aiosa
c8dbb2c757 Implement support for async function and promise type recognition with $.type. Add $.Promise proxy. Implement support for promises in EventSource. Implement ability to abort events as well as prioritize events. 2023-01-17 11:13:48 +01:00
Haris Ghauri
a9f0523b62 issues/2192 fix. 2023-01-11 23:15:24 -05:00
Ian Gilman
c93df98363 JSDoc fixes 2022-12-16 14:14:40 -08:00
Ian Gilman
1351ac018a
Merge pull request #2256 from pearcetm/resize-listener
work in progress about viewer resize behavior
2022-12-16 13:48:45 -08:00
Ian Gilman
3342b7880d
Merge pull request #2249 from pearcetm/rotated-constraints-fix
fixed viewport constraint behavior when viewer is rotated
2022-12-15 13:57:44 -08:00
Tom
67fc9eafe8 disabled autoResize for navigator 2022-12-14 10:53:40 -05:00
Tom
9ccf93d767 cleaning up changes 2022-12-14 09:25:23 -05:00
Tom
9daa8feec1 cleaning up changes; modified demo 2022-12-14 09:21:52 -05:00
Tom
9048abb05e Merge branch 'master' into resize-listener 2022-12-13 18:31:42 -05:00
Tom
69297c0181 Updated resize behavior 2022-12-13 16:49:23 -05:00
Tom
37a024f023 bugfix in getCenter during zoom animation 2022-12-10 07:02:16 -05:00
Tom
86c105beaa bugfix in getCenter during zoom animation 2022-12-10 06:57:53 -05:00
Tom
2afd61b05d updates to work in progress 2022-12-08 23:12:28 -05:00
Tom
7e1b5c5665 fixed typo in documentation 2022-12-07 18:03:59 -05:00
Tom
54af53cf4e work in progress about viewer resize behavior 2022-12-07 17:46:25 -05:00
Ian Gilman
de4eac5a06
Merge pull request #2206 from filak/master
Update iiiftilesource.js
2022-12-07 14:21:47 -08:00
Tom
524b42c778 demo update 2022-12-06 17:21:03 -05:00
Tom
66b4b29424 small cleanup 2022-12-06 16:53:19 -05:00
Tom
256514bca6 small cleanup 2022-12-06 16:52:48 -05:00
Tom
757bf8690e fix Viewport._fixBounds to work with boundary constraints, and updated the demo page to show the behavior. 2022-12-06 16:42:13 -05:00
Tom
845cbced69 reverted Viewport.setRotation, created Viewport.setRotationWithPivot 2022-12-05 19:40:30 -05:00
Tom
05997d359c reverted Viewport.setRotation, created Viewport.setRotationWithPivot 2022-12-05 19:38:46 -05:00
Tom
78c6295acf update unit tests 2022-12-02 22:08:15 -05:00
Tom
5aca85fe21 Merge branch 'master' of https://github.com/openseadragon/openseadragon into rotated-constraints-fix 2022-12-02 19:36:39 -05:00
Tom
8744a429f1 added documentation to _raiseConstraintsEvent 2022-12-02 18:48:28 -05:00
Tom
aede32c335 added documentation to getConstrainedBounds 2022-12-02 18:46:57 -05:00
Ian Gilman
eb85b4498f
Merge pull request #2247 from JohnReagan/1970/support-tile-source-url-getter
Add support for dynamic urls from tile source. Fixes #1970
2022-12-02 14:16:40 -08:00
Tom
ac18d5629d fixed viewport constraint behavior when viewer is rotated 2022-12-02 16:43:39 -05:00
Ian Gilman
c92fe116c5
Merge pull request #2246 from pearcetm/boundary-constraints-fix
boundary constraint logic fix
2022-11-30 14:12:16 -08:00
Tom
bd8e8a9e7f add line spacing 2022-11-30 16:48:04 -05:00
John Reagan
601160e9fb Add support for dynamic urls from tile source. Fixes #1970 2022-11-30 15:38:57 -05:00
Tom
5aa5d7ad56 removed extra space 2022-11-29 17:43:14 -05:00
Tom
554149cf4f merged .gitignore changes 2022-11-28 17:56:05 -05:00
Tom
968cb96bc4 added before-destroy event; reverted viewport boundary constraint changes 2022-11-28 17:54:23 -05:00
Tom
6d35f6df2c boundary constraint logic fix 2022-11-28 17:45:21 -05:00
Tom
6fa8e6695d viewport _applyBoundaryConstraints fix 2022-11-26 12:04:05 -05:00
Tom
29384cd5ff Added event for viewer destroy 2022-11-23 15:28:40 -05:00
Tom
d55ccdf557 resolved package-lock.json conflict 2022-11-22 13:01:00 -05:00
Dragos Daian
c3dec09d9c add loop for re-trying failed tiles [Take 3] 2022-11-20 12:27:51 +01:00
Tom
7454d4323d updated setRotation param order to match rotateBy/rotateTo, deprecation warning for setting degrees, and private API 2022-11-16 18:07:56 -05:00
Hamza Tatheer
7c44dc64bc Update viewer.js 2022-11-16 15:48:45 +05:00
Tom
2f174ad552 updated rotateBy 2022-11-15 23:51:44 -05:00
Tom
7f2725ba49 Slight API tweaks; added checks to rotationPivot 2022-11-15 19:01:19 -05:00
Tom
84bbc27a17 Add rotateBy and rotateTo to the API 2022-11-12 18:20:26 -05:00
Tom
bfddf7355b Add rotateBy and rotateTo to the API 2022-11-12 18:18:25 -05:00
Hamza Tatheer
6540a57aa9 pr changes 2022-11-12 16:32:45 +05:00
Tom
51807a77f0 implemented rotation about a pivot point in viewport coordinates 2022-11-11 22:15:52 -05:00
Hamza Tatheer
cb2fbe9b50 pr changes latest 2022-11-06 18:23:12 +05:00
Hamza Tatheer
fccab2da56 pr fixes 2022-11-03 23:55:35 +05:00
Hamza Tatheer
e4d9dcdd03 Triple Click Bug Fix 2022-10-30 01:27:56 +05:00
Hamza Tatheer
05b596ce32 space removed 2022-10-29 21:47:37 +05:00
Hamza Tatheer
ca88de8e7f double click drag same position constraint removed 2022-10-29 21:46:12 +05:00
Hamza Tatheer
d44fc85582 pr changes 2022-10-29 21:22:25 +05:00
Hamza Tatheer
a0ac8666e0 Merge branch 'master' of https://github.com/HamzaTatheer/openseadragon 2022-10-29 20:18:23 +05:00
Hamza Tatheer
af3801367a
Merge branch 'openseadragon:master' into master 2022-10-26 11:03:28 +05:00
Ian Gilman
af564547f0
Merge pull request #2212 from joedf/regression-fix-2201
Undefined check for object descriptor
2022-10-24 14:16:21 -07:00
Hamza Tatheer
89ab847ef6 bug fix 2022-10-24 23:17:03 +05:00
Hamza Tatheer
2f28970e32 zoom infinite 2022-10-24 11:08:37 +05:00
Hamza Tatheer
e12a626efb hide toolbar 2022-10-23 23:51:27 +05:00
Hamza Tatheer
2f2285711d Update viewer.js 2022-10-23 01:30:16 +05:00
Hamza Tatheer
3a0bb0cd58 orignal Config 2022-10-22 15:50:18 +05:00
Hamza Tatheer
41a07b2250 zoom equation updated 2022-10-22 15:47:12 +05:00
Hamza Tatheer
cd9c5032f8 functionality test 2022-10-22 12:15:28 +05:00
Ian Gilman
d5bcbcec3a
Merge pull request #2220 from jssullivan/master
Fixes #2219 TypeError: Cannot set property buttons of [object Object] which has only a getter when initializing OpenSeaDragon
2022-10-20 14:27:29 -07:00
Joe DF
aec24d6dd7 add continue, update warning msg 2022-10-19 16:07:35 -04:00
Jimmy Sullivan
13330c4ede
Update viewer.js
Remove erroneous whitespace
2022-10-19 11:35:49 -04:00
Jimmy Sullivan
8bb600f6ae
Update viewer.js
Change removing buttons, to renaming it buttonGroup
2022-10-19 11:35:08 -04:00
Shyamkumar Yadav
98972d22d1
docs: fix a jsdoc 2022-10-19 10:25:37 +05:30
james.sullivan
f87310c082 Fix initilization crash caused by Extend and buttons getter 2022-10-14 10:47:48 -04:00
Joe DF
476657ecad undefined check for obj. descriptor 2022-10-10 15:12:30 -04:00
Shyamkumar Yadav
5baa8d3252
docs: change @return -> @returns 2022-10-10 01:12:18 +05:30
filak
ce45e34265 Update iiiftilesource.js 2022-09-26 17:26:43 +02:00
Joe DF
6d74b684ec implement @iangilman 's fix 2022-09-17 17:10:03 +02:00
Joe DF
7497b83525 based on @pearcetm 's fix 2022-09-10 21:31:15 -04:00
Ian Gilman
d3ef767487
Merge pull request #2136 from jonasengelmann/master
Viewport rotation animation
2022-08-23 14:13:22 -07:00
jonasengelmann
5f50d9e59e reworked setRotation to allow all degree values 2022-08-22 15:34:29 +02:00
jonasengelmann
9bce0e696c removed redundant EuclideanModulo function 2022-08-22 15:31:35 +02:00
Aiosa
61c77a3440 Fix hash tile generation by checking the validity of URL input parameter and fallback to level, x, y variables. 2022-08-21 10:09:36 +02:00
Aiosa
298f069c7e Change missing cacheKey in Tilesource constructor to warning. Provide default implementation of getTileHashKey for tileSource if the tileSource does not inherit from OpenSeadragon.TileSource 2022-08-09 10:40:57 +01:00
pearcetm
45643b94e3
Update button.js 2022-07-28 17:55:21 -04:00
pearcetm
6d5a75bcf7
Bugfix for enable/disable methods for Buttons
Fixes https://github.com/openseadragon/openseadragon/issues/2185
2022-07-28 17:53:49 -04:00
altert
5829a9e892 fix closure for croppingPolygons in drawTile 2022-07-26 13:12:48 +05:30
jonasengelmann
ddd4a05e5e Revert "always return Euclidean modulo of current rotation"
This reverts commit 32af983910.
2022-07-07 16:31:35 +02:00
jonasengelmann
32af983910 always return Euclidean modulo of current rotation 2022-06-29 20:32:47 +02:00
jonasengelmann
3cdd94e465 constrained rotation to shortest path 2022-06-29 19:47:26 +02:00
jonasengelmann
1b27e59be8 added Euclidean modulo helper function 2022-06-29 19:47:03 +02:00
Aiosa
bb1755613e Merge branch 'master' of https://github.com/openseadragon/openseadragon into openseadragon-master
# Conflicts:
#	src/tiledimage.js
2022-06-28 14:11:02 +02:00
Jirka
7b759558b1 Add tile reference to imagejob options. 2022-06-07 14:53:18 +02:00
Aiosa
1d99a2d6be
Merge branch 'openseadragon:master' into master 2022-06-07 14:48:33 +02:00
pearcetm
af26fdbff1
Bugfix for imagetilesource _freeupCanvasMemory 2022-05-18 12:26:19 -04:00
Christophe Avenel
f1865c3878
Fix wrong center point on touch zoom
When doing pinch to zoom, we need to do pan first and then zoom, so that the center point is correct.
Otherwise, the pan will computed on the unzoomed coordinates, giving an impression of zooming toward the center
2022-05-12 10:45:47 +02:00
Ian Gilman
bfc4bc553a
Merge pull request #2155 from samwilson/typos
Fix duplicated word: "the the"
2022-05-10 13:51:05 -07:00
Aiosa
6e80e2d184
Merge branch 'openseadragon:master' into master 2022-05-06 16:52:24 +02:00
Ian Gilman
ad7f3449bb
Merge pull request #2153 from devbyjonah/deprecated_Alias
added warning for deprecated method buttons()
2022-05-05 14:02:06 -07:00
Sam Wilson
1700e2f060 Fix duplicated word: "the the"
From https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/789330
2022-05-05 20:43:38 +08:00
Jirka
8a2c998cb9 Finish on image job now accepts request argument. Further comments cleanup. Deprecation message for image property in tile loaded event. Removal of downloadTileFinish(). More robust aborting that cleans up an image properties when aborted (not done until now). 2022-05-04 15:16:13 +02:00
Aiosa
150e750ece
Merge branch 'openseadragon:master' into master 2022-05-04 13:40:06 +02:00
Ian Gilman
c0674b2924
Merge pull request #2152 from joedf/patch-1
fix typos for dragToPan in OpenSeadragon.Options
2022-05-03 14:40:48 -07:00
devbyjonah
5ed4d5f630 added warning for deprecated method buttons() 2022-05-02 19:14:39 -07:00
Ian Gilman
3aca527360
Merge pull request #2145 from tdiprima/patch-1
updated conditional expression
2022-05-02 14:33:57 -07:00
Jirka
d82fd35323 Fix comments on #2148: part 2. Better commens on the new TileSource API. Deprecation if 'tile-loaded' image event parameter. Unwrap ImageJob and add userData property. 2022-04-29 23:45:01 +02:00
Joe DF
eaa1a93755
fix typos for dragToPan in OpenSeadragon.Options
I noticed "`gestureSettings`[Mouse]" was 3 more times, where I believe they should be `Touch`, `Pen`, and `Unknown`?
2022-04-29 14:05:24 -04:00
Jirka
45a7a4aaf3 Fix comments on #2148: hasTransparency as a property. Move '.image' tile property to be a getter instead. Rename 'ImageJob' data property from 'image' to 'data'. Repair comments related to #2148. 2022-04-29 18:41:43 +02:00
jonasengelmann
62e24ac1ab ensure constructor backward compatibility 2022-04-19 16:43:00 +02:00
Jirka
4f79f29238 Move cache creation, image downloading process and transparency deduction to the TileSource instance to allow custom data fetching, caching, processing. 2022-04-16 21:19:54 +02:00
Jirka
b2eda881e8 Another problem with release handler: a point instace could be undefined. 2022-04-16 16:53:30 +02:00
Ian Gilman
334e8fbc67
Merge pull request #2142 from Aiosa/master
Delegate error printing to the ajax caller.
2022-04-15 14:12:39 -07:00
Jirka
ec430779f4 Move open-failed error message to the handler, adjust test for the new message style. Add 'numberOfHandlers()' method for events. 2022-04-15 10:32:08 +02:00
Ian Gilman
d8a8eff21a
Merge pull request #2138 from Aiosa/cache-key
Change Tile.cacheKey strategy
2022-04-14 15:00:35 -07:00
Tammy DiPrima
e1b651b66c
update expression
Code fails if element.style is undefined.
2022-04-13 13:33:44 -04:00