mirror/openseadragon
1
0
Fork 0
mirror of https://github.com/openseadragon/openseadragon.git synced 2024-11-26 23:26:10 +03:00
Code Issues Projects Releases Wiki Activity
1,039 Commits 12 Branches 28 Tags 35 MiB
d9dfd0a435
Commit Graph

630 Commits

Author SHA1 Message Date
Antoine Vandecreme
7375ba9241 Fix scrolling when exiting full-screen mode. 
Rename fullpage event to full-page and it's fullpage property to fullPage.
Add pre-full-page event.
 2013-10-31 22:19:22 -04:00
Antoine Vandecreme
3f5db8f8de Fix mousestop event on IE 2013-10-31 16:16:08 -04:00
Mark Salsbery
bbedbd29cb Merged changes from master 2013-10-31 11:27:13 -07:00
Antoine Vandecreme
542d5f5aeb Remove cancelEvent + fix typos 2013-10-30 21:28:10 -04:00
Mark Salsbery
9e5dcd766f Punctuation fix 2013-10-30 13:35:39 -07:00
Mark Salsbery
cfd76a6fd9 Whitespace fix 2013-10-28 12:38:17 -07:00
Mark Salsbery
d6b187eb06 Fix for non-canvas tile rendering at large size 
In USE_CANVAS==false mode, wrapped tile img elements in div elements to
allow them to be rendered larger than their containing element without
being stretched.
 2013-10-28 12:36:29 -07:00
Mark Salsbery
0f8ac4cfab Added 'MozMousePixelScroll' event handling 
For older Firefox versions
 2013-10-24 13:39:00 -07:00
Mark Salsbery
755c4752c0 'wheel' Event Support Fixes 
Whitespace, cancel handling
 2013-10-23 13:55:52 -07:00
Mark Salsbery
e76c9e65ab Added 'wheel' Event Support 
Also improved OpenSeadragon.addEvent()/OpenSeadragon.removeEvent()
 2013-10-23 12:58:36 -07:00
Antoine Vandecreme
d4a4276bbc Fix margin bug with legacy fullscreen mode 2013-10-23 10:00:08 -04:00
Antoine Vandecreme
8debb26d61 Add mouse stop event 2013-10-22 16:54:04 -04:00
iangilman
c9f60fd468 Merge pull request #218 from gwills/master 
IE 10 not reading DZI file correctly
 2013-10-22 10:35:05 -07:00
iangilman
5d45054fee Merge pull request #257 from msalsbery/EventSource-Original-Events 
originalEvent Pass through to EventSource events (#227)
 2013-10-22 10:31:18 -07:00
gwills
3777b53507 Revert "Fix rotate on rectangular overalys" 
This reverts commit a70d082be3.
 2013-10-22 13:54:32 +01:00
Antoine Vandecreme
54d02ada78 Replace viewport.getImageZoomRatio by conversion methods between viewport zoom and image zoom 2013-10-18 15:16:49 -04:00
Mark Salsbery
984dd267b6 originalEvent Pass through to EventSource events 2013-10-15 11:11:08 -07:00
Antoine Vandecreme
f712e15793 Recenter the image after switching fullscreen mode. #62 and #170 2013-10-14 18:01:58 -04:00
gwills
a70d082be3 Fix rotate on rectangular overalys 
Use size after rotate when positioning the overlay.

Also removed check on this.scales - was there a reason these were not
handled when rotating? If so we can add a option here maybe.
 2013-10-14 10:59:20 +01:00
Antoine Vandecreme
4cd98a5da9 Check hash in viewer constructor. 
Fix #229
Fix #176
 2013-10-12 18:30:05 -04:00
iangilman
e006d0e05a Merge pull request #254 from msalsbery/Event-Handler-Signatures 
Event Handler Signatures Changed to 'fn(event)' (#251)
 2013-10-11 10:57:20 -07:00
Mark Salsbery
f9fb80b4d2 referencestrip.js spacing fix 2013-10-11 10:50:50 -07:00
Mark Salsbery
f5750bb9f6 referencestrip.js event handler cleanup 2013-10-11 10:44:03 -07:00
iangilman
e89562c03a Merge pull request #252 from Sharpbarb/master 
Add the ability to create a viewer and start at a specified page
 2013-10-11 09:57:28 -07:00
Mark Salsbery
d574700b3d Event Handler Signatures Changed to 'fn(event)' 
All event handler signatures changed to 'fn(event)'
eventSource property added to the event object passed
Redundant event source properties removed ('button' and 'viewer'
Documentation updated in MouseTracker
changelog.txt updated
 2013-10-10 17:00:15 -07:00
Sharpbarb
3078642927 Update viewer.js 
Moved call to _updateSequenceButtons inside if ( initialTileSource )
 2013-10-10 12:57:02 -07:00
Sharpbarb
4535f47e8d Update viewer.js 
trailing whitespace...
 2013-10-10 12:35:49 -07:00
Sharpbarb
6b90687ab4 Update viewer.js 
description; Move _updateSequenceButtons behind goToPage()
 2013-10-10 12:27:49 -07:00
Sharpbarb
a862870883 Update viewer.js 
Formatting; descriptions; rename sequenceButtons to _updateSequenceButtons
 2013-10-10 12:25:11 -07:00
Sharpbarb
7aac7ffd9c Update openseadragon.js 
Align initialPage value
 2013-10-10 12:05:05 -07:00
iangilman
9050a39387 Merge pull request #243 from avandecreme/master 
Add coordinates conversion methods to viewport.
 2013-10-10 10:38:09 -07:00
Sharpbarb
6f79f80fe0 Update viewer.js 
trailing white space....
 2013-10-09 15:36:21 -07:00
Sharpbarb
0f705d093a Update viewer.js 2013-10-09 15:31:33 -07:00
Sharpbarb
0d8d770327 Update viewer.js 2013-10-09 15:27:43 -07:00
Sharpbarb
81664251cc Update openseadragon.js 
Missing colon
 2013-10-09 15:22:36 -07:00
Sharpbarb
2f33e6c666 Update viewer.js 2013-10-08 21:45:26 -07:00
Sharpbarb
c6597806ba Update viewer.js 2013-10-08 17:10:26 -07:00
Sharpbarb
54bcd6ea79 Update viewer.js 
Remove the sequence control update and put it into its own function. This way it can be called after a tilesource is loaded.
 2013-10-08 17:07:49 -07:00
Sharpbarb
ec71a4416e Update viewer.js 2013-10-08 15:01:28 -07:00
Sharpbarb
fc972df52e Update openseadragon.js 2013-10-08 14:53:08 -07:00
iangilman
7d8fb803ef Merge pull request #244 from msalsbery/Pinch-Zoom-Fix 
Pinch zoom fix
 2013-10-08 10:23:10 -07:00
iangilman
45ee8236e3 Merge pull request #247 from jmnetus/master 
Check that zoom reference point is valid before using it
 2013-10-08 10:17:29 -07:00
Mark Salsbery
1c17ea8afa Merge branch 'master' into Pinch-Zoom-Fix 
Conflicts:
	changelog.txt
 2013-10-07 08:44:29 -07:00
Mark Salsbery
a9cf3f2904 Merge branch 'master' into Button-Event-Signatures 2013-10-07 08:38:08 -07:00
Jon Stroop
964e73b9a5 iiiftilesource now uses pixel-based syntax 'w,'. level 1 compliance it still required, so backward compatability should not be an issue 2013-10-05 15:02:26 -04:00
Antoine Vandecreme
3e5a9b52c9 Rollback basic.html and create coordinates.html. 
Fix unit tests.
Fix documentation.
 2013-10-05 10:21:12 -04:00
Jonathan Nielsen
c5ac5b6550 whitespace formatting change 2013-10-04 13:09:58 -06:00
Jonathan Nielsen
ae5acb6547 Add similar refPoint validity check to zoomBy 2013-10-04 13:06:25 -06:00
Jonathan Nielsen
fd85ee4f4e Check that zoom reference point is valid before using it 2013-10-04 10:12:47 -06:00
Mark Salsbery
dde06bf416 Merge branch 'master' into Button-Event-Signatures 2013-10-03 19:50:57 -07:00
Mark Salsbery
2f31395fc0 Merge remote-tracking branch 'origin/Touch-Bug-Fix' 2013-10-03 17:07:28 -07:00
iangilman
d88ce4a970 Merge pull request #242 from msalsbery/Touch-Bug-Fix 
Fix for touch event issue #240
 2013-10-03 16:30:15 -07:00
Mark Salsbery
d55b2e7703 Pinch zoom fix 
The existing code failed on iPhone Safari iOS 6.x - event.detail was
always 0 causing only zoom out behavior.
 2013-10-03 15:30:40 -07:00
Antoine Vandecreme
791ecfae75 Add coordinates conversion methods to viewport. 2013-10-03 17:27:11 -04:00
Mark Salsbery
9928a6d925 Fix for touch event issue #240 2013-10-03 12:11:33 -07:00
Mark Salsbery
76733c4ca2 Button event signatures fixed for consistency 
Button event signatures now "handlerMethod(eventSource, eventData)"
where eventData == { button }
 2013-10-03 09:29:20 -07:00
Mark Salsbery
5c37a1f375 Ready event signature fixed for consistency 
Signature now handlerMethod(eventSource, eventData)
 2013-10-02 13:09:40 -07:00
Mark Salsbery
d8fc7d10f9 Merge branch 'master' into Event-Names-Normalize 2013-10-01 15:12:00 -07:00
Jon Stroop
e4bd874b03 added test for 1.1; renamed 11 to 1_1 2013-10-01 15:07:44 -07:00
Jon Stroop
1a52656ed6 supports IIIF 1.1 syntax 2013-10-01 15:07:43 -07:00
Jon Stroop
890ec0c848 fixed size param 2013-10-01 15:07:42 -07:00
Jon Stroop
bccbf5ecf1 configureFromObject uses @id 2013-10-01 15:07:42 -07:00
Jon Stroop
e3c1007ae2 use pixels for size instead of pct 2013-10-01 15:07:41 -07:00
Jon Stroop
434807a660 added support for iiif 1.1 2013-10-01 15:07:41 -07:00
Mark Salsbery
ec3141a778 Event Names Normalized 
Compound event names lower case with hyphen.
Button event names removed "on" and made lower case.
 2013-09-30 10:22:06 -07:00
Mark Salsbery
c0a16dacc4 eventsource.js comment fix 2013-09-26 10:23:00 -07:00
Mark Salsbery
bf0608b4b2 string.js quotes/whitespace fix 2013-09-26 10:16:10 -07:00
Mark Salsbery
041597998f Event Names Normalized 
All event names lower case with no hyphens
 2013-09-26 09:50:26 -07:00
iangilman
21aa2dc928 Merge pull request #228 from msalsbery/EventHandler-Rename 
Renamed EventHandler to EventSource (#225)
 2013-09-25 09:04:04 -07:00
gwills
f8a0315757 Small formatting change 
Needed to change spacing to pass through jshint
 2013-09-24 21:54:54 +01:00
gwills
8f2999da29 Use $.parseXml for parsing string as XML 2013-09-24 21:49:54 +01:00
Mark Salsbery
dab182757d Renamed EventHandler to EventSource (#225) 2013-09-24 13:36:13 -07:00
Ian Gilman
6396fe1504 Merge branch 'Original-Events-In-Handlers' of github.com:msalsbery/openseadragon into msalsbery-Original-Events-In-Handlers 
Fixed Conflicts:
	changelog.txt
 2013-09-24 10:28:46 -07:00
Mark Salsbery
c27481546a MouseTracker Original Events in Handlers 
Whitespace fixes on un-empty [] brackets
 2013-09-20 09:58:18 -07:00
Mark Salsbery
56ef12e850 Original Events in Handlers 
Documentation fixes
isTouchEvent property removed from eventData where not used
'eventOrTouchPoint' var name used and 'originalEvent' var name restored
to 'event'
 2013-09-12 10:05:50 -07:00
Nelson Hart
6d6cc363b4 Use style attributes when storing the previous elment size instead of the literal size of the element #220 2013-09-12 10:41:51 -03:00
Mark Salsbery
af078f8f19 MouseTracker Original Events in Handlers 
Renamed insideElementRelease to insideElementReleased.
 2013-09-10 17:31:51 -07:00
Mark Salsbery
1dc2d7e011 MouseTracker Original Events in Handlers 
Touch events bug fix. Now uses touch object(s) properly when calculating
positions.
 2013-09-10 17:23:19 -07:00
Mark Salsbery
13415b36f3 MouseTracker Original Events in Handlers 
Misc name changes, indentation/whitespace fixes.
Still TODO: Fix documentation, evaluate presence of key handler in a
mouse tracker, evaluate whether isTouchEvent flag should be in all
eventData objects or not.
 2013-09-09 14:27:58 -07:00
gwills
2bef2e882f IE 10 not reading DZI file correctly 
IE 10 is treating the data coming back from the JSONP request as a
string and not as XML. I have confirmed this issue is happening on
numerous IE10 machines but have not seen it on any other browser.

The change simply checks the type of the data variable and if it is a
string it parses the string as XML and updates the data object.
 2013-09-07 17:08:39 +01:00
Mark Salsbery
d60224b615 MouseTracker Original Events in Handlers 
Pass original touch events to handlers.
 2013-09-06 13:12:11 -07:00
Mark Salsbery
2e1f71a824 MouseTracker Original Events in Handlers 
Bug fixes.  Event handler methods shouldn't be called directly in
theory...
 2013-09-06 12:24:19 -07:00
Mark Salsbery
8229a9aba5 MouseTracker Original Events in Handlers 
More formatting fixes
 2013-09-06 11:20:14 -07:00
Mark Salsbery
5f6b89b8b5 MouseTracker Original Events in Handlers 
More formatting fixes
 2013-09-06 11:10:05 -07:00
Mark Salsbery
56f5b9fb74 MouseTracker Original Events in handlers 
Comment & Formatting fixes
 2013-09-06 10:43:39 -07:00
Mark Salsbery
b3fa8f1184 MouseTracker original events in handlers 
Implemented "Expose original event in handlers" (#23) for MouseTracker

Added OpenSeadragon.getElementOffset() method. Element-relative mouse
coordinates should be correct even if the element and/or page is
scrolled (#131)
 2013-09-05 17:20:17 -07:00
Ian Gilman
75ddd299e4 Changed Seajax to OpenSeadragon 2013-09-05 16:26:00 -07:00
Antoine Vandecreme
63af5a69ac Add comments and fix indentation 2013-09-04 14:13:25 -04:00
Antoine Vandecreme
bfa76e471b Add viewportToImageRectangle method and add support to pass a point to viewportToImageCoordinates and imageToViewportCoordinates 2013-08-30 13:59:48 -04:00
iangilman
b2ecdcdc2a Merge pull request #208 from acdha/ie8-ajax-error-handler-fix 
Fix AJAX error reporting on IE8
 2013-08-30 09:52:11 -07:00
Chris Adams
baa3559df1 Graceful handling of cross-domain tilesource failures on IE<10 
The TileSource error handling path used to raise non-obvious
"Unspecified error" exceptions on IE < 10 when configured with a URL
from a different origin (hostname or port) because the handler included
``xhr.status`` in the error message, triggering a security exception.

Now the second exception is caught and the log message will use the
original exception message instead to make the root cause more obvious.
 2013-08-30 12:32:17 -04:00
Chris Adams
1b6cf93474 Graceful handling of IE cross-domain AJAX failures 
Prior to IE 10, XmlHttpRequest cannot be used for requests to a
different origin even when the target URL's CORS headers would allow
access (see http://caniuse.com/#feat=cors).

This is easy to miss in testing if you use a single origin during
testing but have a CDN or domain-sharding for production and will break
the error handler function passed to makeAjaxRequest() if that code
assumes it can access properties on the request object.

This adds a more informative pointer to Microsoft's documentation when a
security exception is raised.
 2013-08-29 16:13:18 -04:00
Mark Salsbery
c7f184f199 Reverted breaking change for issue #201 
To be grouped with other breaking changes for major version release.
Also, minor formatting fix in src/eventhandler.js
 2013-08-27 10:10:55 -07:00
Mark Salsbery
57ae0656c1 Fixes for issues #198, #201, #202, #203 2013-08-26 16:48:59 -07:00
Mark Salsbery
f8ab315795 Revert "Bad sync" 
This reverts commit 70a7e8090e13cc35b93e652d2bcd7f418af26fc1.
 2013-08-26 15:48:03 -07:00
Mark Salsbery
04a0197dc7 Fixes for issues #198, #201, #202, and #203 2013-08-26 15:25:57 -07:00
iangilman
aefe7f3610 Merge pull request #185 from robhobbes/master 
Adding partial support for rotation.
 2013-08-20 11:08:58 -07:00
Robert Hickman
d4467477ad More rotation documentation. 2013-08-19 16:29:22 -06:00
Ian Gilman
4b0450d271 Documented "current" param to a number of viewport functions 2013-08-19 10:14:04 -07:00
iangilman
d2353746c9 Merge pull request #179 from lukemurray/destroy 
Add a destroy function on the viewer to clean up and remove elements
 2013-08-19 10:03:12 -07:00
iangilman
dde052a22a Merge pull request #188 from iangilman/touch 
Ignoring touchMove if we didn't get the touchStart
 2013-08-19 09:57:36 -07:00
iangilman
e955c402ac Merge pull request #187 from iangilman/rtl 
Drawer now works when the page is rtl
 2013-08-19 09:55:04 -07:00
Robert Hickman
767c897e7f Revisions to rotate after second code review. 2013-08-16 11:32:21 -06:00
Ian Gilman
96c14f7617 Ignoring touchMove if we didn't get the touchStart 2013-08-16 10:09:49 -07:00
Robert Hickman
54e8d8c43f Fixes made after first code review of rotation. 2013-08-15 16:15:20 -06:00
Ian Gilman
6669589e5e Drawer now works when the page is rtl 2013-08-15 12:54:32 -07:00
Robert Hickman
6c63710131 Rotating overlays. 2013-08-14 13:43:49 -06:00
Ian Gilman
adbf35e002 Merge branch 'master' into form 2013-08-14 10:41:32 -07:00
Ian Gilman
3272572124 Clicking on a button control no longer refreshes page 2013-08-14 10:39:39 -07:00
Robert Hickman
b9583c43ac Working on rotating images. 
So far only 90 degree rotation is supported.
Only the image is currently being rotated.
Overlays, debugger, and the navigator still need to be updated to support rotation.
 2013-08-13 16:32:04 -06:00
Luke Murray
ab82783cf1 update the comments and unit test 2013-08-13 10:33:12 +10:00
Luke Murray
0c662b8a8d fix: comment updates and add a simple test for viewer.destroy 2013-08-12 16:38:37 +10:00
Luke Murray
68f9d675fc fix: calling viewer.destroy() multiple times throw an error. And a simple destroy to mousetracker 2013-08-08 17:49:24 +10:00
thatcher
88141c57f2 feature: navigatorPosition, option was available but not completely implemented 2013-08-08 00:12:44 -04:00
Luke Murray
4ccb141a42 Add a destroy function on the viewer to clean up and remove elements 
created by open seadragon. Add removeAllHandlersForAllEvents to clean up all events on destroy. Clear
the onDraw callback on Overlay destroy.
 2013-08-07 10:54:20 +10:00
Ian Gilman
967f2e4f32 Changelog for #177; minor doc tweaks 2013-08-02 09:40:55 -07:00
iangilman
51e37e3553 Merge pull request #177 from pnorcross/_getSafeElemSize 
(hopefully) Final fix for issue #109, Viewport Broken on Hide.
 2013-08-02 09:36:06 -07:00
pnorcrss
26938ed10e cleaned up docBlock and tabs in _getSafeElemWidth() 2013-08-01 12:11:33 -05:00
iangilman
f53ea2ddf1 Merge pull request #160 from lukemurray/custom_zoom_handler 
Add the option for a zoom handler callback
 2013-08-01 09:52:11 -07:00
Luke Murray
2717398181 Use the correct onDraw in drawer.js. Remove imageFullSize and fix up the comment for onDraw 2013-08-01 13:36:00 +10:00
pnorcrss
e47210d0bd refactored _getSafeElemSize() 2013-07-31 14:10:44 -05:00
pnorcrss
cb39fb7e32 fixed _getSafeElemSize() 2013-07-31 14:01:46 -05:00
pnorcrss
bf3dd7c031 fixed _getSafeElemSize() calls 2013-07-31 13:28:38 -05:00
pnorcrss
750eafcd2e added and implemented _getSafeElemSize() 2013-07-31 13:00:16 -05:00
iangilman
0aa0641cf4 Merge pull request #168 from ethanli83/fixtouch 
canvas pans when tap on touch screen
 2013-07-31 10:25:19 -07:00
Luke Murray
4239bb7adc fix: remove the useTransform/SVG stuff and move back to a simple onDraw callback only so people can handle their own custom drawing and sizing 2013-07-31 17:01:48 +10:00
Luke Murray
0a8d11875e Merge branch 'master' into custom_zoom_handler 2013-07-31 16:39:54 +10:00
ethan.li
0bb9c5be97 issue: 
canvas pans when tap on touch screen

reason:
    onTouchStart calls onMouseDown which registers 'mousemove' event handler.
    when I tap on touch screen, even though browser did not dispatch 'touchmove' event, it dispatched 'mousemove' event.
    therefore, the 'mousemove' handler pans canvas.

fix:
    stop onTouchStart handler registering 'mousemove' handler as onMouseMove will be properly triggered by onTouchMove
 2013-07-23 16:40:04 +10:00
Luke Murray
df877493a9 Rename drawHandler to onDraw. Also make it a notification style callback 
(does not override the draw functionality).
Add an overlay option 'useTransform' that will transform the overlay
element instead of moving it's postion - useful for SVG elements
 2013-07-16 12:04:37 +10:00
iangilman
77cf2a3b88 Merge pull request #159 from ethanli83/master 
Fix for onTouchEnd
 2013-07-12 09:01:31 -07:00
Luke Murray
233c3a357a Add the option for a zoom handler callback 2013-07-12 16:51:56 +10:00
ethan.li
0ef98be0b7 for fix I made to onTouchEnd: 
1. remove IE8 related code as it does not support touch anyway
2. use event.changedTouches [ 0 ] rather than event
 2013-07-12 10:29:44 +10:00
Ian Gilman
7391561dcd OpenSeadragon.now() returned undefined the first time; fixed 2013-07-10 09:31:22 -07:00
ethan.li
8108009ba7 fix issue: 
onTouchEnd did not call the correct mouse up handler
 2013-07-09 11:07:18 +10:00
iangilman
850aa14802 Merge pull request #151 from acdha/overhauled-ajax-error-reporting 
Overhauled AJAX error reporting
 2013-07-03 09:56:07 -07:00
radix-pro
004f13365d Update iiiftilesource.js 2013-07-02 13:41:37 -07:00
radix-pro
3c7e4b794a Update iiiftilesource.js 2013-07-02 00:41:22 -07:00
radix-pro
8f8e028015 Update iiiftilesource.js 2013-07-02 00:34:23 -07:00
radix-pro
acd55c709d Update iiiftilesource.js 2013-07-02 00:27:53 -07:00
radix-pro
040ff3a7ae Update iiiftilesource.js 2013-07-02 00:18:37 -07:00
radix-pro
a4303fb232 Update iiiftilesource.js 2013-07-02 00:02:48 -07:00
radix-pro
0441cfe4ec Update iiiftilesource.js 2013-07-01 23:55:07 -07:00
radix-pro
44a9d1b98b Update iiiftilesource.js 2013-07-01 23:49:25 -07:00
radix-pro
dde42b641d Update iiiftilesource.js 
Fix Issue #55 "Tiles rendering issue..."
 2013-07-01 22:38:37 -07:00
Chris Adams
0ed4703bd3 Viewport messages: add a class to the dialog for easy styling 2013-07-01 18:26:44 -04:00
Chris Adams
1ab6094420 Viewer: make viewport messages private, repeatable 
* Marked _showMessage/_hideMessage as private
* Fix DOM manipulation bug: call standard removeNode() method rather
  than proprietary WebKit .remove()
* Change messageDiv to be the outer wrapper to simplify removing the
  entire message container
 2013-07-01 13:43:48 -04:00
Chris Adams
b912896158 Viewer.showMessage() hides any previous message 2013-07-01 12:58:22 -04:00
Chris Adams
9de45ba281 Refactor OpenSeadragon.makeCenteredNode 
* Use CSS display tables for vertical centering (tested back to IE8)
* Use the DOM instead of string concatenation
* Remove redundant styles ($.makeNeutralElement sets the same values
  for margin, padding & border)
* Return the outer wrapper element to ease DOM addition & removal
 2013-06-28 15:52:48 -04:00
Chris Adams
1f345e4cc5 Viewer: refactor message code into showMessage/hideMessage methods 
This avoids the need to deal with classes, and explicitly makes it
reusable for other needs
 2013-06-28 15:46:31 -04:00
Chris Adams
7f42dfc032 code style 2013-06-28 15:01:56 -04:00
Chris Adams
fb7c91acd2 code style 2013-06-28 14:54:44 -04:00
Chris Adams
7dcf662fdd Viewer: add a basic error message display system 
This might be something we want to make configurable for users who want
to completely control how errors are displayed.

This also adds the first use of OpenSeadragon.makeCenteredNode currently
so we might want to clean up that code as well.
 2013-06-28 14:32:57 -04:00
Chris Adams
2bf6b13bfe User-visible warning when tile sources fail to load 
This is currently using window.alert in lieu of something more sophisticated but it works for indicating 404s or invalid file
contents
 2013-06-28 14:11:20 -04:00
Chris Adams
494bf7fe41 strings: add logging for untranslated source messages 
This should probably be changed to be closer to the goal of being
like gettext but we can at least tell developers when we clobber the
string
 2013-06-28 14:11:19 -04:00
Chris Adams
464428cef7 makeAjaxRequest: don't set request to null 
Setting onreadystatechange can avoid the possibility of it somehow being
called twice but there's no point in nulling the request right before we
let the GC collect it.
 2013-06-28 14:00:02 -04:00
Chris Adams
db38b71dd9 makeAjaxRequest: throw error for missing callback 2013-06-27 16:03:43 -04:00
Chris Adams
1c6a57c710 makeAjaxRequest: log all errors, test callback 
* All AJAX errors will log to the console
* The onError callback will only be called if defined
 2013-06-27 16:03:41 -04:00
Chris Adams
5eccdfee98 Better match project style 2013-06-27 15:58:09 -04:00
Chris Adams
496b7d757b Simplify OpenSeadragon.makeAjaxRequest 
* Since async is always true – and browsers are starting to deprecate
  synchronous XHR – we were able to prune considerable amount of code
* Add an error callback to match the existing success callback
 2013-06-27 15:58:09 -04:00
iangilman
8fe0ce26b8 Merge pull request #136 from acdha/jshint-cleanup 
JSHint tidying
 2013-06-26 09:37:08 -07:00
iangilman
f4139cef38 Merge pull request #144 from acdha/143-xhr-error-handling 
Safe cleanup in makeAjaxRequest error handler
 2013-06-26 09:23:04 -07:00
Ian Gilman
3f1072b321 Fixed typos in comments 2013-06-26 09:15:37 -07:00
Chris Adams
c648c1df8a drawer: don't leak drawLevel into global namespace 
This code is still under-tested and documented but no longer relies on
`drawLevel` being leaked into the global namespace where `updateLevel`
to find it.

See #145
 2013-06-25 14:26:09 -04:00
Chris Adams
f2cba16a8b Safe cleanup in makeAjaxRequest error handler 
Previously `request.onreadystatechange` was assigned an empty function
on success but null on failures, which breaks in IE (see
http://jsbin.com/ezozax/6/).

This patch simply mimics the success behaviour in the cleanup function

Closes #143
 2013-06-25 14:13:45 -04:00
Benjamin 'blindCoder' Schieder
0150622e78 fix error when recalculating overlay width and height 2013-06-25 18:01:38 +02:00
Chris Adams
c2107fcb22 Declare _processDZIError directly on OpenSeadragon 2013-06-21 16:37:31 -04:00
Kevin Ewing
8896c2278d Fixed mistake 2013-06-20 13:31:04 -07:00
Kevin Ewing
2ba3acda38 Removed extra parens 2013-06-20 13:23:16 -07:00
Kevin Ewing
248852c15f Implementing OpenSeadragon.now() 
Replacing both `+new Date()` and `new Date().getTime()` with `$.now()`
 2013-06-20 13:15:04 -07:00
Chris Adams
9ef6e085c8 viewer.js: update onfullscreenchange handler comment 2013-06-20 15:17:48 -04:00
Chris Adams
de29a34890 viewer.js: remove dead code 2013-06-20 15:12:55 -04:00
Chris Adams
adc4147304 Expose semi-private processDZIError for use by DziTileSource 
This previously wasn't in scope outside of the main OpenSeadragon
closure. Now it's exposed with an underscore prefix to encourage people
not to think of it as a public interface.
 2013-06-20 15:12:54 -04:00
Chris Adams
51bb8ca46e openseadragon.js: fix imageFormatSupported refs 2013-06-20 15:12:54 -04:00
Chris Adams
169244ed1a navigator.js: omit unused borderWidth from func args 2013-06-20 15:12:54 -04:00
Chris Adams
0d09183159 referencestrip.js: move variable declaration to the top of loadPanels 2013-06-20 15:12:54 -04:00
Chris Adams
eafc822aa8 openseadragon.js: remove unused builtin aliases 2013-06-20 15:12:54 -04:00
Chris Adams
8c433ba81c Declare assumed globals 2013-06-20 15:12:54 -04:00
Chris Adams
e2bea810e3 Replace gnarly ternary expression with if statement 2013-06-20 15:12:53 -04:00
Chris Adams
64d94ac2bd referencestrip.js: declare undeclared variable 2013-06-20 15:12:53 -04:00
Chris Adams
f8c77f65d7 viewer.js: fix typos in variable declarations 2013-06-20 15:12:53 -04:00
Chris Adams
d644acd50b Fix lack of braces on if statements 
JavaScript's most popular rack in the grass for maintenance coders…
 2013-06-20 15:12:53 -04:00
Chris Adams
643ee211ca Remove unused variables 
Mostly unused function arguments but there were also a fair number
of legacy names which are now no longer used.

One question which comes up – mostly in tilesource.js – is whether
there is any value in leaving unused variables for functions which
are intended to be overridden anyway. I'm inclined to say that the
docs + tests need to be sufficient as there's no enforcement that
whatever is in the base implementation will actually be followed by
any of the real functions.
 2013-06-20 15:12:53 -04:00
iangilman
6e9a300d1a Merge pull request #133 from iangilman/raf 
Improved requestAnimationFrame polyfill; fixed timer leaks; added tests
 2013-06-20 09:52:10 -07:00
Kevin Ewing
0984106983 Added missing semicolon 2013-06-20 09:08:21 -07:00
Kevin Ewing
2f8a26fda0 Responding to feedback 
Function now re-assigns itself on the first go round to avoid doing the
check every time it is called
 2013-06-19 15:13:56 -07:00
Ian Gilman
e0282a3c86 Stripped whitespace 2013-06-19 13:33:01 -07:00
Kevin Ewing
ebffea5a34 Merge branch 'master' into now 2013-06-19 11:23:42 -07:00
Ian Gilman
8e88f36098 Merge branch 'master' into raf 
Fixed Conflicts:
	src/viewer.js
 2013-06-19 11:19:54 -07:00
Kevin Ewing
e8408c1313 Moved to better location 2013-06-19 11:16:45 -07:00
Kevin Ewing
6a3b7cfb2f Added OpenSeadragon.now() 2013-06-19 10:57:09 -07:00
Chris Adams
9f6f164d9f Remove all whitespace 
The results of running this command::

    find . -name \*.js -print0 | xargs -0 perl -p -i -e "s|[ \t]+$||"

(Split from #136)
 2013-06-19 13:33:27 -04:00
Ian Gilman
beadcdcc89 Merge branch 'master' into raf 2013-06-19 10:15:53 -07:00
iangilman
c14467afa4 Merge pull request #135 from robhobbes/master 
Only disable the previous button if the navPrevNextWrap option is not set
 2013-06-19 10:12:38 -07:00
Ian Gilman
4022206261 Removed the parens around new Date call, for consistency 2013-06-19 10:03:44 -07:00
Ian Gilman
2e48239056 Addressing code review comments 2013-06-19 09:58:22 -07:00
Ian Gilman
dbc8a59ae8 Cleaned out dead code in scheduleUpdate and updateMulti 
… as pointed out by @ventero
 2013-06-19 09:58:09 -07:00
Robert Hickman
ade93ffc5e Only disable the previous button if the navPrevNextWrap option is not set. 2013-06-18 15:19:09 -06:00
Ian Gilman
713fad4224 Exposing _updateRequestId as a semi-private member for testing purposes 2013-06-18 11:06:43 -07:00
Ian Gilman
e99c126a85 Navigator now updates properly when reopening a viewer 
Before, if you closed a viewer and then opened a new tilesource into
it, the navigator would still have the old tilesource. This patch fixes
that.
 2013-06-17 11:51:02 -07:00
Ian Gilman
c6a38dd802 Now closing the navigator when the viewer closes 
At the very least this was causing the navigator to continue to request
and process frames even after its viewer had been closed.
 2013-06-17 11:31:41 -07:00