Commit Graph

1190 Commits

Author SHA1 Message Date
thatcher
acfd3d0280 removed more psuedo-private methods and properties in favor of direct accessors or closure private methods. moved raiseEvent to EventHandler interface 2011-12-16 18:29:16 -05:00
thatcher
1395157adf removed this._button from Button and renamed it to this.element since thats what this.get_element returned. may eventually move to a more jquery like pattern of extending the element with the methods of Button. 2011-12-16 17:56:38 -05:00
thatcher
661eb225f9 should have incremented patch build number 2011-12-14 23:39:49 -05:00
thatcher
7d4ffaa769 refactored EventHandlerList to just EventHandler and am prefering a mix-in on the prototype to avoid excess indirection via psuedo-private properties. 2011-12-14 18:22:02 -05:00
thatcher
01153bcb91 remove add_foo remove_foo methods in favor of adding them directly via this._events.addHandler etc. made some notes on how to replace this._events in general by mixing-in EventHandlerList to the object prototype so this.addHandler can be used directly. 2011-12-14 17:54:42 -05:00
thatcher
d7de748434 removed initialize anti-pattern in favor of using constructor. combined Button constructor arguments into idiomatic single options object 2011-12-14 17:40:22 -05:00
thatcher
7f7589e939 minor refactor of mousetracker.js 2011-12-13 20:04:38 -05:00
thatcher
f482c0fb56 removed psuedo-privacy anti-patterns from job.js in favor of simple pinning and public properties. 2011-12-13 19:10:27 -05:00
thatcher
de14271399 removed psuedo-privacy anti-patterns from imageloader.js in favor of simple pinning and public properties. 2011-12-13 18:51:35 -05:00
thatcher
c7706ba66c removed initialize anti-pattern from dzitilesource constructor. 2011-12-13 18:34:12 -05:00
thatcher
a7050af619 removed super class prototype extension patterns from DziTileSource in favor of more concise $.extend 2011-12-13 18:29:25 -05:00
thatcher
f1882259e2 removed _DziTileSourceHelper anti-pattern in favor of direct object literal containing helper methods 2011-12-13 18:24:04 -05:00
thatcher
9642ca18e7 removed DziError from codebase. It provided no functionality not inherent in the javascript built-in Error. 2011-12-13 18:17:46 -05:00
thatcher
ced59b9827 removed empty dzi.js from src directory 2011-12-13 18:06:06 -05:00
thatcher
9b5cf799bf removed _init anti-pattern from drawer constructor 2011-12-13 18:01:43 -05:00
thatcher
c35ee2bca9 moved only relevant object literal from controlanchor.js into control.js, deleted controlanchor.js and removed it from the build 2011-12-13 17:57:40 -05:00
thatcher
c9034f3f96 removed now empty config.js from the build 2011-12-13 17:49:59 -05:00
thatcher
dc29100f67 removed identity assignment, strange. 2011-12-13 17:43:29 -05:00
thatcher
d702810ae7 removed overlayplacement.js from the build 2011-12-13 17:40:52 -05:00
thatcher
97d2f0c765 removed overlayplacement.js and moved it's only relevant object literal directly into overlay.js 2011-12-13 17:38:36 -05:00
thatcher
7cac08a2f4 found local variable navControl that should have been a property of Viewer. removed getNavControl accessor in favor of direct property access 2011-12-13 07:24:34 -05:00
thatcher
3e39bccbbe simplified beforeOpen, open, close in Viewer 2011-12-12 22:40:02 -05:00
thatcher
3c31094514 removing all get_x set_x patterns from constructor. just access (ie get/set) the property directly. 2011-12-12 17:45:43 -05:00
thatcher
760d89a1b1 found reference to this._innerTracker so made actually put innerTrack as Viewer property in constructor. it was just a local variable. made _innerTracker use innerTrack since it isnt really private. 2011-12-12 17:40:49 -05:00
thatcher
d4740545c5 moved examples folder to gh-pages branch. fixed some refactor bugs that affected fullpage toggle. added copy to folder spcific in build.properties as WWW so the distributable openseadragon.js can be copied to gh-pages branch running locally. unearthed the ability to make controls fade (which apparently they were supposed to do by default) 2011-12-12 17:22:01 -05:00
thatcher
5dd00910f8 this is a weird one, enjoy... duplicate method and implementations 2011-12-07 21:41:07 -05:00
thatcher
1726a878c1 moving many psuedo private methods to actual closure private methods. moving many psuedo private properties and public accessors to simple public properties. see changeset for details. 2011-12-07 21:10:13 -05:00
thatcher
193ed95435 modified Viewer constructor to accept idiomatic options argument while still supporting backward compatible positional args. documented positional args and options arg. Remove Config function allowing all configuration to occur via Viewer options (which is the only place Config was called directly). removed several pointless get_x set_x function in place of direct property access. 2011-12-06 20:26:06 -05:00
thatcher
e830ec6567 cleaning up button group internal api. use options object to configure and avoid private methods and using the OpenSeaDragon delegate pattern where possible. 2011-12-06 14:48:20 -05:00
thatcher
531f73356b changed default image path to correspond to shorter /images instead of /Scripts/images 2011-12-06 07:46:16 -05:00
thatcher
38a89c451b removed OpenSeadragon.format because it was only called once in the entire codebase, and didnt actually format a string. Instead just be direct and return string. corrected treatment of prefixUrl at that location since it was ignored otherwise. 2011-12-06 07:41:43 -05:00
thatcher
b871f6c2bf removed global variable SIGNAL. moved it into OpenSeadragon namespace 2011-12-06 07:21:30 -05:00
thatcher
916ada5f02 Added simple ant build. Broke main file into composite parts in src directory. Concatenated release is still included in the project as a release artifact. 2011-12-05 22:50:25 -05:00
thatcher
deaabc6a91 modified local functions delegate and EventHandlerList to be static namespace functions on OpenSeadragon namespace 2011-12-05 17:38:25 -05:00
thatcher
95cd02ac40 removed notes in preparation for new build 2011-12-05 17:01:13 -05:00
thatcher
e21026d892 adding images for controls 2011-12-04 18:35:53 -05:00
thatcher
e1bbab01ef adding licenses directory and new bsd text to comply with new bsd requirement 2011-12-04 18:26:04 -05:00
thatcher
3d243330a2 adding an example to demonstrate we havent broken core functionality. 2011-12-04 17:51:51 -05:00
thatcher
f73e52a02a inital sweep includes notes for further refactoring 2011-12-04 16:04:59 -05:00
thatcher
6e4dbd19cf initial commit 2011-12-01 15:26:17 -05:00