1
0
mirror of synced 2025-02-03 13:59:27 +03:00

89 Commits

Author SHA1 Message Date
Mikhail Shamin
bf322b903d Optimize imports. Remove full qualified class names 2016-05-11 01:55:12 +07:00
Jeroen Thora
6dcb97a20e Fixed many small phpcs issues 2015-12-11 20:30:41 +01:00
Guilherme Blanco
843966ac50 General fixes across CS, type resolving, test fixes, etc 2015-11-07 03:55:05 +00:00
Issei.M
df461601f7 removed useless line breaks 2015-09-03 17:55:14 +09:00
Javier Spagnoletti
cedff7715e [Paginator] Fixed boolean casting in Paginator
| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |
2015-07-14 16:48:42 -03:00
Kévin Dunglas
abf6b8bee5 minor: Code quality in Paginator 2015-07-07 10:09:06 +02:00
Filip Procházka
e501137d1a LimitSubqueryOutputWalker: fix aliasing of property in OrderBy from MappedSuperclass 2015-04-09 01:43:05 +02:00
David Prévot
b7cf41ca45 Drop useless execution bit 2015-04-01 16:01:22 -04:00
Marco Pivetta
ba00fc1e90 #1353 #1347 #1351 - s/inSubselect/inSubSelect (with docblock documentation) 2015-03-31 21:51:56 +01:00
Marco Pivetta
6c5dbd8d4c #1353 #1347 #1351 - Removing double quotes (confusing) 2015-03-31 21:50:08 +01:00
Bill Schaller
5c93e61686 Fix issue in LimitSubqueryOutputWalker with entities having field names different from column names 2015-03-31 21:39:21 +01:00
Bill Schaller
608dfa2f57 Add more detection in LimitSubqueryWalker for conditions that must be handled by LimitSubqueryOutputWalker 2015-03-31 21:39:20 +01:00
Bill Schaller
b76107e20f resolve review comments from @stof 2015-03-31 21:39:20 +01:00
Bill Schaller
edcc0fc024 Fix paginator when ordering by while selecting entities using joined table inheritance 2015-03-31 21:39:20 +01:00
Bill Schaller
09d28819b5 Fix issue where paginating on a query with a subquery in the where clause crashed 2015-03-31 21:38:58 +01:00
Bill Schaller
a8342a4be2 Cleanup 2015-03-31 21:36:33 +01:00
Bill Schaller
ff75a3ad49 Fix paginator issues when ordering by a joined column from a to-many association.
Manual merge testcase from #1351
2015-03-31 21:36:32 +01:00
Bill Schaller
54d7efd92c Fix LimitSubqueryOutputWalker when used on tables with joined table inheritance 2015-03-31 21:32:28 +01:00
Marco Pivetta
d97d3ec0e5 Minor CS fixes (braces) 2015-03-24 00:37:17 +00:00
Marco Pivetta
45d39dd50d Making preserveSqlOrdering API private 2015-03-24 00:36:13 +00:00
Bill Schaller
4c84f54493 Fix failures on SQL Server due to scalar select items not having an alias 2015-03-19 17:09:47 -04:00
Bill Schaller
5c4b6a2140 resolve nitpicks from @Ocramius and @deeky666 2015-03-17 18:44:03 -04:00
Bill Schaller
d710555265 Remove shameful hack in LimitSubqueryOutputWalker - replace with significantly less shameful hack 2015-03-17 18:32:57 -04:00
Bill Schaller
df0875c596 Fix Paginator OrderBy clauses when ordering by columns from non-fetched joined tables 2015-03-17 17:32:28 -04:00
Bill Schaller
eebce88146 Revert "Revert "Merge branch 'hotfix/#1220-sort-paginator-subquery-output-only-once'""
This reverts commit 6a1755972d19af4c1c07bc9c555d456d66426bda.
2015-03-17 13:58:50 -04:00
Marco Pivetta
6a1755972d Revert "Merge branch 'hotfix/#1220-sort-paginator-subquery-output-only-once'"
This reverts commit 8f097ab30436412e8a62ead3fefe27c28d5bc905, reversing
changes made to b23a8dd4293a2509d64d8e650d9cccf088cded9f.

Conflicts:
	tests/Doctrine/Tests/ORM/Tools/Pagination/LimitSubqueryOutputWalkerTest.php
2015-01-24 13:10:25 +01:00
Bill Schaller
3fd3da3d46 Fixed removal of ASC and DESC keywords from orderby items that will be included in select list 2015-01-17 22:12:26 +01:00
Bill Schaller
8350de781f Doc fix 2015-01-17 22:12:26 +01:00
Bill Schaller
dfc0910756 Fixed how order by items are included in the select list of the select distinct wrapper statement 2015-01-17 22:12:26 +01:00
Bill Schaller
ed800e4b86 Added function to LimitSubqueryOutputWalker which takes an order by clause and rebuilds it to work in the scope of the wrapping query 2015-01-17 22:12:25 +01:00
Bill Schaller
a4ebc08c4f * Modified tests in LimitSubqueryOutputWalkerTest.php to not have duplicated order by clauses
* Modified LimitSubqueryOutputWalker to not duplicate order by clauses
2015-01-17 22:12:25 +01:00
Marco Pivetta
ac67a10d4c DDC-3434 - adding note on why restoring 'HIDDEN' selected fields is relevant 2014-12-05 18:02:12 +01:00
Marco Pivetta
6169175a89 DDC-3434 - HIDDEN modifier marked fields in ORDER BY clause are always preserved when creating a paginator subquery 2014-12-05 17:11:57 +01:00
Marco Pivetta
e53e8bfe8e DDC-3336 - applied hotfix: only PathExpression instances have a $field property 2014-12-05 14:56:47 +01:00
Marco Pivetta
f536daa1e4 #1188 - Simplified and optimized parameter un-setting logic 2014-11-27 18:08:11 +01:00
Marco Pivetta
ac0f1b2ce2 #1188 - Importing parser class 2014-11-27 17:59:12 +01:00
Marco Pivetta
69064ac13d #1188 - making Doctrine\ORM\Tools\Pagination\Paginator#getCountQuery() private, as it is an implementation detail 2014-11-27 17:48:37 +01:00
Marco Pivetta
a80117a4ee #1188 - removing unused variable assignments 2014-11-27 17:42:14 +01:00
Paweł Kolanowski
af39fce6e5 Missing doc block, removed parse() parameter.
Missing doc block, removed parse() parameter.
2014-11-27 17:27:22 +01:00
Merixstudio
d02ea224df Allowed to get count query from paginator. 2014-11-27 17:27:22 +01:00
Merixstudio
42aff75108 Fixed counting exception
Fixed "Invalid parameter number: number of bound variables does not match number of tokens " exception during execution count on Query where select part of query contains :parameters.
2014-11-27 17:27:22 +01:00
František Bereň
589d26fc5e Changed calling $from[0] to using reset($from)
changed usage $from[0] according suggestion from @Ocramius  to use array
reset function
2014-09-02 08:39:29 +02:00
František Bereň
d48be34696 CS Fixes 2014-08-28 13:17:25 +02:00
František Bereň
a37f99f242 Root selection according other pagination tools
changed root selection in Walkers from looping queryComponents to using
$AST->fromClause as other walkers have
2014-07-30 15:55:14 +02:00
František Bereň
114bd2435f Arbitrary Join count walkers solution
Possible solution for Arbitrary Join problem in pagination count
walkers:
https://groups.google.com/forum/#!topic/doctrine-user/rpPYCDNKOU8

Added a condition to test query component against  SelectStatement from
clause
2014-07-30 09:56:22 +02:00
Guilherme Blanco
be1cc14a9c DDC-2890 Fixed pagination with association order by. 2014-04-17 19:29:18 +00:00
Fabio B. Silva
8c2aef3f14 [DDC-2943] Disable slc for pagination queries 2014-03-01 01:15:09 -05:00
Benjamin Morel
412e4ab9da Cleaned up unused imports 2014-02-09 22:12:51 +00:00
Benjamin Eberlei
d31f7ebf57 [DDC-1985] Fix ordering preservation in SQL limit subquery output walker. 2014-02-08 17:01:55 +01:00
Fabio B. Silva
3529cd4282 Merge pull request #797 from peterkokot/patch-1
CS fixes
2013-11-16 10:52:09 -08:00