1
0
mirror of synced 2025-01-29 19:41:45 +03:00

Merge pull request #797 from peterkokot/patch-1

CS fixes
This commit is contained in:
Fabio B. Silva 2013-11-16 10:52:09 -08:00
commit 3529cd4282
7 changed files with 11 additions and 11 deletions

View File

@ -477,7 +477,7 @@ class ObjectHydrator extends AbstractHydrator
$targetClass = $this->ce[$relation['targetEntity']];
if ($relation['isOwningSide']) {
//TODO: Just check hints['fetched'] here?
// TODO: Just check hints['fetched'] here?
// If there is an inverse mapping on the target class its bidirectional
if ($relation['inversedBy']) {
$inverseAssoc = $targetClass->associationMappings[$relation['inversedBy']];

View File

@ -328,7 +328,7 @@ class BasicEntityPersister
$identifier = $this->quoteStrategy->getIdentifierColumnNames($versionedClass, $this->platform);
$columnName = $this->quoteStrategy->getColumnName($versionField, $versionedClass, $this->platform);
//FIXME: Order with composite keys might not be correct
// FIXME: Order with composite keys might not be correct
$sql = 'SELECT ' . $columnName
. ' FROM ' . $tableName
. ' WHERE ' . implode(' = ? AND ', $identifier) . ' = ?';
@ -1976,4 +1976,4 @@ class BasicEntityPersister
$sql = implode(' AND ', $filterClauses);
return $sql ? "(" . $sql . ")" : ""; // Wrap again to avoid "X or Y and FilterConditionSQL"
}
}
}

View File

@ -82,7 +82,7 @@ class IdentityFunction extends FunctionNode
}
}
//The table with the relation may be a subclass, so get the table name from the association definition
// The table with the relation may be a subclass, so get the table name from the association definition
$tableName = $sqlWalker->getEntityManager()->getClassMetadata($assoc['sourceEntity'])->getTableName();
$tableAlias = $sqlWalker->getSQLTableAlias($tableName, $dqlAlias);

View File

@ -1878,7 +1878,7 @@ class Parser
case ($lookahead === Lexer::T_OPEN_PARENTHESIS):
return $this->SimpleArithmeticExpression();
//this check must be done before checking for a filed path expression
// this check must be done before checking for a filed path expression
case ($this->isFunction()):
$this->lexer->peek(); // "("
@ -1896,7 +1896,7 @@ class Parser
}
break;
//it is no function, so it must be a field path
// it is no function, so it must be a field path
case ($lookahead === Lexer::T_IDENTIFIER):
$this->lexer->peek(); // lookahead => '.'
$this->lexer->peek(); // lookahead => token after '.'
@ -2431,7 +2431,7 @@ class Parser
switch ($peek['value']) {
case '(':
//Peeks beyond the matched closing parenthesis.
// Peeks beyond the matched closing parenthesis.
$token = $this->peekBeyondClosingParenthesis(false);
if ($token['type'] === Lexer::T_NOT) {

View File

@ -134,7 +134,7 @@ abstract class AbstractExporter
}
foreach ($this->_metadata as $metadata) {
//In case output is returned, write it to a file, skip otherwise
// In case output is returned, write it to a file, skip otherwise
if($output = $this->exportClassMetadata($metadata)){
$path = $this->_generateOutputPath($metadata);
$dir = dirname($path);

View File

@ -166,7 +166,7 @@ class LimitSubqueryOutputWalker extends SqlWalker
if ($this->platform instanceof PostgreSqlPlatform ||
$this->platform instanceof OraclePlatform) {
//http://www.doctrine-project.org/jira/browse/DDC-1958
// http://www.doctrine-project.org/jira/browse/DDC-1958
$this->preserveSqlOrdering($AST, $sqlIdentifier, $innerSql, $sql);
}
@ -215,7 +215,7 @@ class LimitSubqueryOutputWalker extends SqlWalker
}
}
}
//remove identifier aliases
// remove identifier aliases
$sqlOrderColumns = array_diff($sqlOrderColumns, $sqlIdentifier);
}

View File

@ -2406,7 +2406,7 @@ class UnitOfWork implements PropertyChangedListener
{
$coid = spl_object_hash($coll);
//TODO: if $coll is already scheduled for recreation ... what to do?
// TODO: if $coll is already scheduled for recreation ... what to do?
// Just remove $coll from the scheduled recreations?
if (isset($this->collectionUpdates[$coid])) {
unset($this->collectionUpdates[$coid]);