Mark Salsbery
23d00c92c1
Added preventDefault option to MouseTracker handlers: scrollHandler, keyDownHandler, keyUpHandler, keyHandler
2021-03-16 19:35:22 -07:00
Mark Salsbery
3947c81726
Added dragToPan to the GestureSettings class, implemented in Viewer
2021-03-16 10:40:36 -07:00
Ian Gilman
84b0aea54b
Merge branch 'master' into ms-preventDefaultAction
2021-03-12 11:44:10 -08:00
ronnymikalsen
89d4499c2f
Merge branch 'master' into 1763-a11y-browser-zoom
2021-03-12 10:21:42 +01:00
Mark Salsbery
57a98c5ec2
Fixed preventDefaultAction functionality tests, removed unused preventDefaultAction instances from MouseTracker
2021-03-11 20:30:50 -08:00
Mark Salsbery
0195c5a5ec
preventDefaultAction - removed from MouseTracker, implemented for canvas-pinch and canvas-scroll events
2021-03-11 16:09:57 -08:00
Mark Salsbery
c38188927e
Added preventDefault option to MouseTracker.contextMenuHandler and Viewer 'canvas-contextmenu' event args
2021-03-10 13:45:15 -08:00
Mark Salsbery
459fcb9a4e
Merge branch 'master' into ms-mousetracker
...
* master:
Changleg for #1878
Separate properties for buttonGroup and customButtons
Better handle destruction when navigator in custom location
# Conflicts:
# src/viewer.js
2021-03-08 09:42:32 -08:00
Mark Salsbery
73dc6895f1
Removed commented legacy fix code ( #1872 )
2021-02-09 16:28:42 -08:00
ronnymikalsen
4a51a4e47c
refactor: removed empty line
2021-02-05 12:39:10 +01:00
ronnymikalsen
eb113662e8
refactor: cleanup code
2021-02-05 11:48:08 +01:00
ronnymikalsen
c410b82e65
fix: refresh $.pixelDensityRatio
2021-02-04 13:39:26 +01:00
ronnymikalsen
39811d9300
fix: draw the level based on pixel density ratio
2021-02-04 12:24:01 +01:00
Steve Halasz
0ede8992de
Separate properties for buttonGroup and customButtons
...
This makes it more clear what we're testing for or calling methods on, vs. assigning to this.buttons in both the
useGroup true and false cases.
2020-12-18 13:25:29 -05:00
Steve Halasz
8178687298
Better handle destruction when navigator in custom location
2020-09-10 17:40:30 -04:00
Mark Salsbery
c969f85239
contextmenu
2020-08-25 11:46:35 -07:00
Mark Salsbery
b07d47011f
preventDefaultAction docs
2020-08-14 16:42:06 -07:00
Mark Salsbery
e74d83f104
New preProcessEvent event
2020-08-12 21:22:48 -07:00
Mark Salsbery
e7a62c2717
Enhanced pointer capture implementation, IE bug workarounds
2020-07-30 21:08:02 -07:00
Mark Salsbery
e47f629a9e
Undo unnecessary event property changes from previous commit
2020-07-28 20:20:09 -07:00
Mark Salsbery
ef45f1df1d
Fixed/enhanced Viewer event object properties
2020-07-25 20:08:52 -07:00
Mark Salsbery
d2bb480363
Browser sniffing and pointer events fixes and enhancements
2020-07-24 20:05:39 -07:00
Mark Salsbery
f20b7e738c
Stricter linting fixes part 1
2020-06-30 10:25:38 -07:00
Mark Salsbery
c4351f64e8
stricter linting
2020-06-25 16:01:14 -07:00
Johannes Mueller
5f933b12bb
Clear listeners and nodes to avoid memory leaks
2020-06-05 12:27:00 +02:00
Greg Garson
8f0e876d4f
Pass useCanvas value down to reference strip viewers.
2019-11-20 10:36:54 -08:00
alvaromartmart
df45b0fd8c
fix wrong documentation description of Viewer.world
2019-10-09 15:13:52 +02:00
Álvaro Martínez
5a55ce4583
updated viewer.addOverlay and viewer.updateOverlay documentation ( #1694 )
2019-08-14 23:50:29 +02:00
Andreas Levers
21cfb0acf4
Fixed issue #1557 : Typo in viewer.js
...
Fixed a typo in areControlsEnabled
2018-10-31 18:15:48 +01:00
Stefan Weil
0e2f5d49ef
Fix some typos in comments (found by codespell)
...
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-09-01 10:59:20 +02:00
Jonathan Lake
2dd8a65e63
Adds option to set rotation increment for nav buttons and keyboard; Issue 1518
2018-08-21 17:39:46 -04:00
Ian Gilman
8eee617ed4
Merge pull request #1515 from Fabroh/master
...
Fix issue #1504
2018-08-10 09:48:55 -07:00
Fabien Rohman
b055f6fe54
Fix issue #1504
2018-08-10 10:23:33 +02:00
Peter
9968025782
Simplified imageSmoothingEnabled Option. The option can be set during viewer creation and also later with the function viewer.drawer.setImageSmoothingEnabled().
2018-08-03 18:47:16 -04:00
Peter
17e25c0428
Revert "Added switch to smoothly or unsmoothly render images on the canvas: imageSmoothingEnabled (true (default), false). Medical images can thus be displayed in more pixelated, unsmoothed manner."
...
This reverts commit 19f7b80dca
.
2018-08-03 17:29:48 -04:00
Peter
19f7b80dca
Added switch to smoothly or unsmoothly render images on the canvas: imageSmoothingEnabled (true (default), false). Medical images can thus be displayed in more pixelated, unsmoothed manner.
2018-07-30 20:00:58 -04:00
Ian Gilman
0043956e2a
Merge pull request #1479 from alanaberdeen/master
...
Documentation addition for viewer.world
2018-06-15 13:26:04 -07:00
Alan Aberdeen
a691fbb37e
Add note that source in viewer.js is depreciated
...
source is in viewer.js for backwards compatibility. It is not an official part of the API and should not be relied upon.
2018-06-14 21:50:45 +01:00
evilricio
6c2c5ba498
Add CSS configuration options for the navigator minimap
...
This patch adds CSS configuration options for the navigator minimap, namely:
- background color
- opacity
- outside border color
- display region border color
If unspecified, the previous default values are kept as default as not to break previous implementations.
2018-06-14 17:38:30 +01:00
Alan Aberdeen
2a67484358
Add *correct* documentation for source on Viewer
2018-06-13 20:27:57 +01:00
Alan Aberdeen
0c4eafb669
Revert "Add documentation for source on Viewer"
...
This reverts commit 99b7c3d2e5
.
2018-06-13 20:25:00 +01:00
Alan Aberdeen
99b7c3d2e5
Add documentation for source on Viewer
2018-06-13 20:15:51 +01:00
Alan Aberdeen
1024a2e1d8
Documentation addition for viewer.world
2018-06-13 12:32:10 +01:00
Ian Gilman
e01e36794d
Merge pull request #1441 from nelsonn3c/feature/flip
...
Adds flip/mirror slides feature.
2018-06-07 09:48:59 -07:00
Ian Gilman
24be785bbd
Updated to latest packages (and fixed lint errors)
2018-05-11 10:53:16 -07:00
Nelson Campos
43d3949dd1
Refactored 90 degrees rotation button's actions.
2018-04-17 11:19:15 +01:00
Nelson Campos
84dc60632c
code simplification and impro^Cments on toggleFlip function
2018-04-11 18:24:01 +01:00
Nelson Campos
b8a4f7e7a0
Reorganizes code to match standard calls of viewport object methods.
...
A new viewport function was created (toggleFlip()) to change viewport's flip state and demand new viewers drawing.
The onFlip function exists on openseadragon to handle flip control button press and demand viewport toggle flip.
2018-04-11 11:25:46 +01:00
Nelson Campos
6e2c1258df
Comments on functions
2018-04-10 12:04:58 +01:00
Nelson Campos
7e5c9e1897
Changes flip store object from viewer to viewport.
...
More than changing the store object of flip state, the code was simplified and the onFlip function from openseadragon was changed to receive a viewer argument.
TiledImage had a flipped variable wrongly stored.
From now on, flipped state must be read from the viewport object.
2018-04-10 11:51:06 +01:00
Nelson Campos
f65dbd3a39
Changes back showFlipControl and showNavigator variables to false default state
2018-04-09 15:06:29 +01:00
Nelson Campos
6e4012976b
Adds two helpers for style formating and updates onCanvasKeyPress method.
...
There were created a new helper method "setDisplayTransform" to change navigator styling.
Also, a new general function "setElementTransform" was created to help on element styling.
For this commit, I also made some changes on viewer onCanvasKeyPress method:
- r is rotating the image clockwise;
- R is rotating the image counter clockwise;
- Freed "F" keycode to other purposes (like filters or others).
2018-04-06 11:52:10 +01:00
Nelson Campos
71fd747051
Adds flip/mirror slides feature.
...
This commit adds full support for a new OpenSeaDragon(OSD) feature - Mirror/Flip.
In order to fully support this new feature, the following OSD objects had to be modified:
- drawer.js:
- navigator
- openseadragon
- strings
- tiledImage
- viewer
Additionally, a new flip button was created (similar to the existing ones).
Flip Logic
Whenever the state is flip button is pressed, flip state is toogled, inverting all the controls and displays (the rotation direction is inverted as well).
This means that all viewer coordinates (including user inputs) must me inverted too.
Summary of modifications
- drawer.js: modified _offsetForRotation to invert rotation angle on flipped state. Added a _flip method to scale/mirror canvas context.
- navigator.js: adds full flip support and inverts nagivator inputs.
- openseadragon.js: new buttons, flip state variable and showFlipControl variable.
- strings.js: flip tool help tips.
- tiledImage.js: flips the actual drawing canvas.
- viewer.js: Added keyboardshortcuts to rotate 90degrees (r/R) and flip image (f/F). flip button state is stored here and flip order is set.
The flipped state is stored on viewer object.
2018-04-04 16:08:13 +01:00
schueffp@mskcc.org
85d8d9ee32
Added option zoomToRefPoint for all gestureSettings
...
This is an option for different applications or user preferences:
If zoomToRefPoint in a gesture setting is true (default), the zoom is
centered at the pointer position. Otherwise, the zoom is centered at the
canvas center.
2018-03-16 11:29:16 +01:00
Ian Gilman
c915a5966f
Changelog for #1414 plus documentation tweak
2018-03-07 09:28:20 -08:00
Francesco Cretti
44ca4a79b8
trailing spaces removed
2018-03-07 11:07:29 +01:00
Francesco Cretti
34f691df28
Event name and documentation
2018-03-07 10:32:31 +01:00
Francesco Cretti
2b878cbdbf
keyboard handlers patch
2018-03-06 15:51:22 +01:00
Jan Hudecek
5ddcfa438e
Added option pixelsPerArrowPress that sets the speed of movement by arrow keys
2017-12-14 17:10:10 +01:00
Ian Gilman
854086a62f
Merge pull request #1330 from ncmikkelsen/master
...
Fix for #1085 - goToPage : event sent before updating the index
2017-10-30 09:17:42 -07:00
Nikolaj Mikkelsen
a7cc7bbfba
Refactor: move the documentation comment down with the event
2017-10-26 22:36:19 +02:00
Rob Hicks
2db5cfeebd
move TiledImage instance instructions to function description
2017-10-26 12:36:30 -06:00
Rob Hicks
d59e237dda
more doc tweaks
2017-10-25 14:55:28 -06:00
Rob Hicks
12e1869f99
add clarifications to api docs for TiledImage
2017-10-25 14:51:17 -06:00
Nikolaj Mikkelsen
1a6aac578b
Fix for #1085 - goToPage : event sent before updating the index
2017-10-24 16:14:20 +02:00
Oeystein Lygre
d1ea179296
manage preventDefaultAction flag in canvas-double-click viewer event
...
Trigger the canvas-double-click event before default double tap to zoom happens on the viewer
2017-08-22 23:11:12 +02:00
Ian Gilman
49ee98bbb0
Fixed a problem with preventDefaultAction for the canvas-drag event
2017-08-03 10:47:35 -07:00
Ian Gilman
e8971b2940
Merge branch 'master' of https://github.com/thejohnhoffer/openseadragon into thejohnhoffer-master
2017-07-13 16:53:43 -07:00
Gehan Gonsalkorale
76f5a0ed33
Fix for #1232 - constrainDuringPan causes jitter on mobile
2017-07-11 22:39:01 +01:00
Jose
aabfa32595
Merge conflict resolved
2017-07-10 23:01:04 +02:00
Ian Gilman
f0a943281b
Changelog for #1213
2017-07-05 09:42:10 -07:00
Ian Gilman
818d445ec9
Merge pull request #1213 from VipSaran/master
...
fix for #1210 (Dinamically show ReferenceStrip)
2017-07-05 09:38:29 -07:00
Robert Saric
51cf6201cf
fix for #1210 (Dinamically show ReferenceStrip) yet additional changes
2017-07-01 09:57:36 +02:00
Robert Saric
ec7e5e5419
fix for #1210 (Dinamically show ReferenceStrip) additional changes
2017-06-24 17:58:19 +02:00
endevea
101a734aaf
process ready items always even if others fail
2017-06-22 13:43:34 +08:00
John Perdue
bfa0ac0137
Added setDebugMode function to Viewer.
...
Added SetDebugMode tests.
Update in respose to PR review.
2017-06-19 21:29:41 +01:00
Robert Saric
a783edc76f
fix for #1210 (Dinamically show ReferenceStrip)
2017-06-06 18:21:14 +02:00
Robert Saric
6f3b0a6d75
fix for #1165 (Reference strip not updated for initially set page)
2017-06-03 16:10:57 +02:00
John Hoffer
1ae3a9b961
Merge branch 'master' into master
2017-05-30 12:58:05 -04:00
thejohnhoffer
7a4fda37b5
setPreload correctly treats both Primatives and Objects as Boolean Primatives
2017-05-30 12:00:43 -05:00
Ian Gilman
29f973029f
Changelog for #1196 and doc tweaks
2017-05-15 10:13:34 -07:00
Ian Gilman
bf1b5fd793
Merge pull request #1196 from VipSaran/master
...
fix for #1191 (extension of Viewer.open() function with initialPage argument)
2017-05-15 10:07:58 -07:00
Robert Saric
bb68755699
fix for #1191 (extension of Viewer.open() function with initialPage argument)
2017-05-14 15:56:21 +02:00
Ian Gilman
dc70acec55
Merge pull request #1192 from UCLALibrary/timeout-configuration
...
Enable configuration of ImageJob timeout
2017-05-12 10:28:39 -07:00
Mark Allen Matney, Jr
77da306397
Enable configuration of ImageJob timeout
2017-05-11 21:36:27 -07:00
Ian Gilman
e55c5beb1c
Merge pull request #1189 from lastlegion/master
...
[FIX #1188 ] added fix for supporting weird filenames that look like JSONs
2017-05-11 10:01:07 -07:00
Ganesh Iyer
ce1360f5cb
using try/catch $.parseJSON to check for JSONs
2017-05-10 17:51:59 -04:00
Ganesh Iyer
2a251b219a
added fix for supporting weird filenames that look like JSONs
2017-05-09 14:55:23 -04:00
Sean Nichols
6fdf81f266
Ignore falsy header values and improve ajaxHeaders documentation
2017-05-05 15:37:33 -04:00
Sean Nichols
15fe35a589
Improve documentation and option/argument names
2017-05-05 15:37:33 -04:00
Sean Nichols
ddab768696
Add options for loading tiles via AJAX and custom AJAX request headers.
2017-05-05 15:37:33 -04:00
superbland
bb229c24d3
Only apply constraints during an actual drag
2017-04-24 22:47:40 +01:00
jonw-cogapp
ab6cdf102e
prevent unnecessary panBy on canvas-drag in viewer
2017-04-21 18:19:11 +01:00
Ian Gilman
2f7ebc2d67
Merge pull request #1149 from sickrandir/preventDefault-canvas-drag
...
Manage preventDefaultAction flag inside the canvas-drag viewer event
2017-04-21 09:51:24 -07:00
kinto
741745433d
manage preventDefaultAction flag inside the canvas-drag viewer event. Trigger the canvas-drag event before default drag happens on the viewer
2017-03-15 09:51:44 +01:00
kinto
bc5e235822
Add comment instructions for using preventDefaultAction parameter in canvas-click event
2017-03-14 19:23:07 +01:00
kinto
d5031835da
manage preventDefaultAction flag inside the canvas-click viewer event. Trigger the canvas-click event before default click zoom happens on the viewer
2017-03-14 16:08:52 +01:00
Jose
fba70355cd
In-iframe check added before resetting all active mousetrackers
2017-02-23 19:15:29 +01:00
Jose
70bdc8839e
Some issues solved
2017-02-20 20:23:25 +01:00
Jose
d5b62aabcd
Patch to fix issue #697 , also contains improvements when panning under certain constrains
2017-02-19 17:36:53 +01:00
Antoine Vandecreme
de25b68b43
Add eslint and hound
2017-01-16 21:41:07 +01:00
thejohnhoffer
0a44585457
documentation of opacity and preload relations
2016-11-03 22:39:00 -04:00
thejohnhoffer
bac2cab8e9
document tiledImage.preload
2016-11-02 20:45:33 -04:00
Antoine Vandecreme
33332bf774
Set rotation around center and fix typo.
2016-08-28 13:39:26 +02:00
Antoine Vandecreme
9e69462405
Merge branch 'master' of https://github.com/openseadragon/openseadragon
2016-08-21 13:16:38 +02:00
Antoine Vandecreme
a9f5e7ec73
Add unit test and fix code review comments.
2016-08-21 12:54:33 +02:00
Antoine Vandecreme
65b59c08d6
First draft of tiled image rotation.
2016-08-17 15:43:08 +02:00
Sebastian Öberg
77726a684f
Use control anchor configuration for custom toolbar also
2016-08-15 13:54:10 +02:00
Rick Burgstaler
dde379ba12
Make tileSources option smarter about detecting when a json string or xml string has been passed in
...
The tileSources option was only using a test looking for the presence of a "{", "[", or "<" character to determine if a json string or xml string was passed in. It is possible for a url to contain one of these characters as well which would break using the url as a tileSources parameter. The following is an example of a breaking url:
http://myurl.org/{25fb14f0-a839-4c4d-8c97-dd1d67b2cb35}/MyImage.xml
This patch resolves this issue.
2016-08-10 14:30:10 -05:00
Larissa Smith
4ccabe78de
Passed options.crossOriginPolicy into getTileSource. Also changed checks on crossOriginPolicy to compare to undefined, and added tests for the addTiledImage crossOriginPolicy api.
2016-07-28 09:35:43 -06:00
Larissa Smith
1e0ddcedc1
Added an option to addTiledImage to change the crossOriginPolicy. addTiledImage will also check the tileSource for crossOriginPolicy.
2016-07-21 10:26:02 -06:00
plougsgaard
b3a10aca3b
Introduce variable iOSDevice
that disables 8c4fcc9
when running on an iOS device.
2016-06-17 16:37:30 +02:00
A
033b650c29
Fix #946
...
Fix for https://github.com/openseadragon/openseadragon/issues/946
2016-05-26 13:24:03 -04:00
Ian Gilman
ebf7cbf918
Merge pull request #940 from avandecreme/fullpage
...
Enforce html element width and height to 100% when going full page.
2016-05-17 09:51:08 -07:00
Antoine Vandecreme
32f993f862
Enforce html element width and height to 100% when going full page.
2016-05-16 13:08:17 -04:00
Ian Gilman
ea32e1b090
Merge pull request #935 from leesei/master
...
feat(navigator): add option autoFade
2016-05-16 09:40:23 -07:00
Antoine Vandecreme
1014d5767c
Fix resize handling.
2016-05-12 19:23:09 -04:00
leesei
7ea8733e5b
feat(navigator): add option autoFade
2016-05-07 17:16:59 +08:00
Antoine Vandecreme
521e020b9a
Viewport getBounds and fitBounds methods now take rotation into account. Fix #924
2016-05-04 22:26:33 -04:00
Antoine Vandecreme
55e0811294
Merge remote-tracking branch 'upstream/master' into doc
2016-04-10 18:37:11 -04:00
Antoine Vandecreme
4fa7ed1590
Adapt doc to new version of JSDoc.
2016-04-09 10:15:02 -04:00
Antoine Vandecreme
70b39d681b
Fix viewer.addOverlay and Overlay.getBounds
2016-03-31 13:25:59 -04:00
Antoine Vandecreme
577327a629
Change overlays to now always having Point location.
2016-03-30 15:12:50 -04:00
Antoine Vandecreme
cac5f6dec3
Add overlays rotation support.
2016-03-28 17:06:59 -04:00
Antoine Vandecreme
3e3ce188b1
Add scaleWidth and scaleHeight options to overlays.
2016-03-25 16:49:58 -04:00
Ian Gilman
430804ef16
Merge pull request #888 from avandecreme/fit-in-bounds
...
Add TiledImage.fitInBounds method.
2016-03-24 09:47:15 -07:00
Antoine Vandecreme
3cacc8edcf
Add fitBounds option to TiledImage constructor.
2016-03-22 16:41:28 -04:00
Antoine Vandecreme
9c461824b3
Update OpenSeadragon.Placement to be serializable.
2016-03-22 15:50:48 -04:00
Ian Gilman
55cf2bd6b9
Merge pull request #884 from avandecreme/master
...
Fix flick gesture with rotation. Fix #869
2016-03-22 09:18:18 -07:00
Antoine Vandecreme
2386900e29
Fix drag with panHorizontal/panVertical set to false.
2016-03-20 11:01:26 -04:00
Antoine Vandecreme
2740792df3
Fix flick gesture with rotation. Fix #869
2016-03-20 10:04:23 -04:00
Ian Gilman
66f99a1d39
Really no tabIndex if you pass "".
2016-03-08 09:58:50 -08:00
Grant Echols
a54d896a45
Added note about locations being viewport relative for overlays.
2016-03-04 11:26:53 -07:00
Ian Gilman
856f00994b
Changelog for #853
2016-02-23 09:22:53 -08:00
Ian Gilman
cb1318de1f
Merge pull request #853 from altert/smallfix
...
Add Viewer.getOverlayById and Overlay.getBounds functions
2016-02-23 09:21:16 -08:00
Alexey Tikhonov
655f5e5996
Merge branch 'master' of https://github.com/openseadragon/openseadragon into smallfix
2016-02-23 03:57:20 +03:00
Alexey Tikhonov
c44f134a6a
remove 'to be removed' from getOverlayById @param comment to avoid confusion
2016-02-23 02:22:47 +03:00
Grant Echols
5f3eebe4e9
Added check to see if we were zooming before swallowing the canvas scroll event.
2016-02-22 11:59:37 -07:00
Alexey Tikhonov
97381b04a9
return null instead of false in Viewer.getOverlayById function and correct documentation
2016-02-20 00:45:33 +03:00
Antoine Vandecreme
57a52835a2
Merge branch 'master' of https://github.com/openseadragon/openseadragon into rotation
2016-02-17 18:33:43 -05:00
Alexey Tikhonov
06d263b4be
Add Viewer.getOverlayById and Overlay.getBounds functions
2016-02-18 01:43:53 +03:00
Antoine Vandecreme
4634d90715
Rename this.homeBounds to this._contentBounds.
2016-02-11 20:14:49 -05:00
Alexey Tikhonov
d43c854c9f
start/stop tracking outerTracker on setMouseNavEnabled
2016-02-11 23:54:31 +03:00
Antoine Vandecreme
9dbcd28a5a
English fixes.
2016-01-27 21:49:05 -05:00
Antoine Vandecreme
ea6addb4c8
Add Viewer.addSimpleImage method. Fix #818
2016-01-26 18:02:11 -05:00
Mei-Hui Su
3cfe8ecac2
Merge https://github.com/openseadragon/openseadragon
2016-01-14 12:32:54 -08:00
Mei-Hui Su
087507c823
1) update according to comments from openseadragon's
2016-01-07 12:47:17 -08:00
accraze
a3f0216ad7
Added tabIndex to default to zero
...
empty string is also accepted as well.
2016-01-06 20:00:38 -08:00
Mei-Hui Su
ea833a780c
Update to allow setting of globalCompositeOperation when
...
html <canvas> is used to process multiple tiledImages to blend
is a specific way.
(special handling,
when compositeOperation is 'source-over' and opacity is 1,
useSketch is false, otherwise useSketch is true
)
Valid values are 'source-atop', 'source-in', 'source-out',
'destination-over', 'destination-atop', 'destination-in',
'destination-out', 'lighter', 'copy' or 'xor'
http://www.w3schools.com/tags/canvas_globalcompositeoperation.asp
2016-01-06 07:58:36 -08:00
accraze
3925d1cb14
fixed tabIndex to handle empty string
...
chrome acts buggy and jumps when tabindex is not set to empty string.
fixes #769
2015-12-22 16:55:08 -08:00