small cleanups

This commit is contained in:
Tom 2024-01-11 13:29:59 -05:00
parent 500c22feb1
commit 3bab3c2190
5 changed files with 3 additions and 7 deletions

View File

@ -272,6 +272,7 @@ $.DrawerBase = class DrawerBase{
* @property {OpenSeadragon.TiledImage} tiledImage - Which TiledImage is being drawn. * @property {OpenSeadragon.TiledImage} tiledImage - Which TiledImage is being drawn.
* @property {Array} tiles - An array of Tile objects that were drawn. * @property {Array} tiles - An array of Tile objects that were drawn.
* @property {?Object} userData - Arbitrary subscriber-defined object. * @property {?Object} userData - Arbitrary subscriber-defined object.
* @private
*/ */
this.viewer.raiseEvent( 'tiled-image-drawn', { this.viewer.raiseEvent( 'tiled-image-drawn', {
tiledImage: tiledImage, tiledImage: tiledImage,

View File

@ -115,7 +115,6 @@ class HTMLDrawer extends $.DrawerBase{
*/ */
setImageSmoothingEnabled(){ setImageSmoothingEnabled(){
// noop - HTML Drawer does not deal with this property // noop - HTML Drawer does not deal with this property
$.console.warn('HTMLDrawer.setImageSmoothingEnabled does not have an effect.');
} }
/** /**

View File

@ -214,7 +214,7 @@
* For complete list of modes, please @see {@link https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/globalCompositeOperation/ globalCompositeOperation} * For complete list of modes, please @see {@link https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/globalCompositeOperation/ globalCompositeOperation}
* *
* @property {Boolean} [imageSmoothingEnabled=true] * @property {Boolean} [imageSmoothingEnabled=true]
* Image smoothing for canvas rendering (only if canvas is used). Note: Ignored * Image smoothing for canvas rendering (only if the canvas drawer is used). Note: Ignored
* by some (especially older) browsers which do not support this canvas property. * by some (especially older) browsers which do not support this canvas property.
* This property can be changed in {@link Viewer.Drawer.setImageSmoothingEnabled}. * This property can be changed in {@link Viewer.Drawer.setImageSmoothingEnabled}.
* *

View File

@ -368,10 +368,7 @@
* @param {Boolean} enabled * @param {Boolean} enabled
*/ */
setImageSmoothingEnabled(enabled){ setImageSmoothingEnabled(enabled){
//TODO: does imageSmoothingEnabled make sense in the WebGL drawer? // noop - this property does not impact WebGLDrawer
// We aren't scaling small images up to larger ones using context2d canvas operations so it may not apply
this._clippingContext.imageSmoothingEnabled = !!enabled;
this._outputContext.imageSmoothingEnabled = !!enabled;
} }
/** /**

View File

@ -16,7 +16,6 @@
// debugMode: true, // debugMode: true,
zoomPerScroll: 1.02, zoomPerScroll: 1.02,
showNavigator: testNavigator, showNavigator: testNavigator,
drawer: ['canvas', 'html'],
// defaultZoomLevel: 2, // defaultZoomLevel: 2,
// homeFillsViewer: true, // homeFillsViewer: true,
// sequenceMode: true, // sequenceMode: true,