From 3bab3c2190fd4ef086b286f664c5f90a9b02f40e Mon Sep 17 00:00:00 2001 From: Tom Date: Thu, 11 Jan 2024 13:29:59 -0500 Subject: [PATCH] small cleanups --- src/drawerbase.js | 1 + src/htmldrawer.js | 1 - src/openseadragon.js | 2 +- src/webgldrawer.js | 5 +---- test/demo/collections/main.js | 1 - 5 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/drawerbase.js b/src/drawerbase.js index 864ba699..3206c69f 100644 --- a/src/drawerbase.js +++ b/src/drawerbase.js @@ -272,6 +272,7 @@ $.DrawerBase = class DrawerBase{ * @property {OpenSeadragon.TiledImage} tiledImage - Which TiledImage is being drawn. * @property {Array} tiles - An array of Tile objects that were drawn. * @property {?Object} userData - Arbitrary subscriber-defined object. + * @private */ this.viewer.raiseEvent( 'tiled-image-drawn', { tiledImage: tiledImage, diff --git a/src/htmldrawer.js b/src/htmldrawer.js index 2469369c..3b716673 100644 --- a/src/htmldrawer.js +++ b/src/htmldrawer.js @@ -115,7 +115,6 @@ class HTMLDrawer extends $.DrawerBase{ */ setImageSmoothingEnabled(){ // noop - HTML Drawer does not deal with this property - $.console.warn('HTMLDrawer.setImageSmoothingEnabled does not have an effect.'); } /** diff --git a/src/openseadragon.js b/src/openseadragon.js index b6189f61..24ac3dea 100644 --- a/src/openseadragon.js +++ b/src/openseadragon.js @@ -214,7 +214,7 @@ * For complete list of modes, please @see {@link https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/globalCompositeOperation/ globalCompositeOperation} * * @property {Boolean} [imageSmoothingEnabled=true] - * Image smoothing for canvas rendering (only if canvas is used). Note: Ignored + * Image smoothing for canvas rendering (only if the canvas drawer is used). Note: Ignored * by some (especially older) browsers which do not support this canvas property. * This property can be changed in {@link Viewer.Drawer.setImageSmoothingEnabled}. * diff --git a/src/webgldrawer.js b/src/webgldrawer.js index 9c436837..2fc5ffdc 100644 --- a/src/webgldrawer.js +++ b/src/webgldrawer.js @@ -368,10 +368,7 @@ * @param {Boolean} enabled */ setImageSmoothingEnabled(enabled){ - //TODO: does imageSmoothingEnabled make sense in the WebGL drawer? - // We aren't scaling small images up to larger ones using context2d canvas operations so it may not apply - this._clippingContext.imageSmoothingEnabled = !!enabled; - this._outputContext.imageSmoothingEnabled = !!enabled; + // noop - this property does not impact WebGLDrawer } /** diff --git a/test/demo/collections/main.js b/test/demo/collections/main.js index 3e6d2169..ef5d8b60 100644 --- a/test/demo/collections/main.js +++ b/test/demo/collections/main.js @@ -16,7 +16,6 @@ // debugMode: true, zoomPerScroll: 1.02, showNavigator: testNavigator, - drawer: ['canvas', 'html'], // defaultZoomLevel: 2, // homeFillsViewer: true, // sequenceMode: true,