Commit Graph

25 Commits

Author SHA1 Message Date
klzgrad
a19a71b930 h2: Pad RST_STREAM frames
Clients sending too many RST_STREAM is an irregular behavior.

Hack in a preceding END_STREAM DATA frame padded towards [48, 72]
before RST_STREAM so that the TLS record looks like a HEADERS frame.

The server often replies to this with a WINDOW_UPDATE because padding
is accounted in flow control. Whether this constitudes a new irregular
behavior is still unclear.
2023-02-19 21:00:56 +08:00
klzgrad
db22c99707 h2: Add support for HTTP/2 CONNECT Fast Open
SpdyProxyClientSocket waits for 200 OK before returning OK for Connect.

Change that behavior to returning OK immediately after CONNECT header.

This feature is enabled by a "fastopen" header via the proxy delegate.

Design notes:

The current approach is better than the obvious TCP Fast Open style fake
Connect().

Fast Open should not be used for preconnects as preconnects need actual
connections set up. The Naive client does not use preconnects per se
(using "...RawConnect") but the user agent will use preconnects and the
Naive client has to infer that. Hence there is a need to check the
incoming socket for available bytes right before Connect() and configure
whether a socket should be connected with Fast Open. But fake Connect()
make it difficult to check the incoming socket because it immediately
returns and there is not enough time for the first read of the incoming
socket to arrive.

To check for preconnects it is best to push the first read of the
incoming socket to as late as possible. The other (wrong) way of doing
that is to pass in an early read callback and call it immediately after
sending HEADERS and then send the available bytes right there. This way
is wrong because it does not work with late binding, which assumes
Connect() is idempotent and causes sockets opened in this way to be
potentially bound to the wrong socket requests.

The current approach is to return OK in Connect() right after sending
HEADERS before getting the reply, which is to be received later. If the
reply is received during a subsequent Read() and the reply indicates an
error, the error is returned to the callback of the Read(); otherwise
the error is ignored with the connection disconnected and subsequent
Read() and Write() should discover the disconnection.
2023-02-19 21:00:56 +08:00
klzgrad
4ed135a739 h2: Reduce warnings about RST on invalid streams
Per RFC 7540#6.4:

  However, after sending the RST_STREAM, the sending endpoint MUST be
  prepared to receive and process additional frames sent on the stream
  that might have been sent by the peer prior to the arrival of the
  RST_STREAM.
2023-02-19 21:00:56 +08:00
klzgrad
3afb0b029c socket: Force tunneling for all sockets
In the socket system, only WebSocket sockets are allowed to tunnel
through HTTP/1 proxies. "Raw" sockets in the normal socket pool don't
have it, and their CONNECT headers are not sent, instead the raw
payload is sent as-is to the HTTP/1 proxy, breaking the proxying.

The socket system works like this:

- HTTP sockets via HTTP/1 proxies: normal pool, no tunneling.
- HTTPS sockets via HTTP/1 proxies: normal pool, no tunneling,
  but does its own proxy encapsulation.
- WS sockets via HTTP/1 proxies: WS pool, tunneling.

In Naive, we need the normal pool because the WS pool has some extra
restrictions but we also need tunneling to produce a client socket
with proxy tunneling built in.

Therefore force tunneling for all sockets and have them always send
CONNECT headers. This will otherwise break regular HTTP client sockets
via HTTP/1 proxies, but as we don't use this combination, it is ok.
2023-02-19 21:00:56 +08:00
klzgrad
b1da8a7ca7 socket: Allow higher limits for proxies
As an intermediary proxy we should not enforce stricter connection
limits in addition to what the user is already enforcing.
2023-02-19 21:00:56 +08:00
klzgrad
d7363a948a socket: Add RawConnect method 2023-02-19 21:00:56 +08:00
klzgrad
a8196e4af6 cert: Handle AIA response in PKCS#7 format 2023-02-19 21:00:56 +08:00
klzgrad
1004573905 cert: Use builtin verifier on Android and Linux 2023-02-19 21:00:56 +08:00
klzgrad
b12579ac2d cert: Add SystemTrustStoreStaticUnix
It reads CA certificates from:

* The file in environment variable SSL_CERT_FILE
* The first available file of

/etc/ssl/certs/ca-certificates.crt (Debian/Ubuntu/Gentoo etc.)
/etc/pki/tls/certs/ca-bundle.crt (Fedora/RHEL 6)
/etc/ssl/ca-bundle.pem (OpenSUSE)
/etc/pki/tls/cacert.pem (OpenELEC)
/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem (CentOS/RHEL 7)
/etc/ssl/cert.pem (Alpine Linux)

* Files in the directory of environment variable SSL_CERT_DIR
* Files in the first available directory of

/etc/ssl/certs (SLES10/SLES11, https://golang.org/issue/12139)
/etc/pki/tls/certs (Fedora/RHEL)
/system/etc/security/cacerts (Android)
2023-02-19 21:00:55 +08:00
klzgrad
507c1b3a7d libc++: Disable exceptions and RTTI
Except on Mac, where exceptions are required.
And except on Android, where rtti is required.
2023-02-19 19:34:46 +08:00
klzgrad
6338044992 url: Remove perfetto tracing 2023-02-19 19:34:46 +08:00
klzgrad
9c3ad180fa base: Disable trace event
This allows builds with enable_base_tracing=false.
2023-02-19 19:34:46 +08:00
klzgrad
63eee17b68 lss: Avoid naming conflict in fstatat64
Supports OpenWrt builds.
2023-02-19 19:34:46 +08:00
klzgrad
0b2944869e base: Fix iwyu in file_path.cc 2023-02-19 19:34:46 +08:00
klzgrad
fb254fa22b base: Don't fix Y2038 problem with icu 2023-02-19 19:34:46 +08:00
klzgrad
34ef03335f net, url: Remove icu 2023-02-19 19:34:46 +08:00
klzgrad
7513e67568 build: Force determinism in official build
Helps build with ccache.
2023-02-19 19:34:46 +08:00
klzgrad
2795dcbf57 build: Disable Android java templates 2023-02-19 19:34:46 +08:00
klzgrad
c5ffc2198b build: Disable build_with_chromium
The argument build_with_chromium mainly enables various tests,
data bundling, infra integration, and AFDO profiles.

AFDO can be added by other arguments.
2023-02-19 19:34:46 +08:00
klzgrad
903a7f9fd1 base: Remove JNI function on Android 2023-02-19 19:34:46 +08:00
klzgrad
cbea8449eb base: Add Android stubs 2023-02-19 19:34:45 +08:00
klzgrad
7a281baf0b net: Add Android stubs 2023-02-19 16:21:57 +08:00
klzgrad
6462f0a82a build: Remove tests and minimize 2023-02-19 16:21:57 +08:00
klzgrad
e8db747bc0 Add .gitignore 2023-02-19 12:34:07 +08:00
importer
253361980e Import chromium-110.0.5481.100 2023-02-19 12:34:07 +08:00