Marco Pivetta
23af164d7a
Note: this will still lead to the UnitOfWork#getSingleIdentifierValue() still being
...
called when not specifying the type of a DQL parameter being bound via
`Doctrine\ORM\Query#setParameter()`:
```php
$query->setParameter('foo', $theValue, $theType);
```
A full parameter bind is required in order to gain back performance:
```php
$query->setParameter('foo', $theValue, $theType);
```
This is up for discussion with patch reviewers.
2018-12-16 18:05:02 +01:00
sserbin
3dbe205498
Query\Expr::andX(): added string as allowed parameter type
2018-09-23 05:23:49 +02:00
philippe-unitiz
d3acbbf79b
Fix constructor argument type in Query\Base
2018-09-23 05:02:30 +02:00
philippe-unitiz
cb9ec8234b
Fix multiline parameter phpDoc in Query\Expr
...
See https://github.com/phan/phan/issues/1897 (parser won't accept `@param` spanning over several lines)
2018-09-23 05:02:01 +02:00
Michael Moravec
e26158a45e
Fix #7286 : StringPrimary no longer accepts aggregate functions as argument
2018-07-09 19:12:39 +02:00
Michael Moravec
6d81d519b6
Use non-deprecated version of Lexer and Inflector
2018-06-25 14:20:52 +02:00
Luís Cobucci
fc943b70f6
Use early-returns to improve readability of the Parser
2018-02-19 00:53:42 +01:00
Luís Cobucci
f36470941c
Fix BC-break on delete queries with nasty workaround
...
The `v2.5.x` series of the ORM allowed to have DELETE DQLs without using
an alias, even though it didn't follow the grammar rules of the parser.
We fixed that issue on `v2.6.0` however that was a BC-breaking change
and lots of people were relying on this faulty behaviour.
This workaround fixes the BC-break, without even trying to be elegant.
In `v2.7.0.` we should raise a deprecation notice to notify people that
we'll drop that "feature" in `v3.0`.
2018-02-19 00:53:36 +01:00
Maximilian Ruta
32c125def1
Fix syntax error when join with discriminator
2017-12-17 01:25:50 +01:00
Luís Cobucci
74ce8913fc
Upgrade phpstan to 0.9
...
Applying the necessary fixes.
2017-12-17 00:55:50 +01:00
Gabriel Caruso
d0d802309c
Clean elses
2017-12-14 05:55:54 -02:00
Sébastien Lévêque
f277eef6ea
Add support second, minute, week, year on DATE_ADD and DATE_SUB
2017-10-29 21:48:40 +01:00
Gocha Ossinkine
4fdbdabae4
Add DateInterval type parameter
2017-09-28 13:15:40 +05:00
Guilherme Lopes
df1250ee4b
Fix negation clause and also adding both conditions in the same if
2017-09-21 13:42:51 +02:00
Guilherme Lopes
8ecddc4fc1
Adding empty line between logic blocks
2017-09-21 10:13:19 +02:00
Guilherme Lopes
059cfd86df
Remove unnecessary else
2017-09-21 10:02:43 +02:00
Dariusz Ruminski
c7d6d62393
Use newer PHP syntax
2017-09-06 01:32:49 +02:00
Marco Pivetta
12043cd845
#5796 minor CS fixes (imported symbols) and removing last PHP5 compliance bits
2017-09-02 13:47:58 +02:00
Marco Pivetta
a1c93bfd48
#5796 replacing Exception catching with Throwable catching, removing PHP5 compliance code
2017-09-02 13:44:12 +02:00
Benjamin Morel
874a5e3547
Catch Throwable in PHP 7
2017-09-02 13:41:53 +02:00
Marco Pivetta
1a0bb82e1d
Merge pull request #6392 from Jean85/pr_1441_rebased
...
Correct DQL `INSTANCE OF` to filter all possible child classes
2017-08-18 21:35:54 +02:00
Alessandro Lai
19bc4991ae
Add more CS fixes
2017-08-18 12:35:51 +02:00
Alessandro Lai
d4db126bb0
Remove code duplication of the getAllDiscriminators method
2017-08-18 10:17:52 +02:00
Marco Pivetta
fda770700a
Merge pull request #6579 from Nek-/patch-1
...
Add string type as possible parameter for between
2017-08-18 04:33:04 +02:00
Marco Pivetta
9ad91ddc1c
#6464 #6475 using PHP 7.1 void and string return hints where available
2017-08-11 21:45:23 +02:00
Stefan Siegl
025ed1147b
#6464 code review updates
2017-08-11 21:36:33 +02:00
Stefan Siegl
99fdbf550d
generate nested join sql for CTIs, closes #6464
2017-08-11 21:36:33 +02:00
Maxime Veber
03d33ec900
Add string type as possible parameter for between
...
People may want to enter a date, or simply the parameter name. Linter may report an error while it's a good usage.
2017-07-24 14:23:16 +02:00
Ondrej Mirtes
1231861b09
Initial PHPStan integration (level 0)
2017-06-30 00:27:49 +02:00
Sergio Santoro
e91dcf8fb4
Fix discriminator resolution when using parameters
2017-06-24 13:35:44 +02:00
Alessandro Lai
d2f7514248
Put all tests classes in a single namespace
2017-06-24 10:58:18 +02:00
Alessandro Lai
167dfde00f
Apply additional fixes to the SqlWalker to fix tests
2017-06-24 10:58:18 +02:00
Alessandro Lai
5181eae8d6
Refactor a bit the SqlWalker modifications
2017-06-24 10:58:18 +02:00
Alessandro Lai
0e88f1b654
Split SqlWalker::walkInstanceOfExpression method
2017-06-24 10:58:18 +02:00
Sergio Santoro
7d98135084
[QUERY] "INSTANCE OF" now behaves correctly with subclasses
...
There was a bug in the "INSTANCE OF" operator as described in
https://groups.google.com/forum/#!topic/doctrine-user/B8raq8CNMgg
"INSTANCE OF" was not taking into account subclasses.
It was merely translating the class to its discriminator.
This is not correct since the class can have subtypes and those
are, indeed, still instance of the superclass.
Also, classes may not have a discriminator (e.g. abstract classes).
This commit also provides useful tests to avoid regression.
2017-06-24 10:58:18 +02:00
Marco Pivetta
5d98247178
Merge pull request #5756 from whyte624/master
...
s/__tostring()/__toString() in Expr\OrderBy
2017-06-24 04:12:55 +02:00
Marco Pivetta
b21cb3e2a0
#6325 adding IDE hints, type hints, replacing double quotes with single quotes
2017-06-21 08:16:24 +02:00
Tomasz Darmetko
633a442046
Add path expresion to QueryException::associationPathInverseSideNotSupported()
2017-06-21 08:12:04 +02:00
Marco Pivetta
a7dcdd8d48
Documenting thrown exception type, spacing #6162
2017-06-21 05:36:13 +02:00
SimonHeimberg
f5d4db7d9c
Report that FROM and JOIN do not support Subqueries
2017-06-21 05:31:25 +02:00
Mathew Davies
747c1857d6
Make the new aggregate function definitions final.
2017-06-20 07:27:32 +02:00
Mathew Davies
3e3751cfd9
Remove aggregate function conditional in SqlWalker.
2017-06-20 07:27:27 +02:00
Mathew Davies
966f9a84c2
phpDoc and type hint changes.
2017-06-20 07:27:26 +02:00
Mathew Davies
866418e40f
No longer treat aggregate functions as a special case.
2017-06-20 07:27:24 +02:00
Mathew Davies
e4ff7a35a8
Write a test case for a custom function override.
2017-06-20 07:27:22 +02:00
Mathew Davies
914c400a7d
Check for custom functions first.
2017-06-20 07:27:20 +02:00
Artem Stepin
43009682a4
minor code work:
...
- method calls with incorrect case
- removed unused imports
- typos and some other minor code smells
- documentation update (wrong return types etc. )
2017-06-08 22:04:07 +02:00
Luís Cobucci
0aef63b350
Fix quoting also when using inheritance
2017-04-30 19:36:41 +02:00
lemartin
7c6c5d87c8
Fix quoting issues related to ticket #6402
...
Apply quoting strategy to foreign key columns of one-to-one relation so
that correct select statements are generated. And use unquoted column
names in result mapping instead of quoted ones, as consumers (namely
IdentifierFlattener) expect unquoted column names.
2017-04-30 13:51:49 +02:00
Vytautas Stankus
a557c97a93
Add support for STARTS_WITH and ENDS_WITH comparison operators
2017-04-30 13:19:51 +02:00
