RetailCRM-Mirror/doctrine2
1
0
Fork 0
mirror of synced 2025-03-06 12:56:10 +03:00
Code Issues Projects Releases Wiki Activity

Refactor a bit the SqlWalker modifications

Browse Source
This commit is contained in:
Alessandro Lai 2017-06-21 09:34:16 +02:00 committed by Sergio Santoro
parent 31d2d84160
commit 5181eae8d6
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/Doctrine/ORM/Query/SqlWalker.php
View File

@ -2277,7 +2277,6 @@ class SqlWalker implements TreeWalker
*/
private function getChildDiscriminatorsFromClassMetadata(ClassMetadataInfo $discrClass, AST\InstanceOfExpression $instanceOfExpr)
{
$knownSubclasses = array_flip($discrClass->subClasses);
$sqlParameterList = [];
$discriminators = [];
foreach ($instanceOfExpr->value as $parameter) {
@ -2289,15 +2288,13 @@ class SqlWalker implements TreeWalker
continue;
}
// Trim first backslash
$parameter = ltrim($parameter, '\\');
$metadata = $this->em->getClassMetadata($parameter);
if ($parameter !== $discrClass->name && ! array_key_exists($parameter, $knownSubclasses)) {
if ($metadata->getReflectionClass()->isSubclassOf($discrClass->name)) {
throw QueryException::instanceOfUnrelatedClass($parameter, $discrClass->name);
}
// Include discriminators for parameter class and its subclass
$metadata = $this->em->getClassMetadata($parameter);
$hierarchyClasses = $metadata->subClasses;
$hierarchyClasses[] = $metadata->name;
@ -2305,15 +2302,13 @@ class SqlWalker implements TreeWalker
$currentMetadata = $this->em->getClassMetadata($class);
$currentDiscriminator = $currentMetadata->discriminatorValue;
if (is_string($currentDiscriminator) && ! array_key_exists($currentDiscriminator, $discriminators)) {
$discriminators[$currentDiscriminator] = true;
if (null !== $currentDiscriminator && ! array_key_exists($currentDiscriminator, $discriminators)) {
$discriminators[$currentDiscriminator] = null;
}
}
}
foreach (array_keys($discriminators) as $dis) {
$sqlParameterList[] = $this->conn->quote($dis);
}
$sqlParameterList = array_map([$this->conn, 'quote'], array_keys($discriminators));
return '(' . implode(', ', $sqlParameterList) . ')';
}