Marco Pivetta
2b47670831
Merge pull request #5931 from bitwombat/tutorial_fix
...
Clarify language regarding ArrayCollections.
2016-07-12 08:08:26 +02:00
Greg Bell
da43aa2d49
Clarify language regarding ArrayCollections.
...
See https://groups.google.com/forum/#!topic/doctrine-user/yJ8ABqBP5mI
2016-07-12 16:05:20 +10:00
Marco Pivetta
44feacd327
Corrected SLC test expected query count: since the identity map is now consistently hashing identifiers
2016-07-07 23:46:09 +02:00
Steve Müller
355d2c3d19
Merge pull request #5924 from doctrine/fix/allow-empty-identifier-string-as-proxy-identifier
...
Allow empty string identifiers
2016-07-07 23:11:54 +02:00
Marco Pivetta
d330da898f
Correcting order of deletes: cache_token
relies on cache_complex_action
2016-07-07 22:24:37 +02:00
Marco Pivetta
5d12593e70
Rewrote ManyToOne
SLC tests to not rely on multi-level auto-generated identifiers
...
Background:
Test relied on an `A->B->C` association:
* `A#id` being `B`
* `B#id` being `C`
* `C#id` being an auto-generated identifier (post-insert)
This cannot work, because it breaks the UnitOfWork's identity map.
Specifically, no entries for `A` and `B` can exist in the identity map until `C` entries
are persisted (post-insert).
That means that the identifier generator for `A` and `B` should not be an "assigned"
generator, but should instead be a post-insert generator waiting for other entities
to be persisted.
We cannot fix this in ORM 2.x, but we'll need to invent something for 3.x in order to
fix that (directed graph, or caching the order of operations in the metadata graph).
2016-07-07 21:29:10 +02:00
Marco Pivetta
dbcdc1d42a
Empty identifiers must be disallowed
2016-07-07 20:57:49 +02:00
Marco Pivetta
0d82128b2e
Registering a managed entity with an empty identifier is to be disallowed
2016-07-07 20:57:02 +02:00
Marco Pivetta
7544934158
Removing note that is not valid anymore
2016-07-07 20:39:52 +02:00
Marco Pivetta
1cb8d790b6
Disallowing null
as part of the entity identifier
2016-07-07 20:29:00 +02:00
Marco Pivetta
2829174267
Simplified test: invalid entities must make it in the UnitOfWork
manually, via registerManaged
2016-07-07 20:28:21 +02:00
Marco Pivetta
5b8b548bd4
When invalid (null) identifiers are provided, an exception should be thrown
2016-07-07 20:08:24 +02:00
Marco Pivetta
9abccba109
When invalid (null) identifiers are provided, an exception should be thrown
2016-07-07 19:58:43 +02:00
Marco Pivetta
da7582d329
Typo fix: s/$booleanTrue/$booleanFalse (C&P mistake)
2016-07-07 19:43:03 +02:00
Marco Pivetta
aa1fda6d5f
Checking for boolean true/false identifiers
2016-07-07 19:38:48 +02:00
Marco Pivetta
29d9f344e8
Non-empty composite key identifiers should also be supported
2016-07-07 19:35:39 +02:00
Marco Pivetta
549bfe127c
Correcting test case: expecting identifier hashes to support empty strings
2016-07-07 19:34:24 +02:00
Marco Pivetta
12789ee6ca
Basic tests around addToIdentityMap
with valid string identifiers (empty string allowed)
2016-07-07 19:27:49 +02:00
Marco Pivetta
5761d07c46
Merge pull request #5918 from tonynelson19/master
...
Make setSQL and setDQL function calls case-sensitive.
2016-07-05 19:50:59 +02:00
Tony Nelson
cd36407f28
Update EntityManager.php
2016-07-05 12:48:00 -05:00
Tony Nelson
1880cbd8b6
Update dql-doctrine-query-language.rst
2016-07-05 12:46:16 -05:00
Marco Pivetta
27e9b49215
Merge pull request #5911 from ReenExeContributor/scrutinizer-clear-code
...
Scrutinizer clear code
2016-07-05 18:21:08 +02:00
ReenExe
bcc7983934
after review
2016-07-05 19:15:47 +03:00
Marco Pivetta
ab4b761110
Merge pull request #5913 from ReenExeContributor/clear-code-metadata-info
...
Clear code metadata info
2016-07-05 18:09:18 +02:00
ReenExe
f7c16ab364
remove else
2016-07-03 00:21:00 +03:00
ReenExe
99b1eaaabb
clear code - double condition after isset
2016-07-03 00:17:51 +03:00
ReenExe
1dba0b8545
clear code
2016-07-03 00:14:33 +03:00
ReenExe
0e8491a474
clear code
2016-07-03 00:11:44 +03:00
ReenExe
511b27517a
refactoring: extract method
2016-07-03 00:10:43 +03:00
ReenExe
a81458a0aa
1. merge conditions
...
2. convert `if` to `condition`
2016-07-03 00:05:31 +03:00
ReenExe
b108a2af52
merge conditions
2016-07-03 00:01:07 +03:00
ReenExe
f7317d700c
logical remove double condition
2016-07-02 23:58:29 +03:00
ReenExe
2301fb3ff2
move common cascades
2016-07-02 23:53:23 +03:00
ReenExe
eccec87796
clear code
2016-07-02 23:47:21 +03:00
ReenExe
c0fc4f1158
use internal function
2016-07-02 23:02:13 +03:00
ReenExe
52b2d9022a
use ternary
2016-07-02 23:00:40 +03:00
ReenExe
a7c4ca82fd
use ternary
2016-07-02 22:59:16 +03:00
ReenExe
6bf6bae219
clear code
2016-07-02 22:51:44 +03:00
ReenExe
c6675b0ce3
use ternary
2016-07-02 22:42:46 +03:00
ReenExe
db6c593463
clear code
2016-07-02 22:37:12 +03:00
ReenExe
347d1625bc
merge conditions
2016-07-02 22:33:23 +03:00
ReenExe
16cddd4693
claar code from Scrutinizer
2016-07-02 22:13:06 +03:00
Marco Pivetta
ffd1465af2
Merge pull request #5910 from ReenExeContributor/clear-code
...
Code cleanups: early return/internal function usage
2016-07-01 01:05:16 +02:00
ReenExe
8eef0beacb
clear code
2016-07-01 01:20:52 +03:00
ReenExe
015ec444c5
use PHP common functions
2016-07-01 01:17:25 +03:00
Marco Pivetta
32ea9112fa
Merge pull request #5898 from radmax/patch-1
...
Typo
2016-06-30 15:08:18 +02:00
Marco Pivetta
b55ef58025
Merge pull request #5902 from holtkamp/patch-1
...
Fixed typo (serves => servers)
2016-06-26 09:15:21 +02:00
Menno Holtkamp
a3e9529c02
Fixed typo (serves => servers)
2016-06-25 17:29:04 +02:00
radmax
2ab752bfc3
typo
2016-06-22 17:06:16 +02:00
Marco Pivetta
04b48ae12b
Merge pull request #5892 from BreiteSeite/5882-documentation
...
#5882 recommend using latest stable PHP version in the getting started guide
2016-06-20 22:10:15 +02:00