1
0
mirror of synced 2025-03-11 07:16:05 +03:00

Merge pull request #5910 from ReenExeContributor/clear-code

Code cleanups: early return/internal function usage
This commit is contained in:
Marco Pivetta 2016-07-01 01:05:16 +02:00 committed by GitHub
commit ffd1465af2
2 changed files with 3 additions and 10 deletions

View File

@ -583,10 +583,7 @@ class ObjectHydrator extends AbstractHydrator
parent::onClear($eventArgs);
$aliases = array_keys($this->identifierMap);
$this->identifierMap = array();
foreach ($aliases as $alias) {
$this->identifierMap[$alias] = array();
}
$this->identifierMap = array_fill_keys($aliases, []);
}
}

View File

@ -827,17 +827,13 @@ class Parser
return;
}
$foundRootEntity = false;
foreach ($this->identVariableExpressions as $dqlAlias => $expr) {
if (isset($this->queryComponents[$dqlAlias]) && $this->queryComponents[$dqlAlias]['parent'] === null) {
$foundRootEntity = true;
return;
}
}
if ( ! $foundRootEntity) {
$this->semanticalError('Cannot select entity through identification variables without choosing at least one root entity alias.');
}
$this->semanticalError('Cannot select entity through identification variables without choosing at least one root entity alias.');
}
/**