Merge branch 'cleanup/#5914-cleanup-sql-walker-code'

Close #5914

lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php

@@ -463,7 +463,7 @@ class ClassMetadataInfo implements ClassMetadata
     /**
      * READ-ONLY: The registered lifecycle callbacks for entities of this class.
      *
-     * @var array
+     * @var array[]
      */
     public $lifecycleCallbacks = array();
 

lib/Doctrine/ORM/Query.php

@@ -309,7 +309,9 @@ final class Query extends AbstractQuery
 
         if ($paramCount > $mappingCount) {
             throw QueryException::tooManyParameters($mappingCount, $paramCount);
-        } elseif ($paramCount < $mappingCount) {
+        }
+
+        if ($paramCount < $mappingCount) {
             throw QueryException::tooFewParameters($mappingCount, $paramCount);
         }
 

lib/Doctrine/ORM/Query/SqlWalker.php

@@ -501,7 +501,6 @@ class SqlWalker implements TreeWalker
             default:
                 //@todo: throw exception?
                 return '';
-                break;
         }
 
         $filterClauses = array();

lib/Doctrine/ORM/Tools/EntityGenerator.php

@@ -1259,21 +1259,19 @@ public function __construct(<params>)
      */
     protected function generateEntityLifecycleCallbackMethods(ClassMetadataInfo $metadata)
     {
-        if (isset($metadata->lifecycleCallbacks) && $metadata->lifecycleCallbacks) {
+        if (empty($metadata->lifecycleCallbacks)) {
-            $methods = array();
+            return '';
-
-            foreach ($metadata->lifecycleCallbacks as $name => $callbacks) {
-                foreach ($callbacks as $callback) {
-                    if ($code = $this->generateLifecycleCallbackMethod($name, $callback, $metadata)) {
-                        $methods[] = $code;
-                    }
-                }
-            }
-
-            return implode("\n\n", $methods);
         }
 
-        return "";
+        $methods = [];
+
+        foreach ($metadata->lifecycleCallbacks as $name => $callbacks) {
+            foreach ($callbacks as $callback) {
+                $methods[] = $this->generateLifecycleCallbackMethod($name, $callback, $metadata);
+            }
+        }
+
+        return implode("\n\n", array_filter($methods));
     }
 
     /**