diff --git a/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php b/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php index 8fa11f360..3058a2eda 100644 --- a/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php +++ b/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php @@ -463,7 +463,7 @@ class ClassMetadataInfo implements ClassMetadata /** * READ-ONLY: The registered lifecycle callbacks for entities of this class. * - * @var array + * @var array[] */ public $lifecycleCallbacks = array(); diff --git a/lib/Doctrine/ORM/Query.php b/lib/Doctrine/ORM/Query.php index e3f23cc6b..6a8a50ae0 100644 --- a/lib/Doctrine/ORM/Query.php +++ b/lib/Doctrine/ORM/Query.php @@ -309,7 +309,9 @@ final class Query extends AbstractQuery if ($paramCount > $mappingCount) { throw QueryException::tooManyParameters($mappingCount, $paramCount); - } elseif ($paramCount < $mappingCount) { + } + + if ($paramCount < $mappingCount) { throw QueryException::tooFewParameters($mappingCount, $paramCount); } diff --git a/lib/Doctrine/ORM/Query/SqlWalker.php b/lib/Doctrine/ORM/Query/SqlWalker.php index 0aa4349a1..6e607ffa9 100644 --- a/lib/Doctrine/ORM/Query/SqlWalker.php +++ b/lib/Doctrine/ORM/Query/SqlWalker.php @@ -501,7 +501,6 @@ class SqlWalker implements TreeWalker default: //@todo: throw exception? return ''; - break; } $filterClauses = array(); diff --git a/lib/Doctrine/ORM/Tools/EntityGenerator.php b/lib/Doctrine/ORM/Tools/EntityGenerator.php index 3c0f9264f..22d5b412a 100644 --- a/lib/Doctrine/ORM/Tools/EntityGenerator.php +++ b/lib/Doctrine/ORM/Tools/EntityGenerator.php @@ -1259,21 +1259,19 @@ public function __construct() */ protected function generateEntityLifecycleCallbackMethods(ClassMetadataInfo $metadata) { - if (isset($metadata->lifecycleCallbacks) && $metadata->lifecycleCallbacks) { - $methods = array(); - - foreach ($metadata->lifecycleCallbacks as $name => $callbacks) { - foreach ($callbacks as $callback) { - if ($code = $this->generateLifecycleCallbackMethod($name, $callback, $metadata)) { - $methods[] = $code; - } - } - } - - return implode("\n\n", $methods); + if (empty($metadata->lifecycleCallbacks)) { + return ''; } - return ""; + $methods = []; + + foreach ($metadata->lifecycleCallbacks as $name => $callbacks) { + foreach ($callbacks as $callback) { + $methods[] = $this->generateLifecycleCallbackMethod($name, $callback, $metadata); + } + } + + return implode("\n\n", array_filter($methods)); } /**