1
0
mirror of synced 2024-11-21 21:06:07 +03:00

fix & add tests

This commit is contained in:
Pavel 2020-02-12 14:07:27 +03:00
parent 9bbf277d92
commit 8ebcdaeebc
2 changed files with 30 additions and 17 deletions

View File

@ -308,7 +308,7 @@ class ApiClientCustomersCorporateTest extends TestCase
{
$client = static::getApiClient();
$response = $client->request->customersCorporateAddresses($ids['externalId'], ['name' => 'name'], 1, 20);
static::assertInstanceOf('RetailCrm\Response\ApiResponse', $response);
static::assertTrue(
$response->isSuccessful(),

View File

@ -40,7 +40,7 @@ class ApiResponseTest extends TestCase
'Response object created'
);
$response = new ApiResponse(201, '{ "success": true }');
$response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
static::assertInstanceOf(
'RetailCrm\Response\ApiResponse',
$response,
@ -54,7 +54,20 @@ class ApiResponseTest extends TestCase
*/
public function testJsonInvalid()
{
new ApiResponse(400, '{ "asdf": }');
(new ApiResponse(400, '{ "asdf": }'))->asJsonResponse();
}
/**
* @group response
*/
public function testJsonInvalidNoDeserialize()
{
$response = new ApiResponse(400, '{ "asdf": }');
static::assertInstanceOf(
'RetailCrm\Response\ApiResponse',
$response,
'Response object created'
);
}
/**
@ -69,7 +82,7 @@ class ApiResponseTest extends TestCase
'Response object returns the right status code'
);
$response = new ApiResponse(460, '{ "success": false }');
$response = (new ApiResponse(460, '{ "success": false }'))->asJsonResponse();
static::assertEquals(
460,
$response->getStatusCode(),
@ -88,7 +101,7 @@ class ApiResponseTest extends TestCase
'Request was successful'
);
$response = new ApiResponse(460, '{ "success": false }');
$response = (new ApiResponse(460, '{ "success": false }'))->asJsonResponse();
static::assertFalse(
$response->isSuccessful(),
'Request was failed'
@ -100,7 +113,7 @@ class ApiResponseTest extends TestCase
*/
public function testMagicCall()
{
$response = new ApiResponse(201, '{ "success": true }');
$response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
static::assertEquals(
true,
$response->isSuccessful(),
@ -125,7 +138,7 @@ class ApiResponseTest extends TestCase
*/
public function testMagicCallException2()
{
$response = new ApiResponse(201, '{ "success": true }');
$response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
/* @noinspection PhpUndefinedMethodInspection */
$response->getSomeSuccess();
}
@ -135,7 +148,7 @@ class ApiResponseTest extends TestCase
*/
public function testMagicGet()
{
$response = new ApiResponse(201, '{ "success": true }');
$response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
static::assertEquals(
true,
$response->success,
@ -160,7 +173,7 @@ class ApiResponseTest extends TestCase
*/
public function testMagicGetException2()
{
$response = new ApiResponse(201, '{ "success": true }');
$response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
/* @noinspection PhpUndefinedFieldInspection */
$response->someSuccess;
}
@ -170,7 +183,7 @@ class ApiResponseTest extends TestCase
*/
public function testArrayGet()
{
$response = new ApiResponse(201, '{ "success": true }');
$response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
static::assertEquals(
true,
$response['success'],
@ -194,7 +207,7 @@ class ApiResponseTest extends TestCase
*/
public function testArrayGetException2()
{
$response = new ApiResponse(201, '{ "success": true }');
$response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
$response['someSuccess'];
}
@ -203,7 +216,7 @@ class ApiResponseTest extends TestCase
*/
public function testArrayIsset()
{
$response = new ApiResponse(201, '{ "success": true }');
$response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
static::assertTrue(
isset($response['success']),
@ -222,7 +235,7 @@ class ApiResponseTest extends TestCase
*/
public function testArraySetException1()
{
$response = new ApiResponse(201, '{ "success": true }');
$response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
$response['success'] = 'a';
}
@ -232,7 +245,7 @@ class ApiResponseTest extends TestCase
*/
public function testArraySetException2()
{
$response = new ApiResponse(201, '{ "success": true }');
$response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
$response['sssssssuccess'] = 'a';
}
@ -242,7 +255,7 @@ class ApiResponseTest extends TestCase
*/
public function testArrayUnsetException1()
{
$response = new ApiResponse(201, '{ "success": true }');
$response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
unset($response['success']);
}
@ -252,7 +265,7 @@ class ApiResponseTest extends TestCase
*/
public function testArrayUnsetException2()
{
$response = new ApiResponse(201, '{ "success": true }');
$response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
unset($response['sssssssuccess']);
}
@ -261,7 +274,7 @@ class ApiResponseTest extends TestCase
*/
public function testMagicIsset()
{
$response = new ApiResponse(201, '{ "success": true }');
$response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
static::assertTrue(
isset($response->success),