From 8ebcdaeebc3111b8989e17caf1d4dd2d2392960a Mon Sep 17 00:00:00 2001
From: Pavel <pashok9825@gmail.com>
Date: Wed, 12 Feb 2020 14:07:27 +0300
Subject: [PATCH] fix & add tests

---
 .../ApiClientCustomersCorporateTest.php       |  2 +-
 .../Tests/Response/ApiResponseTest.php        | 45 ++++++++++++-------
 2 files changed, 30 insertions(+), 17 deletions(-)

diff --git a/tests/RetailCrm/Tests/Methods/Version5/ApiClientCustomersCorporateTest.php b/tests/RetailCrm/Tests/Methods/Version5/ApiClientCustomersCorporateTest.php
index 0587fd7..26bf263 100644
--- a/tests/RetailCrm/Tests/Methods/Version5/ApiClientCustomersCorporateTest.php
+++ b/tests/RetailCrm/Tests/Methods/Version5/ApiClientCustomersCorporateTest.php
@@ -308,7 +308,7 @@ class ApiClientCustomersCorporateTest extends TestCase
     {
         $client = static::getApiClient();
         $response = $client->request->customersCorporateAddresses($ids['externalId'], ['name' => 'name'], 1, 20);
-
+        
         static::assertInstanceOf('RetailCrm\Response\ApiResponse', $response);
         static::assertTrue(
             $response->isSuccessful(),
diff --git a/tests/RetailCrm/Tests/Response/ApiResponseTest.php b/tests/RetailCrm/Tests/Response/ApiResponseTest.php
index d4709bd..8a414f6 100644
--- a/tests/RetailCrm/Tests/Response/ApiResponseTest.php
+++ b/tests/RetailCrm/Tests/Response/ApiResponseTest.php
@@ -40,7 +40,7 @@ class ApiResponseTest extends TestCase
             'Response object created'
         );
 
-        $response = new ApiResponse(201, '{ "success": true }');
+        $response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
         static::assertInstanceOf(
             'RetailCrm\Response\ApiResponse',
             $response,
@@ -54,7 +54,20 @@ class ApiResponseTest extends TestCase
      */
     public function testJsonInvalid()
     {
-        new ApiResponse(400, '{ "asdf": }');
+        (new ApiResponse(400, '{ "asdf": }'))->asJsonResponse();
+    }
+
+    /**
+     * @group response
+     */
+    public function testJsonInvalidNoDeserialize()
+    {
+        $response = new ApiResponse(400, '{ "asdf": }');
+        static::assertInstanceOf(
+            'RetailCrm\Response\ApiResponse',
+            $response,
+            'Response object created'
+        );
     }
 
     /**
@@ -69,7 +82,7 @@ class ApiResponseTest extends TestCase
             'Response object returns the right status code'
         );
 
-        $response = new ApiResponse(460, '{ "success": false }');
+        $response = (new ApiResponse(460, '{ "success": false }'))->asJsonResponse();
         static::assertEquals(
             460,
             $response->getStatusCode(),
@@ -88,7 +101,7 @@ class ApiResponseTest extends TestCase
             'Request was successful'
         );
 
-        $response = new ApiResponse(460, '{ "success": false }');
+        $response = (new ApiResponse(460, '{ "success": false }'))->asJsonResponse();
         static::assertFalse(
             $response->isSuccessful(),
             'Request was failed'
@@ -100,7 +113,7 @@ class ApiResponseTest extends TestCase
      */
     public function testMagicCall()
     {
-        $response = new ApiResponse(201, '{ "success": true }');
+        $response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
         static::assertEquals(
             true,
             $response->isSuccessful(),
@@ -125,7 +138,7 @@ class ApiResponseTest extends TestCase
      */
     public function testMagicCallException2()
     {
-        $response = new ApiResponse(201, '{ "success": true }');
+        $response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
         /* @noinspection PhpUndefinedMethodInspection */
         $response->getSomeSuccess();
     }
@@ -135,7 +148,7 @@ class ApiResponseTest extends TestCase
      */
     public function testMagicGet()
     {
-        $response = new ApiResponse(201, '{ "success": true }');
+        $response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
         static::assertEquals(
             true,
             $response->success,
@@ -160,7 +173,7 @@ class ApiResponseTest extends TestCase
      */
     public function testMagicGetException2()
     {
-        $response = new ApiResponse(201, '{ "success": true }');
+        $response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
         /* @noinspection PhpUndefinedFieldInspection */
         $response->someSuccess;
     }
@@ -170,7 +183,7 @@ class ApiResponseTest extends TestCase
      */
     public function testArrayGet()
     {
-        $response = new ApiResponse(201, '{ "success": true }');
+        $response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
         static::assertEquals(
             true,
             $response['success'],
@@ -194,7 +207,7 @@ class ApiResponseTest extends TestCase
      */
     public function testArrayGetException2()
     {
-        $response = new ApiResponse(201, '{ "success": true }');
+        $response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
         $response['someSuccess'];
     }
 
@@ -203,7 +216,7 @@ class ApiResponseTest extends TestCase
      */
     public function testArrayIsset()
     {
-        $response = new ApiResponse(201, '{ "success": true }');
+        $response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
 
         static::assertTrue(
             isset($response['success']),
@@ -222,7 +235,7 @@ class ApiResponseTest extends TestCase
      */
     public function testArraySetException1()
     {
-        $response = new ApiResponse(201, '{ "success": true }');
+        $response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
         $response['success'] = 'a';
     }
 
@@ -232,7 +245,7 @@ class ApiResponseTest extends TestCase
      */
     public function testArraySetException2()
     {
-        $response = new ApiResponse(201, '{ "success": true }');
+        $response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
         $response['sssssssuccess'] = 'a';
     }
 
@@ -242,7 +255,7 @@ class ApiResponseTest extends TestCase
      */
     public function testArrayUnsetException1()
     {
-        $response = new ApiResponse(201, '{ "success": true }');
+        $response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
         unset($response['success']);
     }
 
@@ -252,7 +265,7 @@ class ApiResponseTest extends TestCase
      */
     public function testArrayUnsetException2()
     {
-        $response = new ApiResponse(201, '{ "success": true }');
+        $response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
         unset($response['sssssssuccess']);
     }
 
@@ -261,7 +274,7 @@ class ApiResponseTest extends TestCase
      */
     public function testMagicIsset()
     {
-        $response = new ApiResponse(201, '{ "success": true }');
+        $response = (new ApiResponse(201, '{ "success": true }'))->asJsonResponse();
 
         static::assertTrue(
             isset($response->success),