lat9nq
1e093767a8
common,configure_system: Rename method to GetCategory
...
Fixes essentially a shadowing issue.
2023-07-21 10:56:55 -04:00
lat9nq
267f3c7905
settings: Cleanup
...
Addresses review feedback
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
2023-07-21 10:56:55 -04:00
lat9nq
35872ad95b
shared_translation: Update memory layout mode strings
2023-07-21 10:56:55 -04:00
lat9nq
127b3da0f1
core,common: Give memory layout setting an enum
...
Allows for 6GB and 8GB layouts to be selected.
2023-07-21 10:56:55 -04:00
lat9nq
ff6a5031d5
settings: Require time zone setting value for stirng
2023-07-21 10:56:55 -04:00
lat9nq
07e8477f5a
shared_translation: Add missing time zones
2023-07-21 10:56:55 -04:00
lat9nq
ef6406a666
shared_translation: Add controller_applet_disabled
2023-07-21 10:56:55 -04:00
lat9nq
a14d2a6f83
shared_translation: Add barrier_feedback_loops
2023-07-21 10:56:55 -04:00
toast2903
c1717b3f47
cmake: Reposition preprocessor switch comment
...
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
2023-07-21 10:56:55 -04:00
lat9nq
ca8509d205
configuration: Use enum index
2023-07-21 10:56:55 -04:00
lat9nq
e7f01128f1
settings: Give indices to enums
2023-07-21 10:56:55 -04:00
lat9nq
ecc1feff64
cmake: Use standard preprocessor on MSVC
2023-07-21 10:56:55 -04:00
lat9nq
52cc7b438b
settings_common: Remove unncessary enum spec
2023-07-21 10:56:55 -04:00
lat9nq
9186f08c3c
shared_translation: Deobfuscate auto time zone
2023-07-21 10:56:55 -04:00
lat9nq
8497fb0a04
settings_enums: Remove casting
...
Not sure how I missed this earlier, but these vectors can be constructed
using the type of the enum.
2023-07-21 10:56:55 -04:00
lat9nq
54d58130a0
settings_setting: Silence shadowing warnings
2023-07-21 10:56:55 -04:00
lat9nq
926f3e3d3e
settings,configuration: Add a default suffix
2023-07-21 10:56:55 -04:00
lat9nq
9de50d6194
configuration: Use paired settings
2023-07-21 10:56:55 -04:00
lat9nq
7f708e8d77
settings: Define paired settings
...
settings_common: Remove unused optional
2023-07-21 10:56:55 -04:00
lat9nq
d1de1c3bed
shared_widget: Internalize component restoring
2023-07-21 10:56:55 -04:00
lat9nq
21723879e7
configuration: Use specialization of settings
...
Reduces some ugliness in frontend code.
2023-07-21 10:56:55 -04:00
lat9nq
b2438f1fb7
settings: Define specializations for settings
...
Suggests to a frontend how to represent each setting.
2023-07-21 10:56:55 -04:00
lat9nq
ad645c29a4
configuration: Use a builder to create widgets
...
This gets rid of some repeated code and sets us up to send more
information to the new widget.
2023-07-21 10:56:55 -04:00
lat9nq
62ffaa730f
shared_translation: Fix context usage
...
Currently unused, but I don't want to start headaches when someone
decides to use it the first time.
2023-07-21 10:56:55 -04:00
lat9nq
8b28aa45b9
settings,translation: Fix time zone enum
...
Renames enum values to conform to naming convention.
2023-07-21 10:56:55 -04:00
lat9nq
8366736b67
settings,opengl,yuzu-qt: Fix AA, Filter maximums
...
The new enum macros don't support setting values directly.
For LastAA and LastFilter, this means we need a simpler approach to loop
around the toggle in the frontend...
2023-07-21 10:56:55 -04:00
lat9nq
7ffbffe170
settings_enums: More aggressively use macros
...
This lets us define an enum and all the textual representations
of its values in one swing. All for the price of some ugly macros.
2023-07-21 10:56:55 -04:00
lat9nq
02c48a80f6
config_shared: Remove storing the group from tab
2023-07-21 10:56:55 -04:00
lat9nq
fdbeb84168
settings,uisettings: Remove leading underscore
2023-07-21 10:56:55 -04:00
lat9nq
81a96bafe2
configuration: Move speed_limit to core
2023-07-21 10:56:55 -04:00
lat9nq
3a7705e774
settings: Move speed_limit to core
2023-07-21 10:56:55 -04:00
lat9nq
69bc8ea148
android-config: Update enum labels
2023-07-21 10:56:55 -04:00
lat9nq
3f0cc544cf
common,yuzu-qt: Avoid explicit instantiation on old clang
...
Clang versions < 15 have compile issues with explicit instantiation.
Disable it for these versions.
2023-07-21 10:56:55 -04:00
lat9nq
c97cbd089b
settings_setting: Fix MSVC error
2023-07-21 10:56:55 -04:00
lat9nq
89f89cf1df
shared_widget: Correct spelling
2023-07-21 10:56:55 -04:00
lat9nq
ab795fe0e2
(android)config: Clang format
2023-07-21 10:56:55 -04:00
lat9nq
ee32b17782
common,yuzu-qt: GCC warning silences
...
Fixes -Wshadow, -Wdeprecated, and catch by copy rather than by ref.
2023-07-21 10:56:55 -04:00
lat9nq
916c6cd1a0
configure_graphics: Simplify UpdateAPILayout
...
Reduces branching/swictch cases for simplicity/code size
2023-07-21 10:56:54 -04:00
lat9nq
57a00e01d6
configure_graphcs: Fix setting shader/device in custom config
2023-07-21 10:56:54 -04:00
lat9nq
a7ee9d999f
configuration: Use shorter constructor as needed
...
Reduces some confusion hopefully, since some parameters specified were not
specific to the setting in question.
2023-07-21 10:56:54 -04:00
lat9nq
6935332cba
shared_widget: Some documentation, add shorter constructor
...
The shorter constructor enables us to specify some options without needing to
specify the default values of multiplier which wasn't always appropriate and
could be confusing.
2023-07-21 10:56:54 -04:00
lat9nq
3240d199a2
config: Remove unused functions
2023-07-21 10:56:54 -04:00
lat9nq
a0883526d6
settings: Delete cpu_accuracy_first_time
...
Almost a 2 year old migration setting now
2023-07-21 10:56:54 -04:00
lat9nq
7c52bb2772
shared_widget: Improve logging, use Setting::Ranged
2023-07-21 10:56:54 -04:00
lat9nq
27e53990ed
settings: Document BasicSetting, add Ranged
2023-07-21 10:56:54 -04:00
lat9nq
b4f2ad3ff5
settings: Move IsConfiguringGlobal to settings_common
2023-07-21 10:56:54 -04:00
lat9nq
3b0650b70d
configuration/shared: Clean up includes [IWYU]
2023-07-21 10:56:54 -04:00
lat9nq
512fb3abff
configure_graphics: Fix vulkan_device bug
2023-07-21 10:56:54 -04:00
lat9nq
11e7e1b8ce
settings: Move some simple data to BasicSetting
...
Reduces the need for the compiler to duplicate this code, by about
100KB executable size.
2023-07-21 10:56:54 -04:00
lat9nq
4903f40efe
settings_setting: Fix errors
...
ToString didn't have a constexpr if statement where needed.
Canonicalize missed an else, causing unreachable code error on MSVC.
2023-07-21 10:56:54 -04:00
lat9nq
04d4b6ab80
(ui,)settings: Use explicit instantiation
...
Reduces compile times a tad on clang.
2023-07-21 10:56:54 -04:00
lat9nq
02265f19d9
settings: Remove redundant false literals
2023-07-21 10:56:54 -04:00
lat9nq
7515c502c5
shared_widget: Avoid calling QWidgetPrivate::setVisible
...
This particular setVisible function is unnecessary.
It also has horrible runtime performance, so much that it consumed maybe
80% of the time used to create a widget.
2023-07-21 10:56:54 -04:00
lat9nq
79024bb955
FIXME configuration: Avoid unnecessary allocations
...
ConfigurationShared::Widget needs to be created with a builder. This
would avoid some duplicated code.
2023-07-21 10:56:54 -04:00
lat9nq
c5f8b909ec
shared_widget: Add SPDX header
2023-07-21 10:56:54 -04:00
lat9nq
0193add060
general: Add typeinfo where needed
...
Using typeid without including typeinfo first produces an ill-formed program.
2023-07-21 10:56:54 -04:00
lat9nq
2fba913d0b
settings_enums: Add const type where needed
2023-07-21 10:56:54 -04:00
lat9nq
fe6e765b2d
shared_widget: Use actionTriggered for user input signals
...
Clicking the slider without directly interacting with the slider handle would
change the value, but not trigger the restore button.
2023-07-21 10:56:54 -04:00
lat9nq
47d870b11f
shared_translation: Populate combobox enums with macro
2023-07-21 10:56:54 -04:00
lat9nq
b86171d2b5
settings: yuzu is not capitalized why is it capitalized stop no bad
2023-07-21 10:56:54 -04:00
lat9nq
81e9cf0934
configuration: Document odd widget cases
...
Explain why we need to do things differently at times, to serve as a
reference.
2023-07-21 10:56:54 -04:00
lat9nq
163f229d26
settings: Reorder
...
Groups graphics audio and system settings together in a way that
reflects the frontend. This also just conceptually groups them more
nicely than they were.
2023-07-21 10:56:54 -04:00
lat9nq
681ebcf4a5
shared_translation: Add translation for use video framrate
2023-07-21 10:56:54 -04:00
lat9nq
78b2709373
settings: Report all contained settings values
...
Also adds a couple characters that denotes the state of the setting.
M for modified, or not default.
C for custom, in context of per-game settings.
2023-07-21 10:56:54 -04:00
lat9nq
8c17a945f7
settings_enums: Cannonicalize settings names
...
Gives every option of the enums a string literal via a macro.
2023-07-21 10:56:54 -04:00
lat9nq
d146dd9d12
settings,general: Rename non-confirming enums
2023-07-21 10:56:54 -04:00
lat9nq
9e3c94bb3d
configuration: Use IDs to sort holds
2023-07-21 10:56:07 -04:00
lat9nq
f7948b7b64
settings,general: Rename/reorder setting ids
2023-07-21 10:56:07 -04:00
lat9nq
25cea2ef27
shared_widget: Fix includes
2023-07-21 10:56:07 -04:00
lat9nq
9a2a92673c
shared_widget: Complete refactoring
...
Reduces code bloat a good bit by moving code specific to each sub widget
to their own functions.
2023-07-21 10:56:07 -04:00
lat9nq
d7dd023409
shared_widget: Refactor again
...
Starting with combobox
Putting code specific to the sub-widget in their own function.
2023-07-21 10:56:07 -04:00
lat9nq
d373cc3d3f
android-config: Adapt settings rework
2023-07-21 10:56:07 -04:00
lat9nq
e6d65bf61c
c_per_game: Inform when settings might not be configurable
2023-07-21 10:56:07 -04:00
lat9nq
cd1d8adc49
shared_translation: Fix pragma once
2023-07-21 10:56:07 -04:00
lat9nq
09f61656e3
shared_translation: Add translation for AstcRecompression
2023-07-21 10:56:07 -04:00
lat9nq
81860b4317
configure_system: Hide locale warn at start
2023-07-21 10:56:07 -04:00
lat9nq
b570b719de
shared_widget: Force min width of 100 for restore button
...
Dark theme mandates a 100px minimum width for QAbstractButton, even
though this is not desired here.
2023-07-21 10:56:07 -04:00
lat9nq
3d932416e3
configuration: Workaround for Windows Qt bug
...
Odd issue happens that dragging the cpu or system tabs in custom configs
would cause the window to take up the entire verticle space of the
screen.
2023-07-21 10:56:07 -04:00
lat9nq
7734127f9e
shared_translation: Add missing tooltips
2023-07-21 10:56:07 -04:00
lat9nq
3281ea935f
settings: Make volume runtime-configurable
2023-07-21 10:56:07 -04:00
lat9nq
217fa04080
configuration: Clean up includes a bit
2023-07-21 10:56:07 -04:00
lat9nq
3337250746
configuration_shared: Remove old custom config setup functions
2023-07-21 10:56:07 -04:00
lat9nq
daa31121ee
configure_cpu: Generate UI
2023-07-21 10:56:07 -04:00
lat9nq
c5a3642cb6
configuration: Use a mapping of setting value to name
...
Makes comboboxes always correspond to the value of the setting they're
modifying.
2023-07-21 10:56:07 -04:00
lat9nq
86ed82cdde
settings, shared_widget: typo fixes
2023-07-21 10:56:07 -04:00
lat9nq
432f68ad29
configure_audio: Implement ui generation
...
Needs a considerable amount of management specific to some of
the comoboboxes due to the audio engine configuration.
general: Partial audio config implmentation
configure_audio: Implement ui generation
Needs a considerable amount of management specific to some of
the comoboboxes due to the audio engine configuration.
general: Partial audio config implmentation
settings: Make audio settings as enums
2023-07-21 10:56:07 -04:00
lat9nq
88d3de4e85
settings: Split enums to new file
2023-07-21 10:56:07 -04:00
lat9nq
f055f2dcf4
shared_widget: Use a better icon
...
This one looks more relevant on Windows.
2023-07-21 10:56:07 -04:00
lat9nq
4ff8255e4a
shared_widget: Refactor helpers
...
Makes checkbox creation an option as opposed to a label.
2023-07-21 10:56:07 -04:00
lat9nq
4c4bc134a9
settings, uisettings: Initialize linkage counter
2023-07-21 10:56:07 -04:00
lat9nq
8e15146026
configure_system: Implement with for loop
2023-07-21 10:56:07 -04:00
lat9nq
56960bf9f8
per_game: Remove general tab
...
It's empty.
2023-07-21 10:56:07 -04:00
lat9nq
b11a2a206f
shared_widget: Internalize extra setting configuration
2023-07-21 10:56:07 -04:00
lat9nq
cdb5dea269
settings: Move runtime and save to parameters
...
These don't need to be whole new types.
2023-07-21 10:56:07 -04:00
lat9nq
df2bd251fa
graphics: Set speed limit to spinbox
2023-07-21 10:56:07 -04:00
lat9nq
97674bc888
shared_widget: Support checkbox + spinbox
2023-07-21 10:56:07 -04:00
lat9nq
def00e8c55
configure_debug: Reorganize
2023-07-21 10:56:07 -04:00
lat9nq
23f874ae60
configure_graphics: Reimplement bg_color
...
To specialized a setting to be worth adding to the shared_widget imo,
so add it roughly like before.
2023-07-21 10:56:07 -04:00
lat9nq
c1748b229a
shared_widget: Make button creation static
2023-07-21 10:56:07 -04:00
lat9nq
8c03ae793e
configure_general: Hide reset button in custom configs
2023-07-21 10:56:07 -04:00
lat9nq
e2de48f14b
configure_general: Sort data
2023-07-21 10:56:07 -04:00
lat9nq
827082c5ac
configure_general: Generate UI using containers
...
This leaves per-game config's General tab empty?
2023-07-21 10:56:07 -04:00
lat9nq
c530532de7
shared_translation: Add UI widget translations
2023-07-21 10:56:07 -04:00
lat9nq
d3d9c3568e
shared_widget: Fix header
2023-07-21 10:56:07 -04:00
lat9nq
464aad52cd
settings: Add UiGeneral class
2023-07-21 10:56:07 -04:00
lat9nq
ea4afbfc54
config: Don't merge the maps
...
Me shooting myself in the foot 3 days in advance.
2023-07-21 10:56:07 -04:00
lat9nq
640e7db60e
configure_graphics: Remove redundant log
2023-07-21 10:56:07 -04:00
lat9nq
f66d617107
configuration: Move CreateWidget to a class
...
We were passing so many objects between the function and the caller that
it needed to be redesigned.
2023-07-21 10:56:07 -04:00
lat9nq
d35577d3ed
configuration: Implement slider
2023-07-21 10:56:07 -04:00
lat9nq
39a1ffbb91
configuration: Use buttons instead of highlights
...
Only for updated configs at the moment
2023-07-21 10:56:07 -04:00
lat9nq
d72ff01726
shared_translations: Re flow strings
2023-07-21 10:56:07 -04:00
lat9nq
9a844bbf0c
configure_graphics: More complete reimplementation
2023-07-21 10:56:07 -04:00
lat9nq
3a7a5edcea
settings: Define base renderer runtime modifiable settings
2023-07-21 10:56:07 -04:00
lat9nq
05c26411a3
configuration_shared: Fix blank state hiding check box
2023-07-21 10:56:07 -04:00
lat9nq
a4de202cbd
settings: Add anisotropy mode enum
2023-07-21 10:56:07 -04:00
lat9nq
cfb63c68db
shared_translation: Finish using int ids
2023-07-21 10:56:07 -04:00
lat9nq
bafd569b47
settings,uisettings: Add IDs to settings
2023-07-21 10:56:07 -04:00
lat9nq
f8435d676f
configure_graphics: Partial runtime implementation
2023-07-21 10:56:07 -04:00
lat9nq
75d7e40113
settings: Recategorize a bit
...
Will help with generating config UI later.
2023-07-21 10:56:07 -04:00
lat9nq
4a825268d6
shared_translation: Add the rest of the settings
2023-07-21 10:56:07 -04:00
lat9nq
4f545e3024
shared_translation: Add copyright and license
2023-07-21 10:56:07 -04:00
lat9nq
a007ac6b9c
configure_graphics_advance: Generate UI at runtime
...
We can iterate through the AdvancedGraphics settings and generate the UI
during runtime. This doesn't help runtime efficiency, but it helps a ton
in reducing the amount of work a developer needs in order to add a new
setting.
2023-07-21 10:56:07 -04:00
lat9nq
b11b4be7cb
configure_per_game: Rename group to tab_group
2023-07-21 10:56:07 -04:00
lat9nq
d3b94d64d4
configuration: Add base class to tabs
...
Tabs that largely configure SwitchableSetting's are now Tabs and grouped
together.
2023-07-21 10:56:07 -04:00
lat9nq
e5b981e1e4
configuration_shared: Create Tab base class
2023-07-21 10:56:07 -04:00
lat9nq
60773194a0
settings: Add a registry of settings
...
LoadString: Sanitize input
settings: Handle empty string, remove redundant category
settings: Rename Input to Controls, FS to DataStorage
settings: Fix Controls groups information
settings: Move use_docked_mode to System (again)
settings: Document
settings: Add type identification function
settings: Move registry into values
settings: Move global_reset_registry into values
settings: Separate AdvGraphics from Renderer
settings: More document
squash
settings: Use linkage object
uisettings: Move registry into settings
Probably wont build without
uisettings: Use settings linkage object
config: Load settings with a map
Uses the new all_settings vector to load settings.
qt-config: Rename settings category
qt config: Rename to read category
config: Read/write contols category with for_each
This is extremely limited due to the complexity of the Controls group,
but this handles the the settings that use the interface.
qt-config: Use new settings registry
qt-config: Read/write advgrphics
qt-config: Use settings linkage object
yuzu_cmd: Load setting off of vector
cmd-config: Finish settings rename
config: Read controls settings group with for_each
cmd/config: Move registry into values
cmd: Read adv graphics
cmd-config: Use settings linkage object
2023-07-21 10:56:07 -04:00
lat9nq
e7543e8b84
uisettings: Fix typings
2023-07-21 10:56:07 -04:00
lat9nq
4133165607
settings,core,config_sys: Remove optional type from custom_rtc, rng_seed
...
core: Fix MSVC errors
2023-07-21 10:56:07 -04:00
lat9nq
5ccfaf0517
settings: Pool SetGlobal functions
2023-07-21 10:56:07 -04:00
lat9nq
5cffa34288
settings,video_core: Consolidate ASTC decoding options
...
Just puts them all neatly into one place.
2023-07-21 10:56:07 -04:00
liamwhite
c0202da9ac
Merge pull request #11096 from german77/amiibooo
...
service: nfc: Update Implementation to match with latest RE
2023-07-21 09:21:48 -04:00
liamwhite
014ca709c9
Merge pull request #11116 from lat9nq/clang-shadowing
...
general: Silence -Wshadow{,-uncaptured-local} warnings
2023-07-19 17:14:55 -04:00
liamwhite
86bbfe3b1d
Merge pull request #11114 from Kelebek1/warnings
...
Mark SetIdleTimeDetectionExtension logging as debug
2023-07-19 17:14:45 -04:00
lat9nq
4ecedc4991
vk_buffer_cache: Format
2023-07-18 19:56:20 -04:00
lat9nq
71b3b2a2f0
general: Silence -Wshadow{,-uncaptured-local} warnings
...
These occur in the latest commits in LLVM Clang.
2023-07-18 19:31:35 -04:00
Kelebek1
80cd67ed7b
Debug SetIdleTimeDetectionExtension
2023-07-18 10:16:14 +01:00
Liam
8f1d48fda6
nsd: add GetApplicationServerEnvironmentType
2023-07-17 21:34:23 -04:00
Morph
16c238e4b9
ssl: Link with crypt32 for secure channel backend
2023-07-17 15:46:24 -04:00
Morph
e0fb1d3d17
ssl: Reorder inclusions
2023-07-17 15:46:24 -04:00
Morph
5bbc3aef13
network: Forward declarations
2023-07-17 15:36:03 -04:00
Narr the Reg
54f150b70a
service: nfc: Update Implementation to match with latest RE
2023-07-17 11:24:23 -06:00
liamwhite
5593bed08a
Merge pull request #10934 from abouvier/cmake-vma
...
cmake: allow using system VMA library
2023-07-17 10:42:41 -04:00
liamwhite
8750564bd2
Merge pull request #11102 from v1993/your-mom-is-encrypted
...
android: fix links to re-dumping guides
2023-07-17 10:42:31 -04:00
liamwhite
2461c78e3f
Merge pull request #10912 from comex/ssl
...
Implement SSL service
2023-07-16 16:56:47 -04:00
Valeri Ochinski
50fe45f1e4
android: fix links to re-dumping guides
2023-07-16 20:22:27 +03:00
GPUCode
4347dd26c6
buffer_cache: Increase number of texture buffers
2023-07-15 23:09:58 +03:00
comex
d7c532d889
Fixes and workarounds to make UBSan happier on macOS
...
There are still some other issues not addressed here, but it's a start.
Workarounds for false-positive reports:
- `RasterizerAccelerated`: Put a gigantic array behind a `unique_ptr`,
because UBSan has a [hardcoded limit](https://stackoverflow.com/questions/64531383/c-runtime-error-using-fsanitize-undefined-object-has-a-possibly-invalid-vp )
of how big it thinks objects can be, specifically when dealing with
offset-to-top values used with multiple inheritance. Hopefully this
doesn't have a performance impact.
- `QueryCacheBase::QueryCacheBase`: Avoid an operation that UBSan thinks
is UB even though it at least arguably isn't. See the link in the
comment for more information.
Fixes for correct reports:
- `PageTable`, `Memory`: Use `uintptr_t` values instead of pointers to
avoid UB from pointer overflow (when pointer arithmetic wraps around
the address space).
- `KScheduler::Reload`: `thread->GetOwnerProcess()` can be `nullptr`;
avoid calling methods on it in this case. (The existing code returns
a garbage reference to a field, which is then passed into
`LoadWatchpointArray`, and apparently it's never used, so it's
harmless in practice but still triggers UBSan.)
- `KAutoObject::Close`: This function calls `this->Destroy()`, which
overwrites the beginning of the object with junk (specifically a free
list pointer). Then it calls `this->UnregisterWithKernel()`. UBSan
complains about a type mismatch because the vtable has been
overwritten, and I believe this is indeed UB. `UnregisterWithKernel`
also loads `m_kernel` from the 'freed' object, which seems to be
technically safe (the overwriting doesn't extend as far as that
field), but seems dubious. Switch to a `static` method and load
`m_kernel` in advance.
2023-07-15 12:00:28 -07:00
Liam
474db2d8da
kernel: reduce page table region checking
2023-07-14 22:33:10 -04:00
Liam
a85ce8ea56
k_process: PageTable -> GetPageTable
2023-07-14 21:43:15 -04:00
Tobias
04868ab9da
file_sys/content_archive: Detect compressed NCAs ( #11047 )
2023-07-12 23:17:18 +02:00