Chris Adams
72f0f05d2f
JSHint: disable unused variable check
...
This is nice but until jshint/jshint#1146 is fixed there's no way to
selectively disable W098 for unused function arguments which we wish to
include for documentary purposes.
With this change there are only three remaining warnings, all of which
are actionable.
2013-06-20 15:12:54 -04:00
Chris Adams
adc4147304
Expose semi-private processDZIError for use by DziTileSource
...
This previously wasn't in scope outside of the main OpenSeadragon
closure. Now it's exposed with an underscore prefix to encourage people
not to think of it as a public interface.
2013-06-20 15:12:54 -04:00
Chris Adams
51bb8ca46e
openseadragon.js: fix imageFormatSupported refs
2013-06-20 15:12:54 -04:00
Chris Adams
169244ed1a
navigator.js: omit unused borderWidth from func args
2013-06-20 15:12:54 -04:00
Chris Adams
0d09183159
referencestrip.js: move variable declaration to the top of loadPanels
2013-06-20 15:12:54 -04:00
Chris Adams
eafc822aa8
openseadragon.js: remove unused builtin aliases
2013-06-20 15:12:54 -04:00
Chris Adams
8c433ba81c
Declare assumed globals
2013-06-20 15:12:54 -04:00
Chris Adams
e2bea810e3
Replace gnarly ternary expression with if statement
2013-06-20 15:12:53 -04:00
Chris Adams
64d94ac2bd
referencestrip.js: declare undeclared variable
2013-06-20 15:12:53 -04:00
Chris Adams
f8c77f65d7
viewer.js: fix typos in variable declarations
2013-06-20 15:12:53 -04:00
Chris Adams
d644acd50b
Fix lack of braces on if statements
...
JavaScript's most popular rack in the grass for maintenance coders…
2013-06-20 15:12:53 -04:00
Chris Adams
643ee211ca
Remove unused variables
...
Mostly unused function arguments but there were also a fair number
of legacy names which are now no longer used.
One question which comes up – mostly in tilesource.js – is whether
there is any value in leaving unused variables for functions which
are intended to be overridden anyway. I'm inclined to say that the
docs + tests need to be sufficient as there's no enforcement that
whatever is in the base implementation will actually be followed by
any of the real functions.
2013-06-20 15:12:53 -04:00
Chris Adams
6a214347d6
Upgrade to current JSHint
...
This also allows us to move our settings to .jshintrc for better IDE &
command-line integration - simply type "jshint" in the directory and it
will use the same options.
2013-06-20 15:12:53 -04:00
Chris Adams
dc81cde4ab
Grunt: stricter JSHint settings
2013-06-20 15:12:26 -04:00
Ian Gilman
e8b7b2375e
Updated changelog for #51
2013-06-20 10:34:33 -07:00
iangilman
6e9a300d1a
Merge pull request #133 from iangilman/raf
...
Improved requestAnimationFrame polyfill; fixed timer leaks; added tests
2013-06-20 09:52:10 -07:00
iangilman
2e49d793e8
Merge pull request #140 from felizuno/now
...
Added OpenSeadragon.now() (#138 )
2013-06-20 09:26:46 -07:00
iangilman
57d438cf88
Merge pull request #51 from acdha/generate-source-maps
...
Generate source maps
2013-06-20 09:25:30 -07:00
Kevin Ewing
0984106983
Added missing semicolon
2013-06-20 09:08:21 -07:00
Kevin Ewing
a469a1dae7
Merge branch 'master' into now
2013-06-19 15:39:06 -07:00
Kevin Ewing
2f8a26fda0
Responding to feedback
...
Function now re-assigns itself on the first go round to avoid doing the
check every time it is called
2013-06-19 15:13:56 -07:00
Ian Gilman
e0282a3c86
Stripped whitespace
2013-06-19 13:33:01 -07:00
Ian Gilman
0b5ddd0d55
Merge branch 'master' into raf
2013-06-19 11:52:13 -07:00
Ian Gilman
91c733551f
Added trim_trailing_white_space_on_save to Sublime project
2013-06-19 11:51:49 -07:00
Chris Adams
3c66c3b8e2
Update to grunt-contrib-uglify 0.2.2
2013-06-19 14:30:44 -04:00
Chris Adams
b87de8e6c6
Grunt: normalize build paths
...
The sourcemaps included build/openseadragon/ in the paths. Since grunt
lacks a standard way to replace text in files, I semi-randomly picked
grunt-text-replace.
2013-06-19 14:29:40 -04:00
Chris Adams
ae881689ec
Strip build prefix from sourceMappingURL (see #51 )
...
Previously the sourceMappingURL would be prefixed with
"build/openseadragon/"
2013-06-19 14:29:40 -04:00
Chris Adams
6e074188d4
Grunt: generate source maps when compressing
2013-06-19 14:29:40 -04:00
Kevin Ewing
ebffea5a34
Merge branch 'master' into now
2013-06-19 11:23:42 -07:00
Ian Gilman
8e88f36098
Merge branch 'master' into raf
...
Fixed Conflicts:
src/viewer.js
2013-06-19 11:19:54 -07:00
Kevin Ewing
e8408c1313
Moved to better location
2013-06-19 11:16:45 -07:00
iangilman
b7eec5d60a
Merge pull request #139 from acdha/whitespace-eradication
...
Strip trailing whitespace (see #136 )
2013-06-19 11:12:43 -07:00
Kevin Ewing
6a3b7cfb2f
Added OpenSeadragon.now()
2013-06-19 10:57:09 -07:00
Chris Adams
9f6f164d9f
Remove all whitespace
...
The results of running this command::
find . -name \*.js -print0 | xargs -0 perl -p -i -e "s|[ \t]+$||"
(Split from #136 )
2013-06-19 13:33:27 -04:00
Ian Gilman
2c2d1486cd
Added changelog for #133
2013-06-19 10:16:59 -07:00
Ian Gilman
beadcdcc89
Merge branch 'master' into raf
2013-06-19 10:15:53 -07:00
Ian Gilman
91e4edafd0
Updated changelog for #135
2013-06-19 10:14:49 -07:00
iangilman
c14467afa4
Merge pull request #135 from robhobbes/master
...
Only disable the previous button if the navPrevNextWrap option is not set
2013-06-19 10:12:38 -07:00
Ian Gilman
4022206261
Removed the parens around new Date call, for consistency
2013-06-19 10:03:44 -07:00
Ian Gilman
2e48239056
Addressing code review comments
2013-06-19 09:58:22 -07:00
Ian Gilman
dbc8a59ae8
Cleaned out dead code in scheduleUpdate and updateMulti
...
… as pointed out by @ventero
2013-06-19 09:58:09 -07:00
Robert Hickman
ade93ffc5e
Only disable the previous button if the navPrevNextWrap option is not set.
2013-06-18 15:19:09 -06:00
Ian Gilman
b38e319f2c
Testing closing one image and opening another in navigator suite
2013-06-18 11:09:05 -07:00
Ian Gilman
9a28793e64
Testing source and timer management in basic test
2013-06-18 11:08:33 -07:00
Ian Gilman
862b560cb4
Basic test no longer uses navigator since we have a suite for that
2013-06-18 11:08:16 -07:00
Ian Gilman
713fad4224
Exposing _updateRequestId as a semi-private member for testing purposes
2013-06-18 11:06:43 -07:00
Ian Gilman
e99c126a85
Navigator now updates properly when reopening a viewer
...
Before, if you closed a viewer and then opened a new tilesource into
it, the navigator would still have the old tilesource. This patch fixes
that.
2013-06-17 11:51:02 -07:00
Ian Gilman
c6a38dd802
Now closing the navigator when the viewer closes
...
At the very least this was causing the navigator to continue to request
and process frames even after its viewer had been closed.
2013-06-17 11:31:41 -07:00
Ian Gilman
4224960252
Fixed another potential timer leak when closing a viewer
...
If the viewer was closed in response to an event raised during the
update function, the timer would have continued running.
2013-06-17 11:30:31 -07:00
Ian Gilman
0112f6a4ea
Improved requestAnimationFrame polyfill
...
Processes all outstanding frame requests per frame, rather than one at
a time.
2013-06-17 11:28:42 -07:00
