Ian Gilman
3f1072b321
Fixed typos in comments
2013-06-26 09:15:37 -07:00
Chris Adams
c648c1df8a
drawer: don't leak drawLevel into global namespace
...
This code is still under-tested and documented but no longer relies on
`drawLevel` being leaked into the global namespace where `updateLevel`
to find it.
See #145
2013-06-25 14:26:09 -04:00
Chris Adams
f2cba16a8b
Safe cleanup in makeAjaxRequest error handler
...
Previously `request.onreadystatechange` was assigned an empty function
on success but null on failures, which breaks in IE (see
http://jsbin.com/ezozax/6/ ).
This patch simply mimics the success behaviour in the cleanup function
Closes #143
2013-06-25 14:13:45 -04:00
Benjamin 'blindCoder' Schieder
0150622e78
fix error when recalculating overlay width and height
2013-06-25 18:01:38 +02:00
Chris Adams
c2107fcb22
Declare _processDZIError directly on OpenSeadragon
2013-06-21 16:37:31 -04:00
Kevin Ewing
8896c2278d
Fixed mistake
2013-06-20 13:31:04 -07:00
Kevin Ewing
2ba3acda38
Removed extra parens
2013-06-20 13:23:16 -07:00
Kevin Ewing
248852c15f
Implementing OpenSeadragon.now()
...
Replacing both `+new Date()` and `new Date().getTime()` with `$.now()`
2013-06-20 13:15:04 -07:00
Chris Adams
9ef6e085c8
viewer.js: update onfullscreenchange handler comment
2013-06-20 15:17:48 -04:00
Chris Adams
de29a34890
viewer.js: remove dead code
2013-06-20 15:12:55 -04:00
Chris Adams
adc4147304
Expose semi-private processDZIError for use by DziTileSource
...
This previously wasn't in scope outside of the main OpenSeadragon
closure. Now it's exposed with an underscore prefix to encourage people
not to think of it as a public interface.
2013-06-20 15:12:54 -04:00
Chris Adams
51bb8ca46e
openseadragon.js: fix imageFormatSupported refs
2013-06-20 15:12:54 -04:00
Chris Adams
169244ed1a
navigator.js: omit unused borderWidth from func args
2013-06-20 15:12:54 -04:00
Chris Adams
0d09183159
referencestrip.js: move variable declaration to the top of loadPanels
2013-06-20 15:12:54 -04:00
Chris Adams
eafc822aa8
openseadragon.js: remove unused builtin aliases
2013-06-20 15:12:54 -04:00
Chris Adams
8c433ba81c
Declare assumed globals
2013-06-20 15:12:54 -04:00
Chris Adams
e2bea810e3
Replace gnarly ternary expression with if statement
2013-06-20 15:12:53 -04:00
Chris Adams
64d94ac2bd
referencestrip.js: declare undeclared variable
2013-06-20 15:12:53 -04:00
Chris Adams
f8c77f65d7
viewer.js: fix typos in variable declarations
2013-06-20 15:12:53 -04:00
Chris Adams
d644acd50b
Fix lack of braces on if statements
...
JavaScript's most popular rack in the grass for maintenance coders…
2013-06-20 15:12:53 -04:00
Chris Adams
643ee211ca
Remove unused variables
...
Mostly unused function arguments but there were also a fair number
of legacy names which are now no longer used.
One question which comes up – mostly in tilesource.js – is whether
there is any value in leaving unused variables for functions which
are intended to be overridden anyway. I'm inclined to say that the
docs + tests need to be sufficient as there's no enforcement that
whatever is in the base implementation will actually be followed by
any of the real functions.
2013-06-20 15:12:53 -04:00
iangilman
6e9a300d1a
Merge pull request #133 from iangilman/raf
...
Improved requestAnimationFrame polyfill; fixed timer leaks; added tests
2013-06-20 09:52:10 -07:00
Kevin Ewing
0984106983
Added missing semicolon
2013-06-20 09:08:21 -07:00
Kevin Ewing
2f8a26fda0
Responding to feedback
...
Function now re-assigns itself on the first go round to avoid doing the
check every time it is called
2013-06-19 15:13:56 -07:00
Ian Gilman
e0282a3c86
Stripped whitespace
2013-06-19 13:33:01 -07:00
Kevin Ewing
ebffea5a34
Merge branch 'master' into now
2013-06-19 11:23:42 -07:00
Ian Gilman
8e88f36098
Merge branch 'master' into raf
...
Fixed Conflicts:
src/viewer.js
2013-06-19 11:19:54 -07:00
Kevin Ewing
e8408c1313
Moved to better location
2013-06-19 11:16:45 -07:00
Kevin Ewing
6a3b7cfb2f
Added OpenSeadragon.now()
2013-06-19 10:57:09 -07:00
Chris Adams
9f6f164d9f
Remove all whitespace
...
The results of running this command::
find . -name \*.js -print0 | xargs -0 perl -p -i -e "s|[ \t]+$||"
(Split from #136 )
2013-06-19 13:33:27 -04:00
Ian Gilman
beadcdcc89
Merge branch 'master' into raf
2013-06-19 10:15:53 -07:00
iangilman
c14467afa4
Merge pull request #135 from robhobbes/master
...
Only disable the previous button if the navPrevNextWrap option is not set
2013-06-19 10:12:38 -07:00
Ian Gilman
4022206261
Removed the parens around new Date call, for consistency
2013-06-19 10:03:44 -07:00
Ian Gilman
2e48239056
Addressing code review comments
2013-06-19 09:58:22 -07:00
Ian Gilman
dbc8a59ae8
Cleaned out dead code in scheduleUpdate and updateMulti
...
… as pointed out by @ventero
2013-06-19 09:58:09 -07:00
Robert Hickman
ade93ffc5e
Only disable the previous button if the navPrevNextWrap option is not set.
2013-06-18 15:19:09 -06:00
Ian Gilman
713fad4224
Exposing _updateRequestId as a semi-private member for testing purposes
2013-06-18 11:06:43 -07:00
Ian Gilman
e99c126a85
Navigator now updates properly when reopening a viewer
...
Before, if you closed a viewer and then opened a new tilesource into
it, the navigator would still have the old tilesource. This patch fixes
that.
2013-06-17 11:51:02 -07:00
Ian Gilman
c6a38dd802
Now closing the navigator when the viewer closes
...
At the very least this was causing the navigator to continue to request
and process frames even after its viewer had been closed.
2013-06-17 11:31:41 -07:00
Ian Gilman
4224960252
Fixed another potential timer leak when closing a viewer
...
If the viewer was closed in response to an event raised during the
update function, the timer would have continued running.
2013-06-17 11:30:31 -07:00
Ian Gilman
0112f6a4ea
Improved requestAnimationFrame polyfill
...
Processes all outstanding frame requests per frame, rather than one at
a time.
2013-06-17 11:28:42 -07:00
Ventero
0093153e4e
Simplify setting element opacity.
...
This simplifies setElementOpacity by removing support for the
obsolete, IE-only element.filters property. Also removes a variable
that previously leaked into the global scope.
2013-06-13 19:09:47 +02:00
Ian Gilman
300167bcf1
Merge branch 'master' into ratio
2013-06-13 09:41:01 -07:00
iangilman
f412d07237
Merge pull request #121 from houseofyin/issue37-navigator
...
Issue37 navigator / Issue101 navigator follow-up / Issue102 navigator default
2013-06-13 09:39:27 -07:00
houseofyin
e9587808ec
Tweaked how the deprecated API element has handled
2013-06-11 14:35:45 -04:00
houseofyin
8a3ec97596
Implemented and documented fallback behavior
2013-06-07 10:24:12 -04:00
Ventero
a18f0e0efb
Improve performance of Tile#drawHTML.
...
By specifying the tile size in absolute pixel values instead of
percentages, we can save the call to $.getElementSize.
2013-06-03 20:09:42 +02:00
houseofyin
7a8ebd7d4c
More reasonable handling of the navigator when interacting outside the bounds of the display region
2013-06-02 22:32:29 -04:00
houseofyin
dc7bc6920c
Updating the documentation
2013-06-01 16:09:04 -04:00
houseofyin
3e24be12e0
Merge branch 'master' of github.com:openseadragon/openseadragon into issue37-navigator
2013-06-01 14:12:04 -04:00