Commit Graph

695 Commits

Author SHA1 Message Date
iangilman
8fe0ce26b8 Merge pull request #136 from acdha/jshint-cleanup
JSHint tidying
2013-06-26 09:37:08 -07:00
Ian Gilman
e731c850b5 Changelog for #144 2013-06-26 09:24:55 -07:00
iangilman
f4139cef38 Merge pull request #144 from acdha/143-xhr-error-handling
Safe cleanup in makeAjaxRequest error handler
2013-06-26 09:23:04 -07:00
Ian Gilman
ae3c68a646 Added changelog for #142 2013-06-26 09:15:48 -07:00
Ian Gilman
3f1072b321 Fixed typos in comments 2013-06-26 09:15:37 -07:00
iangilman
1df4448be7 Merge pull request #142 from blind-coder/master
Fix for calculating overlay width / height
2013-06-26 09:13:31 -07:00
Chris Adams
c648c1df8a drawer: don't leak drawLevel into global namespace
This code is still under-tested and documented but no longer relies on
`drawLevel` being leaked into the global namespace where `updateLevel`
to find it.

See #145
2013-06-25 14:26:09 -04:00
Chris Adams
f2cba16a8b Safe cleanup in makeAjaxRequest error handler
Previously `request.onreadystatechange` was assigned an empty function
on success but null on failures, which breaks in IE (see
http://jsbin.com/ezozax/6/).

This patch simply mimics the success behaviour in the cleanup function

Closes #143
2013-06-25 14:13:45 -04:00
Benjamin 'blindCoder' Schieder
0150622e78 fix error when recalculating overlay width and height 2013-06-25 18:01:38 +02:00
Chris Adams
c2107fcb22 Declare _processDZIError directly on OpenSeadragon 2013-06-21 16:37:31 -04:00
Ian Gilman
9cbda1bd8f Updated changelog for #138 2013-06-21 09:30:45 -07:00
iangilman
67e588b513 Merge pull request #141 from felizuno/now2
Implementing the new OpenSeadragon.now()
2013-06-21 09:28:37 -07:00
Kevin Ewing
8896c2278d Fixed mistake 2013-06-20 13:31:04 -07:00
Kevin Ewing
2ba3acda38 Removed extra parens 2013-06-20 13:23:16 -07:00
Kevin Ewing
248852c15f Implementing OpenSeadragon.now()
Replacing both `+new Date()` and `new Date().getTime()` with `$.now()`
2013-06-20 13:15:04 -07:00
Chris Adams
9ef6e085c8 viewer.js: update onfullscreenchange handler comment 2013-06-20 15:17:48 -04:00
Chris Adams
de29a34890 viewer.js: remove dead code 2013-06-20 15:12:55 -04:00
Chris Adams
72f0f05d2f JSHint: disable unused variable check
This is nice but until jshint/jshint#1146 is fixed there's no way to
selectively disable W098 for unused function arguments which we wish to
include for documentary purposes.

With this change there are only three remaining warnings, all of which
are actionable.
2013-06-20 15:12:54 -04:00
Chris Adams
adc4147304 Expose semi-private processDZIError for use by DziTileSource
This previously wasn't in scope outside of the main OpenSeadragon
closure. Now it's exposed with an underscore prefix to encourage people
not to think of it as a public interface.
2013-06-20 15:12:54 -04:00
Chris Adams
51bb8ca46e openseadragon.js: fix imageFormatSupported refs 2013-06-20 15:12:54 -04:00
Chris Adams
169244ed1a navigator.js: omit unused borderWidth from func args 2013-06-20 15:12:54 -04:00
Chris Adams
0d09183159 referencestrip.js: move variable declaration to the top of loadPanels 2013-06-20 15:12:54 -04:00
Chris Adams
eafc822aa8 openseadragon.js: remove unused builtin aliases 2013-06-20 15:12:54 -04:00
Chris Adams
8c433ba81c Declare assumed globals 2013-06-20 15:12:54 -04:00
Chris Adams
e2bea810e3 Replace gnarly ternary expression with if statement 2013-06-20 15:12:53 -04:00
Chris Adams
64d94ac2bd referencestrip.js: declare undeclared variable 2013-06-20 15:12:53 -04:00
Chris Adams
f8c77f65d7 viewer.js: fix typos in variable declarations 2013-06-20 15:12:53 -04:00
Chris Adams
d644acd50b Fix lack of braces on if statements
JavaScript's most popular rack in the grass for maintenance coders…
2013-06-20 15:12:53 -04:00
Chris Adams
643ee211ca Remove unused variables
Mostly unused function arguments but there were also a fair number
of legacy names which are now no longer used.

One question which comes up – mostly in tilesource.js – is whether
there is any value in leaving unused variables for functions which
are intended to be overridden anyway. I'm inclined to say that the
docs + tests need to be sufficient as there's no enforcement that
whatever is in the base implementation will actually be followed by
any of the real functions.
2013-06-20 15:12:53 -04:00
Chris Adams
6a214347d6 Upgrade to current JSHint
This also allows us to move our settings to .jshintrc for better IDE &
command-line integration - simply type "jshint" in the directory and it
will use the same options.
2013-06-20 15:12:53 -04:00
Chris Adams
dc81cde4ab Grunt: stricter JSHint settings 2013-06-20 15:12:26 -04:00
Ian Gilman
e8b7b2375e Updated changelog for #51 2013-06-20 10:34:33 -07:00
iangilman
6e9a300d1a Merge pull request #133 from iangilman/raf
Improved requestAnimationFrame polyfill; fixed timer leaks; added tests
2013-06-20 09:52:10 -07:00
iangilman
2e49d793e8 Merge pull request #140 from felizuno/now
Added OpenSeadragon.now() (#138)
2013-06-20 09:26:46 -07:00
iangilman
57d438cf88 Merge pull request #51 from acdha/generate-source-maps
Generate source maps
2013-06-20 09:25:30 -07:00
Kevin Ewing
0984106983 Added missing semicolon 2013-06-20 09:08:21 -07:00
Kevin Ewing
a469a1dae7 Merge branch 'master' into now 2013-06-19 15:39:06 -07:00
Kevin Ewing
2f8a26fda0 Responding to feedback
Function now re-assigns itself on the first go round to avoid doing the
check every time it is called
2013-06-19 15:13:56 -07:00
Ian Gilman
e0282a3c86 Stripped whitespace 2013-06-19 13:33:01 -07:00
Ian Gilman
0b5ddd0d55 Merge branch 'master' into raf 2013-06-19 11:52:13 -07:00
Ian Gilman
91c733551f Added trim_trailing_white_space_on_save to Sublime project 2013-06-19 11:51:49 -07:00
Chris Adams
3c66c3b8e2 Update to grunt-contrib-uglify 0.2.2 2013-06-19 14:30:44 -04:00
Chris Adams
b87de8e6c6 Grunt: normalize build paths
The sourcemaps included build/openseadragon/ in the paths. Since grunt
lacks a standard way to replace text in files, I semi-randomly picked
grunt-text-replace.
2013-06-19 14:29:40 -04:00
Chris Adams
ae881689ec Strip build prefix from sourceMappingURL (see #51)
Previously the sourceMappingURL would be prefixed with
"build/openseadragon/"
2013-06-19 14:29:40 -04:00
Chris Adams
6e074188d4 Grunt: generate source maps when compressing 2013-06-19 14:29:40 -04:00
Kevin Ewing
ebffea5a34 Merge branch 'master' into now 2013-06-19 11:23:42 -07:00
Ian Gilman
8e88f36098 Merge branch 'master' into raf
Fixed Conflicts:
	src/viewer.js
2013-06-19 11:19:54 -07:00
Kevin Ewing
e8408c1313 Moved to better location 2013-06-19 11:16:45 -07:00
iangilman
b7eec5d60a Merge pull request #139 from acdha/whitespace-eradication
Strip trailing whitespace (see #136)
2013-06-19 11:12:43 -07:00
Kevin Ewing
6a3b7cfb2f Added OpenSeadragon.now() 2013-06-19 10:57:09 -07:00