fix: removes resize event on destroy

This commit is contained in:
ronnymikalsen 2021-03-26 09:43:30 +01:00
parent 99f87c0bc7
commit f0cf90df76

View File

@ -220,6 +220,7 @@ $.Viewer = function( options ) {
this._updateRequestId = null; this._updateRequestId = null;
this._loadQueue = []; this._loadQueue = [];
this.currentOverlays = []; this.currentOverlays = [];
this._updatePixelDensityRatioBind = null;
this._lastScrollTime = $.now(); // variable used to help normalize the scroll event speed of different devices this._lastScrollTime = $.now(); // variable used to help normalize the scroll event speed of different devices
@ -426,8 +427,7 @@ $.Viewer = function( options ) {
} }
} }
// Add updatePixelDensityRatio to resize event this._addUpdatePixelDensityRatioEvent();
$.addEvent( window, 'resize', this._updatePixelDensityRatio.bind(this) );
//Instantiate a navigator if configured //Instantiate a navigator if configured
if ( this.showNavigator){ if ( this.showNavigator){
@ -751,6 +751,8 @@ $.extend( $.Viewer.prototype, $.EventSource.prototype, $.ControlDock.prototype,
return; return;
} }
this._removeUpdatePixelDensityRatioEvent();
this.close(); this.close();
this.clearOverlays(); this.clearOverlays();
@ -2284,6 +2286,23 @@ $.extend( $.Viewer.prototype, $.EventSource.prototype, $.ControlDock.prototype,
} else { } else {
$.console.warn('Attempting to display a reference strip while "sequenceMode" is off.'); $.console.warn('Attempting to display a reference strip while "sequenceMode" is off.');
} }
},
/**
* Adds _updatePixelDensityRatio to the window resize event.
* @private
*/
_addUpdatePixelDensityRatioEvent: function() {
this._updatePixelDensityRatioBind = this._updatePixelDensityRatio.bind(this);
$.addEvent( window, 'resize', this._updatePixelDensityRatioBind );
},
/**
* Removes _updatePixelDensityRatio from the window resize event.
* @private
*/
_removeUpdatePixelDensityRatioEvent: function() {
$.removeEvent( window, 'resize', this._updatePixelDensityRatioBind );
} }
}); });