mirror/openseadragon
1
0
Fork 0
mirror of https://github.com/openseadragon/openseadragon.git synced 2024-11-21 20:56:09 +03:00
Code Issues Projects Releases Wiki Activity

Removed the 'onPageChange' callback (#285)

Browse Source 
Fix for #285
Removed the 'onPageChange' callback from the viewer options.
Viewer.goToPage() now raises the 'page' event only.
This commit is contained in:
Mark Salsbery 2013-11-19 12:13:38 -08:00
parent dfd1b6ddfe
commit ebb15936e1
3 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.txt
View File

@ -28,6 +28,7 @@ OPENSEADRAGON CHANGELOG
* The `fullpage` property of the 'full-page' event is now `fullPage`. * The `fullpage` property of the 'full-page' event is now `fullPage`.
* There is now a 'full-screen' event with a `fullScreen` property (true if it has gone to full screen). * There is now a 'full-screen' event with a `fullScreen` property (true if it has gone to full screen).
* There are now 'pre-full-page' and 'pre-full-screen' events that include a `preventDefaultAction` property you can set in your handler to cancel. They also have `fullPage` and `fullScreen` properties respectively, to indicate if they are going into or out of the mode. * There are now 'pre-full-page' and 'pre-full-screen' events that include a `preventDefaultAction` property you can set in your handler to cancel. They also have `fullPage` and `fullScreen` properties respectively, to indicate if they are going into or out of the mode.
* BREAKING CHANGE: Removed the 'onPageChange' callback from the viewer options. Viewer.goToPage() now raises the 'page' event only (#285)
* MouseTracker now passes the original event objects to its handler methods (#23) * MouseTracker now passes the original event objects to its handler methods (#23)
* MouseTracker now supports an optional 'moveHandler' method for tracking mousemove events (#215) * MouseTracker now supports an optional 'moveHandler' method for tracking mousemove events (#215)
* Added stopHandler to MouseTracker. (#262) * Added stopHandler to MouseTracker. (#262)

3
src/openseadragon.js
View File

@ -567,9 +567,6 @@ window.OpenSeadragon = window.OpenSeadragon || function( options ){
collectionMode: false, collectionMode: false,
collectionTileSize: 800, collectionTileSize: 800,
//EVENT RELATED CALLBACKS
onPageChange: null,
//PERFORMANCE SETTINGS //PERFORMANCE SETTINGS
imageLoaderLimit: 0, imageLoaderLimit: 0,
maxImageCacheCount: 200, maxImageCacheCount: 200,

30
src/viewer.js
View File

@ -1136,28 +1136,30 @@ $.extend( $.Viewer.prototype, $.EventSource.prototype, $.ControlDock.prototype,
* @return {OpenSeadragon.Viewer} Chainable. * @return {OpenSeadragon.Viewer} Chainable.
*/ */
goToPage: function( page ){ goToPage: function( page ){
//page is a 1 based index so normalize now if( page >= 0 && page < this.tileSources.length ){
//page = page; /**
this.raiseEvent( 'page', { page: page } ); * Raised when the page is changed on a viewer configured with multiple image sources.
*
if( this.tileSources.length > page ){ * @event page
* @memberof OpenSeadragon.Viewer
* @type {Object}
* @property {OpenSeadragon.Viewer} eventSource - A reference to the Viewer which raised the event.
* @property {Number} page - The page index.
* @property {?Object} userData - Arbitrary subscriber-defined object.
*/
this.raiseEvent( 'page', { page: page } );
THIS[ this.hash ].sequence = page; THIS[ this.hash ].sequence = page;
this._updateSequenceButtons( page ); this._updateSequenceButtons( page );
this.open( this.tileSources[ page ] ); this.open( this.tileSources[ page ] );
if( this.referenceStrip ){
this.referenceStrip.setFocus( page );
}
} }
if( $.isFunction( this.onPageChange ) ){
this.onPageChange({
page: page,
viewer: this
});
}
if( this.referenceStrip ){
this.referenceStrip.setFocus( page );
}
return this; return this;
}, },