From 2c03c1bbe95b5d034bfa2c0b2d7ebd1598e2f0f6 Mon Sep 17 00:00:00 2001 From: Delile Sebastien Date: Wed, 31 May 2023 16:11:42 +0200 Subject: [PATCH 1/3] workaround tile edge smoothing maxZoom + flip --- src/tiledimage.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/tiledimage.js b/src/tiledimage.js index 3571aaea..393859ce 100644 --- a/src/tiledimage.js +++ b/src/tiledimage.js @@ -1965,6 +1965,7 @@ $.extend($.TiledImage.prototype, $.EventSource.prototype, /** @lends OpenSeadrag imageZoom > this.smoothTileEdgesMinZoom && !this.iOSDevice && this.getRotation(true) % 360 === 0 && // TODO: support tile edge smoothing with tiled image rotation. + this._drawer.viewer.viewport.getFlip() === false && // TODO: support tile edge smoothing with tiled image flip. $.supportsCanvas && this.viewer.useCanvas) { // When zoomed in a lot (>100%) the tile edges are visible. // So we have to composite them at ~100% and scale them up together. From f004ecf32382601747030991cbdaa845b99b243d Mon Sep 17 00:00:00 2001 From: Delile Sebastien Date: Thu, 1 Jun 2023 10:20:14 +0200 Subject: [PATCH 2/3] fix comment --- src/tiledimage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tiledimage.js b/src/tiledimage.js index 393859ce..d2255ea8 100644 --- a/src/tiledimage.js +++ b/src/tiledimage.js @@ -1965,7 +1965,7 @@ $.extend($.TiledImage.prototype, $.EventSource.prototype, /** @lends OpenSeadrag imageZoom > this.smoothTileEdgesMinZoom && !this.iOSDevice && this.getRotation(true) % 360 === 0 && // TODO: support tile edge smoothing with tiled image rotation. - this._drawer.viewer.viewport.getFlip() === false && // TODO: support tile edge smoothing with tiled image flip. + this._drawer.viewer.viewport.getFlip() === false && // TODO: support tile edge smoothing with viewport flip. $.supportsCanvas && this.viewer.useCanvas) { // When zoomed in a lot (>100%) the tile edges are visible. // So we have to composite them at ~100% and scale them up together. From f96db3cf0f34650fc1b1cf8a8990bcf7ee49a04c Mon Sep 17 00:00:00 2001 From: Delile Sebastien Date: Fri, 2 Jun 2023 18:59:22 +0200 Subject: [PATCH 3/3] complete comment --- src/tiledimage.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tiledimage.js b/src/tiledimage.js index d2255ea8..6ad0cf66 100644 --- a/src/tiledimage.js +++ b/src/tiledimage.js @@ -1964,8 +1964,8 @@ $.extend($.TiledImage.prototype, $.EventSource.prototype, /** @lends OpenSeadrag if (lastDrawn.length > 1 && imageZoom > this.smoothTileEdgesMinZoom && !this.iOSDevice && - this.getRotation(true) % 360 === 0 && // TODO: support tile edge smoothing with tiled image rotation. - this._drawer.viewer.viewport.getFlip() === false && // TODO: support tile edge smoothing with viewport flip. + this.getRotation(true) % 360 === 0 && // TODO: support tile edge smoothing with tiled image rotation (viewport rotation is not a problem). + this._drawer.viewer.viewport.getFlip() === false && // TODO: support tile edge smoothing with viewport flip (tiled image flip is not a problem). $.supportsCanvas && this.viewer.useCanvas) { // When zoomed in a lot (>100%) the tile edges are visible. // So we have to composite them at ~100% and scale them up together.