From e128ff3a720f8566b6c569a08f6ee9f40e985009 Mon Sep 17 00:00:00 2001
From: Tom <tmpearce@gmail.com>
Date: Wed, 13 Nov 2024 13:17:39 -0500
Subject: [PATCH] handle cleanup of test viewer

---
 src/webgldrawer.js | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/src/webgldrawer.js b/src/webgldrawer.js
index d9fbe2b1..7e9de15a 100644
--- a/src/webgldrawer.js
+++ b/src/webgldrawer.js
@@ -1347,12 +1347,12 @@
 
             // Create a small element for the test viewer and append it to our viewer's element
             const div = document.createElement('div');
-            div.setAttribute('id', 'osd_internal_test');
             div.style.width = '4px';
             div.style.height = '4px';
             div.style.position = 'fixed';
             div.style.top = 0;
             div.style.left = 0;
+            div.style.opacity = 0.0001;
             this.viewer.element.appendChild( div );
 
             // create the test viewer
@@ -1361,6 +1361,13 @@
             // reset testing flag to false so additional viewers can be tested
             testing = false;
 
+            // Clean up the test viewer when the main viewer is destroyed (if it hasn't been already)
+            testViewer.addOnceHandler('before-destroy', () => {
+                testViewer.destroy();
+                if(div.parentNode){
+                    div.parentNode.removeChild(div);
+                }
+            });
             // Once a frame is drawn, check the pixel values in the output canvas
             testViewer.addOnceHandler('update-viewport', () => {
                 const numNonZeroValues = testViewer.drawer._outputContext.getImageData(0, 0, 4, 4).data.filter( pixel => pixel > 0).length;
@@ -1388,7 +1395,9 @@
 
                 // Clean up the test viewer
                 setTimeout( () => testViewer.destroy(), 0);
-                this.viewer.element.removeChild(div);
+                if(div.parentNode){
+                    div.parentNode.removeChild(div);
+                }
             });
 
             // Open the test image using the dataUrl from above