From b15ba75551cd17f444e4ab96c2650e7954914413 Mon Sep 17 00:00:00 2001 From: ViratSr Date: Tue, 15 Aug 2023 16:46:10 +0530 Subject: [PATCH 1/3] fixed position issue --- src/navigator.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/navigator.js b/src/navigator.js index 0665b58d..4d114bcc 100644 --- a/src/navigator.js +++ b/src/navigator.js @@ -162,7 +162,7 @@ $.Navigator = function( options ){ this.displayRegion.className = 'displayregion'; (function( style, borderWidth ){ - style.position = 'relative'; + if (style.position === 'static') { style.position = 'relative'; } style.top = '0px'; style.left = '0px'; style.fontSize = '0px'; From 9b051f55de39e18ffc7588e6f4b2b8f48b06c128 Mon Sep 17 00:00:00 2001 From: ViratSr Date: Wed, 16 Aug 2023 00:10:55 +0530 Subject: [PATCH 2/3] #fix496 --- src/controldock.js | 5 ++++- src/navigator.js | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/controldock.js b/src/controldock.js index 84b178f5..d7d61600 100644 --- a/src/controldock.js +++ b/src/controldock.js @@ -59,7 +59,10 @@ if( this.element ){ this.element = $.getElement( this.element ); this.element.appendChild( this.container ); - this.element.style.position = 'relative'; + // this.element.style.position = 'relative'; + if(this.element.style.position === 'static'){ + this.element.style.position = 'relative'; + } this.container.style.width = '100%'; this.container.style.height = '100%'; } diff --git a/src/navigator.js b/src/navigator.js index 4d114bcc..2be682a8 100644 --- a/src/navigator.js +++ b/src/navigator.js @@ -162,7 +162,7 @@ $.Navigator = function( options ){ this.displayRegion.className = 'displayregion'; (function( style, borderWidth ){ - if (style.position === 'static') { style.position = 'relative'; } + style.position = 'relative'; style.top = '0px'; style.left = '0px'; style.fontSize = '0px'; From ed49d46237fe4aaed431e174493d828cacf6e3ee Mon Sep 17 00:00:00 2001 From: ViratSr Date: Thu, 17 Aug 2023 10:39:45 +0530 Subject: [PATCH 3/3] syntax fixed and if statement amended --- src/controldock.js | 3 +-- src/navigator.js | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/controldock.js b/src/controldock.js index d7d61600..0ab9e5cc 100644 --- a/src/controldock.js +++ b/src/controldock.js @@ -59,8 +59,7 @@ if( this.element ){ this.element = $.getElement( this.element ); this.element.appendChild( this.container ); - // this.element.style.position = 'relative'; - if(this.element.style.position === 'static'){ + if( $.getElementStyle(this.element).position === 'static' ){ this.element.style.position = 'relative'; } this.container.style.width = '100%'; diff --git a/src/navigator.js b/src/navigator.js index 2be682a8..0665b58d 100644 --- a/src/navigator.js +++ b/src/navigator.js @@ -162,7 +162,7 @@ $.Navigator = function( options ){ this.displayRegion.className = 'displayregion'; (function( style, borderWidth ){ - style.position = 'relative'; + style.position = 'relative'; style.top = '0px'; style.left = '0px'; style.fontSize = '0px';