Refactor test helper functions for improved readability and consistency

This commit is contained in:
Harsh Kumar Gupta 2024-12-18 00:53:44 +05:30
parent c06e719198
commit 74ffb66f40

View File

@ -59,13 +59,16 @@
}, },
// ---------- // ----------
equalsWithVariance: function ( value1, value2, variance ) { equalsWithVariance: function (value1, value2, variance) {
return Math.abs( value1 - value2 ) <= variance; return Math.abs(value1 - value2) <= variance;
}, },
// ---------- // ----------
assessNumericValue: function ( assert, value1, value2, variance, message ) { assessNumericValue: function (assert, actual, expected, variance, message) {
assert.ok( Util.equalsWithVariance( value1, value2, variance ), message + " Expected:" + value1 + " Found: " + value2 + " Variance: " + variance ); assert.ok(
Util.equalsWithVariance(actual, expected, variance),
message + " Actual: " + actual + " Expected: " + expected + " Variance: " + variance
);
}, },
// ---------- // ----------
@ -78,12 +81,9 @@
assertRectangleEquals: function (assert, rectA, rectB, precision, message) { assertRectangleEquals: function (assert, rectA, rectB, precision, message) {
Util.assessNumericValue(assert, rectA.x, rectB.x, precision, message + " x: "); Util.assessNumericValue(assert, rectA.x, rectB.x, precision, message + " x: ");
Util.assessNumericValue(assert, rectA.y, rectB.y, precision, message + " y: "); Util.assessNumericValue(assert, rectA.y, rectB.y, precision, message + " y: ");
Util.assessNumericValue(assert, rectA.width, rectB.width, precision, Util.assessNumericValue(assert, rectA.width, rectB.width, precision, message + " width: ");
message + " width: "); Util.assessNumericValue(assert, rectA.height, rectB.height, precision, message + " height: ");
Util.assessNumericValue(assert, rectA.height, rectB.height, precision, Util.assessNumericValue(assert, rectA.degrees, rectB.degrees, precision, message + " degrees: ");
message + " height: ");
Util.assessNumericValue(assert, rectA.degrees, rectB.degrees, precision,
message + " degrees: ");
}, },
// ---------- // ----------