addressing venturo's review notes

This commit is contained in:
thatcher 2013-02-28 15:22:10 -05:00
parent a4477cd765
commit 5dd8798f7f

View File

@ -632,10 +632,6 @@ $.extend( $.Viewer.prototype, $.EventHandler.prototype, $.ControlDock.prototype,
if ( fullPage ) { if ( fullPage ) {
if( $.supportsFullScreen ){
}
this.bodyOverflow = bodyStyle.overflow; this.bodyOverflow = bodyStyle.overflow;
this.docOverflow = docStyle.overflow; this.docOverflow = docStyle.overflow;
bodyStyle.overflow = "hidden"; bodyStyle.overflow = "hidden";
@ -691,8 +687,6 @@ $.extend( $.Viewer.prototype, $.EventHandler.prototype, $.ControlDock.prototype,
// fullscreen state of the browser, but it is possible to // fullscreen state of the browser, but it is possible to
// retrieve it through the fullscreen API // retrieve it through the fullscreen API
if( $.isFullScreen() ){ if( $.isFullScreen() ){
// The target of the event is always the document,
// but it is possible to retrieve the fullscreen element through the API
_this.setFullPage( true ); _this.setFullPage( true );
} else { } else {
_this.setFullPage( false ); _this.setFullPage( false );
@ -701,6 +695,8 @@ $.extend( $.Viewer.prototype, $.EventHandler.prototype, $.ControlDock.prototype,
$.requestFullScreen( document.body ); $.requestFullScreen( document.body );
// The target of the event is always the document,
// but it is possible to retrieve the fullscreen element through the API
// Note that the API is still vendor-prefixed in browsers implementing it // Note that the API is still vendor-prefixed in browsers implementing it
document.addEventListener( document.addEventListener(
$.fullScreenEventName, $.fullScreenEventName,