Addressing code review comments

This commit is contained in:
Ian Gilman 2013-06-19 09:58:22 -07:00
parent dbc8a59ae8
commit 2e48239056

View File

@ -1686,12 +1686,15 @@ window.OpenSeadragon = window.OpenSeadragon || function( options ){
if ( !iIntervalId ) { if ( !iIntervalId ) {
iIntervalId = setInterval( function() { iIntervalId = setInterval( function() {
if ( aAnimQueue.length ) { if ( aAnimQueue.length ) {
var time = (new Date()).getTime();
// Process all of the currently outstanding frame // Process all of the currently outstanding frame
// requests, but none that get added during the // requests, but none that get added during the
// processing. // processing.
var time = +new Date(); // Swap the arrays so we don't have to create a new
// array every frame.
var temp = processing;
processing = aAnimQueue; processing = aAnimQueue;
aAnimQueue = []; aAnimQueue = temp;
while ( processing.length ) { while ( processing.length ) {
processing.shift()[ 1 ]( time ); processing.shift()[ 1 ]( time );
} }
@ -1718,7 +1721,8 @@ window.OpenSeadragon = window.OpenSeadragon || function( options ){
} }
// If it's not in the queue, it may be in the set we're currently // If it's not in the queue, it may be in the set we're currently
// processing. // processing (if cancelAnimationFrame is called from within a
// requestAnimationFrame callback).
for ( i = 0, j = processing.length; i < j; i += 1 ) { for ( i = 0, j = processing.length; i < j; i += 1 ) {
if ( processing[ i ][ 0 ] === requestId ) { if ( processing[ i ][ 0 ] === requestId ) {
processing.splice( i, 1 ); processing.splice( i, 1 );