mirror/openseadragon
1
0
Fork 0
mirror of https://github.com/openseadragon/openseadragon.git synced 2024-11-28 08:06:08 +03:00
Code Issues Projects Releases Wiki Activity

fix viewport.update so tests don't stall

Browse Source
This commit is contained in:
Tom 2023-12-21 16:31:23 -05:00
parent 22ecdfd75d
commit 1a1e2c20c0
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/viewport.js
View File

@ -1133,7 +1133,7 @@ $.Viewport.prototype = {
/** /**
* Update the zoom, degrees, and center (X and Y) springs. * Update the zoom, degrees, and center (X and Y) springs.
* @function * @function
* @returns {Boolean} True if any spring is still animating, false otherwise. * @returns {Boolean} True if the viewport is still animating, false otherwise.
*/ */
update: function() { update: function() {
var _this = this; var _this = this;
@ -1153,17 +1153,25 @@ $.Viewport.prototype = {
this.degreesSpring.update(); this.degreesSpring.update();
} }
var changed = this.centerSpringX.current.value !== this._oldCenterX ||
this.centerSpringY.current.value !== this._oldCenterY ||
this.zoomSpring.current.value !== this._oldZoom ||
this.degreesSpring.current.value !== this._oldDegrees;
this._oldCenterX = this.centerSpringX.current.value; this._oldCenterX = this.centerSpringX.current.value;
this._oldCenterY = this.centerSpringY.current.value; this._oldCenterY = this.centerSpringY.current.value;
this._oldZoom = this.zoomSpring.current.value; this._oldZoom = this.zoomSpring.current.value;
this._oldDegrees = this.degreesSpring.current.value; this._oldDegrees = this.degreesSpring.current.value;
var stillUpdating = !this.zoomSpring.isAtTargetValue() || var isAnimating = changed ||
!this.centerSpringX.isAtTargetValue() || !this.zoomSpring.isAtTargetValue() ||
!this.centerSpringY.isAtTargetValue() || !this.centerSpringX.isAtTargetValue() ||
!this.degreesSpring.isAtTargetValue(); !this.centerSpringY.isAtTargetValue() ||
!this.degreesSpring.isAtTargetValue();
return stillUpdating; return isAnimating;
}, },
// private - pass true to use spring, or a number for degrees for immediate rotation // private - pass true to use spring, or a number for degrees for immediate rotation