Quick patch to fix mid-update image loaded callbacks

This commit is contained in:
Ryan Lester 2014-05-21 18:29:40 -07:00
parent 975828c057
commit 06dcfadf20
2 changed files with 60 additions and 49 deletions

View File

@ -703,23 +703,10 @@ function loadTile( drawer, tile, time ) {
} }
function onTileLoad( drawer, tile, time, image ) { function onTileLoad( drawer, tile, time, image ) {
var insertionIndex,
cutoff,
worstTile,
worstTime,
worstLevel,
worstTileIndex,
prevTile,
prevTime,
prevLevel,
i;
tile.loading = false; tile.loading = false;
if ( drawer.midUpdate ) { if ( !image && !drawer.viewport.collectionMode ) {
$.console.warn( "Tile load callback in middle of drawing routine." );
return;
} else if ( !image && !drawer.viewport.collectionMode ) {
$.console.log( "Tile %s failed to load: %s", tile, tile.url ); $.console.log( "Tile %s failed to load: %s", tile, tile.url );
if( !drawer.debugMode ){ if( !drawer.debugMode ){
tile.exists = false; tile.exists = false;
@ -733,48 +720,65 @@ function onTileLoad( drawer, tile, time, image ) {
tile.loaded = true; tile.loaded = true;
tile.image = image; tile.image = image;
if ( drawer.tilesLoaded.length < drawer.maxImageCacheCount ) {
insertionIndex = drawer.tilesLoaded.length; // always safe to append things to cache
drawer.tilesLoaded[ drawer.tilesLoaded.length ] = tile;
if ( drawer.tilesLoaded.length >= drawer.maxImageCacheCount ) { }
cutoff = Math.ceil( Math.log( drawer.source.tileSize ) / Math.log( 2 ) ); else {
// need to remove something from cache,
worstTile = null; // make sure this doesn't happen mid update
worstTileIndex = -1; if ( !drawer.midUpdate ) {
updateTileCache( tile, drawer );
for ( i = drawer.tilesLoaded.length - 1; i >= 0; i-- ) {
prevTile = drawer.tilesLoaded[ i ];
if ( prevTile.level <= drawer.cutoff || prevTile.beingDrawn ) {
continue;
} else if ( !worstTile ) {
worstTile = prevTile;
worstTileIndex = i;
continue;
}
prevTime = prevTile.lastTouchTime;
worstTime = worstTile.lastTouchTime;
prevLevel = prevTile.level;
worstLevel = worstTile.level;
if ( prevTime < worstTime ||
( prevTime == worstTime && prevLevel > worstLevel ) ) {
worstTile = prevTile;
worstTileIndex = i;
}
} }
else {
if ( worstTile && worstTileIndex >= 0 ) { window.setTimeout( function() {
worstTile.unload(); updateTileCache( tile, drawer );
insertionIndex = worstTileIndex; }, 1);
} }
} }
drawer.tilesLoaded[ insertionIndex ] = tile;
drawer.updateAgain = true; drawer.updateAgain = true;
} }
function updateTileCache( newTile, drawer ) {
var i, prevTile, prevTime, worstTime, prevLevel, worstLevel,
insertionIndex = drawer.tilesLoaded.length,
cutoff = Math.ceil( Math.log( drawer.source.tileSize ) / Math.log( 2 ) ),
worstTile = null,
worstTileIndex = -1;
for ( i = drawer.tilesLoaded.length - 1; i >= 0; i-- ) {
prevTile = drawer.tilesLoaded[ i ];
if ( prevTile.level <= drawer.cutoff || prevTile.beingDrawn ) {
continue;
} else if ( !worstTile ) {
worstTile = prevTile;
worstTileIndex = i;
continue;
}
prevTime = prevTile.lastTouchTime;
worstTime = worstTile.lastTouchTime;
prevLevel = prevTile.level;
worstLevel = worstTile.level;
if ( prevTime < worstTime ||
( prevTime == worstTime && prevLevel > worstLevel ) ) {
worstTile = prevTile;
worstTileIndex = i;
}
}
if ( worstTile && worstTileIndex >= 0 ) {
worstTile.unload();
insertionIndex = worstTileIndex;
}
drawer.tilesLoaded[ insertionIndex ] = newTile;
}
function positionTile( tile, overlap, viewport, viewportCenter, levelVisibility ){ function positionTile( tile, overlap, viewport, viewportCenter, levelVisibility ){
var boundsTL = tile.bounds.getTopLeft(), var boundsTL = tile.bounds.getTopLeft(),

View File

@ -142,7 +142,14 @@ $.ImageLoader.prototype = {
else { else {
this.jobQueue.push( newJob ); this.jobQueue.push( newJob );
} }
},
/**
* Clear any unstarted image loading jobs from the queue.
* @method
*/
clear: function() {
this.jobQueue = [];
} }
}; };