mirror of
https://github.com/klzgrad/naiveproxy.git
synced 2024-11-24 06:16:30 +03:00
Make a fortune quietly
40e8acb863
SpdyProxyClientSocket waits for 200 OK before returning OK for Connect. Change that behavior to returning OK immediately after CONNECT header. This feature is enabled by default. It should probably be turned on through an interface but that implies passing a flag through deep interface chains right now requiring intrusive changes to multiple places. Design notes: The current approach is better than the obvious TCP Fast Open style fake Connect(). Fast Open should not be used for preconnects as preconnects need actual connections set up. The Naive client does not use preconnects per se (using "...RawConnect") but the user agent will use preconnects and the Naive client has to infer that. Hence there is a need to check the incoming socket for available bytes right before Connect() and configure whether a socket should be connected with Fast Open. But fake Connect() make it difficult to check the incoming socket because it immediately returns and there is not enough time for the first read of the incoming socket to arrive. To check for preconnects it is best to push the first read of the incoming socket to as late as possible. The other (wrong) way of doing that is to pass in an early read callback and call it immediately after sending HEADERS and then send the available bytes right there. This way is wrong because it does not work with late binding, which assumes Connect() is idempotent and causes sockets opened in this way to be potentially bound to the wrong socket requests. The current approach is to return OK in Connect() right after sending HEADERS before getting the reply, which is to be received later. If the reply is received during a subsequent Read() and the reply indicates an error, the error is returned to the callback of the Read(); otherwise the error is ignored with the connection disconnected and subsequent Read() and Write() should discover the disconnection. |
||
|---|---|---|
| android_webview | ||
| apps | ||
| ash | ||
| base | ||
| build | ||
| build_overrides | ||
| buildtools | ||
| cc | ||
| chrome | ||
| chrome_elf | ||
| chromecast | ||
| chromeos | ||
| cloud_print | ||
| components | ||
| content | ||
| courgette | ||
| crypto | ||
| dbus | ||
| device | ||
| extensions | ||
| gin | ||
| google_apis | ||
| google_update | ||
| gpu | ||
| headless | ||
| ios | ||
| ipc | ||
| jingle | ||
| mash | ||
| media | ||
| mojo | ||
| native_client | ||
| native_client_sdk/src | ||
| net | ||
| ppapi | ||
| printing | ||
| remoting | ||
| rlz | ||
| sandbox | ||
| services | ||
| skia | ||
| sql | ||
| storage | ||
| testing | ||
| third_party | ||
| tools | ||
| ui | ||
| url | ||
| v8 | ||
| webrunner | ||
| .clang-format | ||
| .gitattributes | ||
| .gn | ||
| AUTHORS | ||
| BUILD.gn | ||
| LICENSE | ||
| LICENSE.chromium_os | ||