build: Move exclude_unwind_tables back into declare_args

There is desire to adjust this flag manually.

BUG=762629
R=thakis@chromium.org

Change-Id: I3bd134c19270cd1f729b3ea078674e734493d4ab
This commit is contained in:
klzgrad 2018-08-11 01:31:58 +00:00
parent 63b75aeb02
commit d3a90a97a7

View File

@ -72,19 +72,18 @@ declare_args() {
# It's currently not possible to collect AFDO profiles on anything but # It's currently not possible to collect AFDO profiles on anything but
# x86{,_64}. # x86{,_64}.
using_mismatched_sample_profile = current_cpu != "x64" && current_cpu != "x86" using_mismatched_sample_profile = current_cpu != "x64" && current_cpu != "x86"
# Exclude unwind tables for official builds as unwinding can be done from
# stack dumps produced by Crashpad at a later time "offline" in the crash
# server. For unofficial (e.g. development) builds and non-Chrome branded
# (e.g. Cronet which doesn't use Crashpad, crbug.com/479283) builds it's
# useful to be able to unwind at runtime.
exclude_unwind_tables = (is_chrome_branded && is_official_build) ||
(is_chromecast && !is_cast_desktop_build && !is_debug)
} }
assert(!is_cfi || use_thin_lto, "CFI requires ThinLTO") assert(!is_cfi || use_thin_lto, "CFI requires ThinLTO")
# Exclude unwind tables for official builds as unwinding can be done from stack
# dumps produced by Crashpad at a later time "offline" in the crash server.
# For unofficial (e.g. development) builds and non-Chrome branded (e.g. Cronet
# which doesn't use Crashpad, crbug.com/479283) builds it's useful to be able
# to unwind at runtime.
exclude_unwind_tables =
(is_chrome_branded && is_official_build) ||
(is_chromecast && !is_cast_desktop_build && !is_debug && !is_fuchsia)
# If true, optimize for size. Does not affect windows builds. # If true, optimize for size. Does not affect windows builds.
# Linux & Mac favor speed over size. # Linux & Mac favor speed over size.
# TODO(brettw) it's weird that Mac and desktop Linux are different. We should # TODO(brettw) it's weird that Mac and desktop Linux are different. We should