build: Move exclude_unwind_tables back into declare_args

There is desire to adjust this flag manually.

BUG=762629
R=thakis@chromium.org

Change-Id: I3bd134c19270cd1f729b3ea078674e734493d4ab
This commit is contained in:
klzgrad 2018-08-11 01:31:58 +00:00
parent dd6f8c8192
commit c983975d02

View File

@ -83,23 +83,24 @@ declare_args() {
# x86{,_64}. # x86{,_64}.
using_mismatched_sample_profile = current_cpu != "x64" && current_cpu != "x86" using_mismatched_sample_profile = current_cpu != "x64" && current_cpu != "x86"
# Whether an error should be raised on attempts to make debug builds with # Whether an error should be raised on attempts to make debug builds with
# is_component_build=false. Very large debug symbols can have unwanted side # is_component_build=false. Very large debug symbols can have unwanted side
# effects so this is enforced by default for chromium. # effects so this is enforced by default for chromium.
forbid_non_component_debug_builds = build_with_chromium forbid_non_component_debug_builds = build_with_chromium
# Exclude unwind tables for official builds as unwinding can be done from
# stack dumps produced by Crashpad at a later time "offline" in the crash
# server. For unofficial (e.g. development) builds and non-Chrome branded
# (e.g. Cronet which doesn't use Crashpad, crbug.com/479283) builds it's
# useful to be able to unwind at runtime.
exclude_unwind_tables = is_official_build ||
(is_chromecast && !is_cast_desktop_build &&
!is_debug && !cast_is_debug && !is_fuchsia)
} }
assert(!is_cfi || use_thin_lto, "CFI requires ThinLTO") assert(!is_cfi || use_thin_lto, "CFI requires ThinLTO")
# Exclude unwind tables for official builds as unwinding can be done from stack
# dumps produced by Crashpad at a later time "offline" in the crash server.
# For unofficial (e.g. development) builds and non-Chrome branded (e.g. Cronet
# which doesn't use Crashpad, crbug.com/479283) builds it's useful to be able
# to unwind at runtime.
exclude_unwind_tables =
is_official_build || (is_chromecast && !is_cast_desktop_build &&
!is_debug && !cast_is_debug && !is_fuchsia)
# If true, optimize for size. Does not affect windows builds. # If true, optimize for size. Does not affect windows builds.
# Linux & Mac favor speed over size. # Linux & Mac favor speed over size.
# TODO(brettw) it's weird that Mac and desktop Linux are different. We should # TODO(brettw) it's weird that Mac and desktop Linux are different. We should