From a044a852b31cd8258845bb8e2a325e67fddb0d9a Mon Sep 17 00:00:00 2001 From: klzgrad Date: Sat, 11 Aug 2018 01:31:58 +0000 Subject: [PATCH] build: Move exclude_unwind_tables back into declare_args There is desire to adjust this flag manually. BUG=762629 R=thakis@chromium.org Change-Id: I3bd134c19270cd1f729b3ea078674e734493d4ab --- src/build/config/compiler/compiler.gni | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/build/config/compiler/compiler.gni b/src/build/config/compiler/compiler.gni index befd9d78b3..7ab09a222e 100644 --- a/src/build/config/compiler/compiler.gni +++ b/src/build/config/compiler/compiler.gni @@ -75,23 +75,24 @@ declare_args() { # x86{,_64}. using_mismatched_sample_profile = current_cpu != "x64" && current_cpu != "x86" + # Whether an error should be raised on attempts to make debug builds with # is_component_build=false. Very large debug symbols can have unwanted side # effects so this is enforced by default for chromium. forbid_non_component_debug_builds = build_with_chromium + + # Exclude unwind tables for official builds as unwinding can be done from + # stack dumps produced by Crashpad at a later time "offline" in the crash + # server. For unofficial (e.g. development) builds and non-Chrome branded + # (e.g. Cronet which doesn't use Crashpad, crbug.com/479283) builds it's + # useful to be able to unwind at runtime. + exclude_unwind_tables = is_official_build || + (is_chromecast && !is_cast_desktop_build && + !is_debug && !cast_is_debug && !is_fuchsia) } assert(!is_cfi || use_thin_lto, "CFI requires ThinLTO") -# Exclude unwind tables for official builds as unwinding can be done from stack -# dumps produced by Crashpad at a later time "offline" in the crash server. -# For unofficial (e.g. development) builds and non-Chrome branded (e.g. Cronet -# which doesn't use Crashpad, crbug.com/479283) builds it's useful to be able -# to unwind at runtime. -exclude_unwind_tables = - is_official_build || (is_chromecast && !is_cast_desktop_build && - !is_debug && !cast_is_debug && !is_fuchsia) - # If true, optimize for size. Does not affect windows builds. # Linux & Mac favor speed over size. # TODO(brettw) it's weird that Mac and desktop Linux are different. We should