build: Move exclude_unwind_tables back into declare_args

There is desire to adjust this flag manually.

BUG=762629
R=thakis@chromium.org

Change-Id: I3bd134c19270cd1f729b3ea078674e734493d4ab
This commit is contained in:
Paul Jensen 2017-10-11 08:37:34 -04:00 committed by klzgrad
parent 19bc836227
commit 96606bf48d

View File

@ -68,18 +68,18 @@ declare_args() {
# Whether or not we should use position independent code. # Whether or not we should use position independent code.
use_pic = true use_pic = true
# Exclude unwind tables for official builds as unwinding can be done from
# stack dumps produced by Crashpad at a later time "offline" in the crash
# server. For unofficial (e.g. development) builds and non-Chrome branded
# (e.g. Cronet which doesn't use Crashpad, crbug.com/479283) builds it's
# useful to be able to unwind at runtime.
exclude_unwind_tables = (is_chrome_branded && is_official_build) ||
(is_chromecast && !is_cast_desktop_build && !is_debug)
} }
assert(!is_cfi || use_thin_lto, "CFI requires ThinLTO") assert(!is_cfi || use_thin_lto, "CFI requires ThinLTO")
# Exclude unwind tables for official builds as unwinding can be done from stack
# dumps produced by Crashpad at a later time "offline" in the crash server.
# For unofficial (e.g. development) builds and non-Chrome branded (e.g. Cronet
# which doesn't use Crashpad, crbug.com/479283) builds it's useful to be able
# to unwind at runtime.
exclude_unwind_tables = (is_chrome_branded && is_official_build) ||
(is_chromecast && !is_cast_desktop_build && !is_debug)
# If true, optimize for size. Does not affect windows builds. # If true, optimize for size. Does not affect windows builds.
# Linux & Mac favor speed over size. # Linux & Mac favor speed over size.
# TODO(brettw) it's weird that Mac and desktop Linux are different. We should # TODO(brettw) it's weird that Mac and desktop Linux are different. We should