mirror/naiveproxy
1
0
Fork 0
mirror of https://github.com/klzgrad/naiveproxy.git synced 2024-11-29 00:36:10 +03:00
Code Issues Projects Releases Wiki Activity

build: Don't fix Y2038 problem with icu

Browse Source
This commit is contained in:
klzgrad 2020-11-18 22:51:53 +08:00
parent 99f54ca160
commit 6f7946adc2
3 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/base/BUILD.gn
View File

@ -2164,7 +2164,7 @@ component("base") {
# TODO(b/167763382) Find an alternate solution for Chromecast devices, since # TODO(b/167763382) Find an alternate solution for Chromecast devices, since
# adding the icui18n dep significantly increases the binary size. # adding the icui18n dep significantly increases the binary size.
if (!is_chromecast) { if (false) {
sources += [ "time/time_exploded_icu.cc" ] sources += [ "time/time_exploded_icu.cc" ]
# The ICU dependency is only needed on systems with a 32-bit time_t. # The ICU dependency is only needed on systems with a 32-bit time_t.

2
src/base/time/time.h
View File

@ -792,6 +792,7 @@ class BASE_EXPORT Time : public time_internal::TimeBase<Time> {
// Some platforms use the ICU library to provide To/FromExploded, when their // Some platforms use the ICU library to provide To/FromExploded, when their
// native library implementations are insufficient in some way. // native library implementations are insufficient in some way.
#if 0
static void ExplodeUsingIcu(int64_t millis_since_unix_epoch, static void ExplodeUsingIcu(int64_t millis_since_unix_epoch,
bool is_local, bool is_local,
Exploded* exploded); Exploded* exploded);
@ -799,6 +800,7 @@ class BASE_EXPORT Time : public time_internal::TimeBase<Time> {
const Exploded& exploded, const Exploded& exploded,
int64_t* millis_since_unix_epoch) int64_t* millis_since_unix_epoch)
WARN_UNUSED_RESULT; WARN_UNUSED_RESULT;
#endif
// Rounds down the time to the nearest day in either local time // Rounds down the time to the nearest day in either local time
// |is_local = true| or UTC |is_local = false|. // |is_local = true| or UTC |is_local = false|.

2
src/base/time/time_exploded_posix.cc
View File

@ -125,6 +125,7 @@ void Time::Explode(bool is_local, Exploded* exploded) const {
const int64_t millis_since_unix_epoch = const int64_t millis_since_unix_epoch =
ToRoundedDownMillisecondsSinceUnixEpoch(); ToRoundedDownMillisecondsSinceUnixEpoch();
#if 0
// For systems with a Y2038 problem, use ICU as the Explode() implementation. // For systems with a Y2038 problem, use ICU as the Explode() implementation.
if (sizeof(SysTime) < 8) { if (sizeof(SysTime) < 8) {
// TODO(b/167763382) Find an alternate solution for Chromecast devices, since // TODO(b/167763382) Find an alternate solution for Chromecast devices, since
@ -134,6 +135,7 @@ void Time::Explode(bool is_local, Exploded* exploded) const {
return; return;
#endif // !BUILDFLAG(IS_CHROMECAST) #endif // !BUILDFLAG(IS_CHROMECAST)
} }
#endif
// Split the |millis_since_unix_epoch| into separate seconds and millisecond // Split the |millis_since_unix_epoch| into separate seconds and millisecond
// components because the platform calendar-explode operates at one-second // components because the platform calendar-explode operates at one-second