From 62c17aaf51b70f5c2f44160b23e37c1482035bf0 Mon Sep 17 00:00:00 2001 From: klzgrad Date: Mon, 23 May 2022 20:15:49 +0800 Subject: [PATCH] cronet: Support setting socket limits from experimental option Example: Pool type: NORMAL_SOCKET_POOL or WEBSOCKET_SOCKET_POOL. "socket_limits": { "max_sockets_per_pool": { "NORMAL_SOCKET_POOL": 1024 }, "max_sockets_per_proxy_server": {"NORMAL_SOCKET_POOL": 1024 }, "max_sockets_per_group": { "NORMAL_SOCKET_POOL": 1024 } }, --- .../cronet/url_request_context_config.cc | 57 +++++++++++++++++++ 1 file changed, 57 insertions(+) diff --git a/src/components/cronet/url_request_context_config.cc b/src/components/cronet/url_request_context_config.cc index 2b735ef9aa..e3a4acf181 100644 --- a/src/components/cronet/url_request_context_config.cc +++ b/src/components/cronet/url_request_context_config.cc @@ -32,6 +32,7 @@ #include "net/log/net_log.h" #include "net/nqe/network_quality_estimator_params.h" #include "net/reporting/reporting_policy.h" +#include "net/socket/client_socket_pool_manager.h" #include "net/socket/ssl_client_socket.h" #include "net/ssl/ssl_key_logger_impl.h" #include "net/third_party/quiche/src/quiche/quic/core/quic_packets.h" @@ -770,6 +771,62 @@ void URLRequestContextConfig::SetContextBuilderExperimentalOptions( } // Already handled in Cronet_EngineImpl::StartWithParams. // Only checks and reports errors here. + } else if (iter.first == "socket_limits") { + if (!iter.second.is_dict()) { + LOG(ERROR) << "\"" << iter.first << "\" config params \"" << iter.second + << "\" is not a dictionary value"; + effective_experimental_options.erase(iter.first); + continue; + } + bool has_errors = false; + for (const auto limit : iter.second.GetDict()) { + void (*set_limit)(net::HttpNetworkSession::SocketPoolType pool_type, + int socket_count); + if (limit.first == "max_sockets_per_pool") { + set_limit = &net::ClientSocketPoolManager::set_max_sockets_per_pool; + } else if (limit.first == "max_sockets_per_proxy_server") { + set_limit = + &net::ClientSocketPoolManager::set_max_sockets_per_proxy_server; + } else if (limit.first == "max_sockets_per_group") { + set_limit = &net::ClientSocketPoolManager::set_max_sockets_per_group; + } else { + has_errors = true; + break; + } + if (!limit.second.is_dict()) { + has_errors = true; + break; + } + for (const auto pool_count : limit.second.GetDict()) { + net::HttpNetworkSession::SocketPoolType pool_type; + if (pool_count.first == "NORMAL_SOCKET_POOL") { + pool_type = net::HttpNetworkSession::NORMAL_SOCKET_POOL; + } else if (pool_count.first == "WEBSOCKET_SOCKET_POOL") { + pool_type = net::HttpNetworkSession::WEBSOCKET_SOCKET_POOL; + } else { + LOG(ERROR) << "Invalid pool_type " << pool_count.first; + has_errors = true; + break; + } + + absl::optional socket_count = pool_count.second.GetIfInt(); + if (!socket_count.has_value() || socket_count.value() <= 0) { + LOG(ERROR) << "Invalid socket_count " << pool_count.second; + has_errors = true; + break; + } + + set_limit(pool_type, socket_count.value()); + } + if (has_errors) + break; + } + if (has_errors) { + LOG(ERROR) << "\"" << iter.first << "\" config params \"" << iter.second + << "\" has invalid value"; + effective_experimental_options.erase(iter.first); + continue; + } } else { LOG(WARNING) << "Unrecognized Cronet experimental option \"" << iter.first << "\" with params \"" << iter.second;