From 463769fcd0dad248420d295b1ff0369dc1044ba7 Mon Sep 17 00:00:00 2001 From: klzgrad Date: Sat, 24 Apr 2021 08:18:21 +0800 Subject: [PATCH] url: Remove perfetto tracing --- src/url/gurl.cc | 5 ----- src/url/gurl.h | 3 --- src/url/origin.cc | 5 ----- src/url/origin.h | 3 --- 4 files changed, 16 deletions(-) diff --git a/src/url/gurl.cc b/src/url/gurl.cc index 06495e43e8..a44e3d7ee5 100644 --- a/src/url/gurl.cc +++ b/src/url/gurl.cc @@ -16,7 +16,6 @@ #include "base/strings/string_piece.h" #include "base/strings/string_util.h" #include "base/trace_event/memory_usage_estimator.h" -#include "third_party/perfetto/include/perfetto/tracing/traced_value.h" #include "url/url_canon_stdstring.h" #include "url/url_util.h" @@ -512,10 +511,6 @@ bool GURL::IsAboutPath(base::StringPiece actual_path, return false; } -void GURL::WriteIntoTrace(perfetto::TracedValue context) const { - std::move(context).WriteString(possibly_invalid_spec()); -} - std::ostream& operator<<(std::ostream& out, const GURL& url) { return out << url.possibly_invalid_spec(); } diff --git a/src/url/gurl.h b/src/url/gurl.h index 86a340a8c5..e8559baa6e 100644 --- a/src/url/gurl.h +++ b/src/url/gurl.h @@ -14,7 +14,6 @@ #include "base/component_export.h" #include "base/debug/alias.h" #include "base/strings/string_piece.h" -#include "third_party/perfetto/include/perfetto/tracing/traced_value_forward.h" #include "url/third_party/mozilla/url_parse.h" #include "url/url_canon.h" #include "url/url_canon_stdstring.h" @@ -443,8 +442,6 @@ class COMPONENT_EXPORT(URL) GURL { static bool IsAboutPath(base::StringPiece actual_path, base::StringPiece allowed_path); - void WriteIntoTrace(perfetto::TracedValue context) const; - private: // Variant of the string parsing constructor that allows the caller to elect // retain trailing whitespace, if any, on the passed URL spec, but only if diff --git a/src/url/origin.cc b/src/url/origin.cc index 2b9b92f2b2..845a95980a 100644 --- a/src/url/origin.cc +++ b/src/url/origin.cc @@ -19,7 +19,6 @@ #include "base/strings/string_number_conversions.h" #include "base/strings/string_piece.h" #include "base/strings/string_util.h" -#include "third_party/perfetto/include/perfetto/tracing/traced_value.h" #include "url/gurl.h" #include "url/url_canon.h" #include "url/url_canon_stdstring.h" @@ -375,10 +374,6 @@ absl::optional Origin::Deserialize(const std::string& value) { return origin; } -void Origin::WriteIntoTrace(perfetto::TracedValue context) const { - std::move(context).WriteString(GetDebugString()); -} - std::ostream& operator<<(std::ostream& out, const url::Origin& origin) { out << origin.GetDebugString(); return out; diff --git a/src/url/origin.h b/src/url/origin.h index 17cadf356b..e33074f147 100644 --- a/src/url/origin.h +++ b/src/url/origin.h @@ -19,7 +19,6 @@ #include "build/build_config.h" #include "ipc/ipc_param_traits.h" #include "third_party/abseil-cpp/absl/types/optional.h" -#include "third_party/perfetto/include/perfetto/tracing/traced_value_forward.h" #include "url/scheme_host_port.h" #include "url/third_party/mozilla/url_parse.h" #include "url/url_canon.h" @@ -295,8 +294,6 @@ class COMPONENT_EXPORT(URL) Origin { const base::android::JavaRef& java_origin); #endif // OS_ANDROID - void WriteIntoTrace(perfetto::TracedValue context) const; - private: friend class blink::SecurityOrigin; // SchemefulSite needs access to the serialization/deserialization logic which