Wrap base::Value::{Dict,List}}:WriteIntoTrace() with correct #ifs.

This commit is contained in:
klzgrad 2022-08-06 13:05:21 +08:00
parent e88e6005a8
commit 3555c20a1e

View File

@ -789,12 +789,14 @@ std::string Value::Dict::DebugString() const {
return DebugStringImpl(*this); return DebugStringImpl(*this);
} }
#if BUILDFLAG(ENABLE_BASE_TRACING)
void Value::Dict::WriteIntoTrace(perfetto::TracedValue context) const { void Value::Dict::WriteIntoTrace(perfetto::TracedValue context) const {
perfetto::TracedDictionary dict = std::move(context).WriteDictionary(); perfetto::TracedDictionary dict = std::move(context).WriteDictionary();
for (auto kv : *this) { for (auto kv : *this) {
dict.Add(perfetto::DynamicString(kv.first), kv.second); dict.Add(perfetto::DynamicString(kv.first), kv.second);
} }
} }
#endif // BUILDFLAG(ENABLE_BASE_TRACING)
Value::Dict::Dict( Value::Dict::Dict(
const flat_map<std::string, std::unique_ptr<Value>>& storage) { const flat_map<std::string, std::unique_ptr<Value>>& storage) {
@ -999,12 +1001,14 @@ std::string Value::List::DebugString() const {
return DebugStringImpl(*this); return DebugStringImpl(*this);
} }
#if BUILDFLAG(ENABLE_BASE_TRACING)
void Value::List::WriteIntoTrace(perfetto::TracedValue context) const { void Value::List::WriteIntoTrace(perfetto::TracedValue context) const {
perfetto::TracedArray array = std::move(context).WriteArray(); perfetto::TracedArray array = std::move(context).WriteArray();
for (const auto& item : *this) { for (const auto& item : *this) {
array.Append(item); array.Append(item);
} }
} }
#endif // BUILDFLAG(ENABLE_BASE_TRACING)
Value::List::List(const std::vector<Value>& storage) { Value::List::List(const std::vector<Value>& storage) {
storage_.reserve(storage.size()); storage_.reserve(storage.size());