base: Don't fix Y2038 problem with icu

This commit is contained in:
klzgrad 2020-11-18 22:51:53 +08:00
parent 2a71e574db
commit 2b6a27fff3
3 changed files with 4 additions and 2 deletions

View File

@ -2156,7 +2156,7 @@ component("base") {
# TODO(b/167763382) Find an alternate solution for Chromecast devices, since # TODO(b/167763382) Find an alternate solution for Chromecast devices, since
# adding the icui18n and icuuc deps significantly increases the binary size. # adding the icui18n and icuuc deps significantly increases the binary size.
if (!is_chromecast) { if (false) {
sources += [ "time/time_exploded_icu.cc" ] sources += [ "time/time_exploded_icu.cc" ]
# The ICU dependency is only needed on systems with a 32-bit time_t. # The ICU dependency is only needed on systems with a 32-bit time_t.

View File

@ -816,6 +816,7 @@ class BASE_EXPORT Time : public time_internal::TimeBase<Time> {
// Some platforms use the ICU library to provide To/FromExploded, when their // Some platforms use the ICU library to provide To/FromExploded, when their
// native library implementations are insufficient in some way. // native library implementations are insufficient in some way.
#if 0
static void ExplodeUsingIcu(int64_t millis_since_unix_epoch, static void ExplodeUsingIcu(int64_t millis_since_unix_epoch,
bool is_local, bool is_local,
Exploded* exploded); Exploded* exploded);
@ -823,6 +824,7 @@ class BASE_EXPORT Time : public time_internal::TimeBase<Time> {
const Exploded& exploded, const Exploded& exploded,
int64_t* millis_since_unix_epoch) int64_t* millis_since_unix_epoch)
WARN_UNUSED_RESULT; WARN_UNUSED_RESULT;
#endif
// Rounds down the time to the nearest day in either local time // Rounds down the time to the nearest day in either local time
// |is_local = true| or UTC |is_local = false|. // |is_local = true| or UTC |is_local = false|.

View File

@ -129,7 +129,7 @@ void Time::Explode(bool is_local, Exploded* exploded) const {
if (sizeof(SysTime) < 8) { if (sizeof(SysTime) < 8) {
// TODO(b/167763382) Find an alternate solution for Chromecast devices, since // TODO(b/167763382) Find an alternate solution for Chromecast devices, since
// adding the icui18n dep significantly increases the binary size. // adding the icui18n dep significantly increases the binary size.
#if !BUILDFLAG(IS_CHROMECAST) #if 0
ExplodeUsingIcu(millis_since_unix_epoch, is_local, exploded); ExplodeUsingIcu(millis_since_unix_epoch, is_local, exploded);
return; return;
#endif // !BUILDFLAG(IS_CHROMECAST) #endif // !BUILDFLAG(IS_CHROMECAST)