From 0059164b519f172e3102f9f998e0f966fe1c24a2 Mon Sep 17 00:00:00 2001 From: klzgrad Date: Sun, 16 May 2021 00:47:27 +0800 Subject: [PATCH] cert: Handle AIA response in PKCS#7 format --- .../cert/internal/cert_issuer_source_aia.cc | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/net/cert/internal/cert_issuer_source_aia.cc b/src/net/cert/internal/cert_issuer_source_aia.cc index 7892006f4e..4418707a7c 100644 --- a/src/net/cert/internal/cert_issuer_source_aia.cc +++ b/src/net/cert/internal/cert_issuer_source_aia.cc @@ -9,6 +9,7 @@ #include "net/cert/cert_net_fetcher.h" #include "net/cert/internal/cert_errors.h" #include "net/cert/pem.h" +#include "net/cert/x509_certificate.h" #include "net/cert/x509_util.h" #include "url/gurl.h" @@ -113,6 +114,23 @@ bool AiaRequest::AddCompletedFetchToResults(Error error, // // TODO(mattm): Is supporting CMS message format important? + // Handles PKCS#7 encoded certificates + CertificateList certs = X509Certificate::CreateCertificateListFromBytes( + reinterpret_cast(fetched_bytes.data()), fetched_bytes.size(), + X509Certificate::FORMAT_AUTO); + bool certs_ok = false; + for (const auto& cert : certs) { + auto parsed = ParsedCertificate::Create( + bssl::UpRef(cert->cert_buffer()), + x509_util::DefaultParseCertificateOptions(), /*errors=*/nullptr); + if (parsed) { + results->push_back(parsed); + certs_ok = true; + } + } + if (certs_ok) + return true; + // TODO(https://crbug.com/870359): Some AIA responses are served as PEM, which // is not part of RFC 5280's profile. return ParseCertFromDer(fetched_bytes.data(), fetched_bytes.size(),