mirror/iodine
1
0
Fork 0
mirror of https://github.com/yarrick/iodine.git synced 2024-11-29 08:26:08 +03:00
Code Issues Projects Releases Wiki Activity

Fix data length in encoding dns queries

Browse Source
This commit is contained in:
Erik Ekman 2009-09-20 15:41:24 +00:00 committed by Erik Ekman
parent d4d88d2ad0
commit 5951166b36
2 changed files with 38 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/dns.c
View File

@ -90,8 +90,7 @@ dns_encode(char *buf, size_t buflen, struct query *q, qr_t qr, char *data, size_
putshort(&p, C_IN); putshort(&p, C_IN);
putlong(&p, 0); /* TTL */ putlong(&p, 0); /* TTL */
if (q->type == T_CNAME || q->type == T_A || q->type == T_MX) if (q->type == T_CNAME || q->type == T_A || q->type == T_MX) {
{
/* data is expected to be like "Hblabla.host.name.com\0" */ /* data is expected to be like "Hblabla.host.name.com\0" */
char *startp = p; char *startp = p;
@ -106,9 +105,7 @@ dns_encode(char *buf, size_t buflen, struct query *q, qr_t qr, char *data, size_
namelen = p - startp; namelen = p - startp;
namelen -= 2; namelen -= 2;
putshort(&startp, namelen); putshort(&startp, namelen);
} } else if (q->type == T_TXT) {
else if (q->type == T_TXT)
{
/* TXT has binary or base-X data */ /* TXT has binary or base-X data */
char *startp = p; char *startp = p;
int txtlen; int txtlen;
@ -119,9 +116,7 @@ dns_encode(char *buf, size_t buflen, struct query *q, qr_t qr, char *data, size_
txtlen = p - startp; txtlen = p - startp;
txtlen -= 2; txtlen -= 2;
putshort(&startp, txtlen); putshort(&startp, txtlen);
} } else {
else
{
/* NULL has raw binary data */ /* NULL has raw binary data */
datalen = MIN(datalen, buflen - (p - buf)); datalen = MIN(datalen, buflen - (p - buf));
CHECKLEN(2); CHECKLEN(2);
@ -130,7 +125,6 @@ dns_encode(char *buf, size_t buflen, struct query *q, qr_t qr, char *data, size_
putdata(&p, data, datalen); putdata(&p, data, datalen);
CHECKLEN(0); CHECKLEN(0);
} }
break; break;
case QR_QUERY: case QR_QUERY:
/* Note that iodined also uses this for forward queries */ /* Note that iodined also uses this for forward queries */
@ -138,7 +132,8 @@ dns_encode(char *buf, size_t buflen, struct query *q, qr_t qr, char *data, size_
header->qdcount = htons(1); header->qdcount = htons(1);
header->arcount = htons(1); header->arcount = htons(1);
putname(&p, buflen - (p - buf), data); datalen = MIN(datalen, buflen - (p - buf));
putname(&p, datalen, data);
CHECKLEN(4); CHECKLEN(4);
putshort(&p, q->type); putshort(&p, q->type);

6
tests/dns.c
View File

@ -69,8 +69,9 @@ START_TEST(test_encode_query)
char *d; char *d;
size_t len; size_t len;
int ret; int ret;
int enclen;
len = sizeof(buf); enclen = sizeof(resolv);
memset(&buf, 0, sizeof(buf)); memset(&buf, 0, sizeof(buf));
memset(&resolv, 0, sizeof(resolv)); memset(&resolv, 0, sizeof(resolv));
memset(&q, 0, sizeof(struct query)); memset(&q, 0, sizeof(struct query));
@ -80,12 +81,13 @@ START_TEST(test_encode_query)
enc = get_base32_encoder(); enc = get_base32_encoder();
*d++ = 'A'; *d++ = 'A';
enc->encode(d, &len, innerData, strlen(innerData)); enc->encode(d, &enclen, innerData, strlen(innerData));
d = resolv + strlen(resolv); d = resolv + strlen(resolv);
if (*d != '.') { if (*d != '.') {
*d++ = '.'; *d++ = '.';
} }
strcpy(d, topdomain); strcpy(d, topdomain);
len = sizeof(buf);
ret = dns_encode(buf, len, &q, QR_QUERY, resolv, strlen(resolv)); ret = dns_encode(buf, len, &q, QR_QUERY, resolv, strlen(resolv));
len = sizeof(query_packet) - 1; /* Skip extra null character */ len = sizeof(query_packet) - 1; /* Skip extra null character */