Update circuit-breaker.md

stability/circuit-breaker.md

@@ -60,45 +60,52 @@ import (
     "time"
 )
 
+type State int
+
+const (
+	UnknownState State = iota
+	FailureState
+	SuccessState
+)
+
+type Counter interface {
+	Count(State)
+	ConsecutiveFailures() uint32
+	LastActivity() time.Time
+	Reset()
+}
+
 type Circuit func(context.Context) error
 
-func Breaker(c Circuit, failureThreshold uint32) Circuit {
+var canRetry = func(cnt counters, failureThreshold uint32) bool {
-    cnt := NewCounter()
+	backoffLevel := cnt.ConsecutiveFailures - failureThreshold
-	expired := time.Now()
+	// Calculates when should the circuit breaker resume propagating requests
-	currentState := StateClosed
+	// to the service
+	shouldRetryAt := cnt.LastActivity().Add(time.Second << backoffLevel)
+	return time.Now().After(shouldRetryAt)
+}
 
+func Breaker(c Circuit, failureThreshold uint32) Circuit {
+	cnt := counters{}
+
+	//ctx can be used hold parameters
 	return func(ctx context.Context) error {
 
-
+		if cnt.ConsecutiveFailures >= failureThreshold {
-		//handle statue transformation for timeout
+			if !canRetry(cnt, failureThreshold) {
-		if currentState == StateOpen {
+				// Fails fast instead of propagating requests to the circuit since
-			nowt := time.Now()
+				// not enough time has passed since the last failure to retry
-			if expired.Before(nowt) || expired.Equal(nowt) {
-				currentState = StateHalfOpen 
-				cnt.ConsecutiveSuccesses = 0 
-			}
-		}
-
-		switch currentState {
-		case StateOpen:
 				return ErrServiceUnavailable
-		case StateHalfOpen:
-			if err := c(ctx); err != nil {
-				currentState = StateOpen
-				expired = time.Now().Add(defaultTimeout) //Reset
-				return err
 			}
-			cnt.Count(SuccessState)
-			if cnt.ConsecutiveSuccesses > defaultSuccessThreshold {
-				currentState = StateClosed
-				cnt.ConsecutiveFailures = 0
 		}
-
+		// Unless the failure threshold is exceeded the wrapped service mimics the
-		case StateClosed:
+		// old behavior and the difference in behavior is seen after consecutive failures
 	         if err := c(ctx); err != nil {
 			cnt.Count(FailureState)
+			return err
 		}
-		}
+
+		cnt.Count(SuccessState)
 		return nil
 	}
 }