Kevin Brown
43a598b372
Merge pull request #2216 from lboynton/fix-search-focus-on-mobile
...
Fix search focus on mobile
2014-04-03 08:44:45 -04:00
Matthias Kurz
dcabde40c3
Prevent the cursor from setting it to initial position in IE
2014-04-03 12:19:37 +02:00
Matthias Kurz
ddcb61585a
.destroy() should destroy all selected select2
2014-04-03 10:59:21 +02:00
David Foster
3ce3ad7fb0
Allow an empty string to be used as the placeholder title.
2014-04-01 14:22:41 -07:00
Lee Boynton
2d6b74c2ac
Also check if search input should be focussed for multiselects
2014-03-31 21:01:06 +01:00
Lee Boynton
ed0bae39c9
Check if search should be focused when the dropdown is activated
2014-03-28 14:56:45 +00:00
Lee Boynton
ad21d01693
Check if search input should be focussed when opening
2014-03-28 14:46:41 +00:00
pineapple-thief
70873abe9d
Update select2.js
...
Fixes unpleasant glitch where initializing select2 on select where first input option tag has non-breakable space in innerText causes selected option to be displayed as "undefined" until user changes selection. (i.e. HTML was like <option value> </option>, that's what Rails 3 f.select helper generate by default).
2014-03-28 15:45:38 +11:00
Kevin Brown
2752563c80
Merge pull request #2096 from springboardretail/mobile-fixes
...
make selection on iOS more intuitive
2014-03-21 20:36:40 -04:00
Kevin Brown
63f342a12f
Revert "Add hideSelectionFromResult function"
...
This reverts commit 84cf134a4e
.
New problems found in:
https://github.com/ivaynberg/select2/issues/2196
Original issue:
https://github.com/ivaynberg/select2/issues/1538
Pull request:
https://github.com/ivaynberg/select2/pull/2032
2014-03-21 19:50:30 -04:00
Diogo Trentini
6c731f4181
Fix method to get space above the dropdown
...
It's better to get the scrollTop value from window rather than body
to update enoughRoomAbove variable. This method is supported by
the main browsers.
2014-03-20 21:45:41 -03:00
Adam Schepis
eb09dfcce0
make selection on iOS more intuitive
...
allow touchend to cause selection of touched item.
Detect touchmove events so that selection of touched item can be canceled
2014-03-13 22:24:19 -04:00
Matt Slocum
2342d91925
Fix Focus war with modals
...
Bootstrap modal (and maybe others) require focus to maintain in the modal (because that what a modal is). The dropdown is outside of the modal, so we need to stopPropagation on the event so the modal doesn't know.
2014-03-11 12:14:17 -06:00
Kevin Brown
2d906ee10f
Merge pull request #2140 from ivaynberg/issue_1541
...
Add `shouldFocusInput` option [Fix #1541 ]
2014-03-07 10:14:32 -05:00
Kevin Brown
51e5d436ff
Merge pull request #2160 from s7anley/bugfix/2073-select2-removing
...
Multiselect items are not removed when event is prevented
2014-03-07 10:12:01 -05:00
Coleman Watts
43e381ed37
Provide context for evaluated functions
2014-03-05 21:02:06 -05:00
Kevin Brown
e6fbfcd101
Merge pull request #2125 from colemanw/evaluateFix
...
Fix evaluation of formatLoadMore
2014-03-05 20:57:43 -05:00
Ján Koščo
f3c6d6d51f
After prevented removing of item in multiselect, proper item is focused
2014-03-05 11:27:08 +01:00
Ján Koščo
86a9c79b04
Removed unnecessary animation during unseint multiselect by close button
2014-03-05 11:27:03 +01:00
Ján Koščo
2059b5d4d3
Unselected item is returned as options only if event isn't prevented
2014-03-05 11:26:50 +01:00
Daniel Norman
660643ae87
Fix a typo in the docs.
2014-02-28 11:21:53 +01:00
dhardtke
60359f9d43
fix select2 csp errors / warnings
2014-02-27 20:07:57 +01:00
Kevin Brown
d87e93dd45
Add shouldFocusInput
option [ Fix #1541 ]
...
This adds a `shouldFocusInput` option that determines whether or
not the focusser should be automatically focused. By default, the
focusser will always be focused, unless `minimumResultsForSearch`
is less than zero.
`close` on single selects took an option `params` argument which
at one point was used to tell the focusser to not automatically
focus. This was added at one point when tweaking the mask [1]
and later reverted to fix a bug that came as a result [2]. The
leftovers of this code has been removed in this commit.
[1]: e162a4802c
[2]: 9bc68f089e
2014-02-21 20:06:21 -05:00
Pete Campbell
2a4e026b49
Bugfix - only selected options that are not disabled should be used when initializing the dropdown
2014-02-17 21:16:26 -05:00
Coleman Watts
9460b0c9b6
Fix evaluation of formatLoadMore
2014-02-14 17:14:12 -08:00
Kevin Brown
3c28c35503
Merge pull request #2095 from mkurz/readonly_chaining
...
Allow chaining for .select2('readonly', ...)
2014-02-03 15:46:53 -08:00
Matthias Kurz
bd3bd55719
Allow chaining for .select2('readonly', ...)
2014-02-03 16:07:23 +01:00
Coleman Watts
175c78441f
Accept strings as well as functions for localization
2014-01-31 21:04:36 -08:00
Jeanmonod David
ed77cab7d5
Allow to display item created by createSearchChoice at the end of the list
...
ref #595
2014-01-24 18:54:56 +01:00
jdecuyper
c87615f14c
The function hideSelectionFromResult was tested against undefined as a property and not as a function
2014-01-21 11:45:13 -06:00
Kevin Brown
0f1372ce72
Merge pull request #1733 from flyerhzm/append-label-only-when-formatted-defined
...
append label only when formatted is not undefined
2014-01-21 05:49:36 -08:00
Marchenko Alexandr
89ae701691
merge
2014-01-21 12:17:58 +02:00
Marchenko Alexandr
2e901f79a1
merge
2014-01-21 11:54:48 +02:00
Kevin Brown
e559f92c35
Merge pull request #2001 from arendjr/master
...
Don't rely on :visible and :not(..., ...) selectors which only work with Sizzle
2014-01-20 16:48:27 -08:00
Marchenko Alexandr
f4886a0afa
Optional Search Input Placeholder parameter added
2014-01-20 11:38:33 +02:00
jdecuyper
84cf134a4e
Add hideSelectionFromResult function
2014-01-19 21:12:39 -06:00
Tim Robertson
eaf09c7f76
Accessibility updates based on jQuery UI Autocomplete
2014-01-19 18:52:56 -05:00
Sebastian Kather
48d392635f
singleSelect: setting nextSearchTerm in initSelection
...
For single select the nextSearchTerm callback is called when
initSelection returned data
2014-01-16 16:12:00 +01:00
Steven Armstrong
829b8c7346
Changed default text for min number of characters.
...
Use to read:
Please enter 3 more characters.
Now reads:
Please enter 3 or more characters.
2014-01-13 10:01:30 -05:00
Jonathan Potter
4dce487ccb
Prevent IE from generating unwanted clicks on the body. When mousedown fires on the selection element and then mouseup fires on the mask (because it is moved under the mouse during mousedown) then IE fires a click event on the body because it is the closest common ancestor. To prevent this, we detach and reatach the elements on mousedown which cancels the click event.
2014-01-09 11:30:48 -05:00
Igor Vaynberg
3e5ad1334e
Merge pull request #2020 from merkuriy/master
...
L10n files improved
2014-01-08 15:05:23 -08:00
pj
c22bdd41a0
Removed hardcoded class names from $.fn.select2. The code now uses the exports accessible through window.Select2 to instantiate widgets, allowing the environment to replace or extend those classes globally.
2014-01-08 18:09:14 +02:00
pj
41c3d4cfc4
Removed hardcoded class names from $.fn.select2. The code now uses the exports accessible through window.Select2 to instantiate widgets, allowing the environment to replace or extend those classes globally.
2014-01-08 17:56:23 +02:00
Uriy Efremochkin
fd97e585d7
L10n files and template l10n file were improved: Groups of three characters "." (dots) were replaced by a single character "…" (ellipsis).
2014-01-08 15:35:47 +06:00
Kevin Brown
4eb1370b9c
Merge pull request #1981 from openwide-java/fix-1946-hard_coded_title
...
Fix #1946 : remove an hard coded title attribute.
2014-01-06 18:01:47 -08:00
jdecuyper
c7dd8c5179
Enable nextSearchTerm function for multiple select
2013-12-31 12:01:48 -06:00
Arend van Beelen
a6ec8fc4e1
Don't rely on :visible and :not(..., ...) selectors which only work with Sizzle.
2013-12-30 15:33:46 +01:00
jibwa
92357e61b8
Fix problem with positioning the dropdown when it is on the right hand side of view
...
In the stable version this line looks like:
dropLeft = offset.left + width - dropWidth;
In line (1193) the variable width is set to dropWidth which means we are always going to end up with
dropLeft = offset.left + X - X
or
dropLeft = offset.left
Which means we are still aligned to the left of the button.
This current solution from @ef9f1dea is just aligning the select2-drop closer to the center which is not what it did before the dropdownAutoWidth.
The line I submitted worked perfect and my dropdown now aligns to the RHS of the button again as expected.
2013-12-18 16:28:40 -05:00
Guillaume Smet
3d2b91bd7a
Fix #1946 : remove an hard coded title.
...
The original title is copied if defined and it's sufficient for accessibility purpose.
We shouldn't force the title attribute, it's especially annoying if people are using
tooltip implementation based on the title attribute such as Bootstrap tooltip.
2013-12-17 17:03:10 +01:00
Igor Vaynberg
c186dc826e
better handling for ipads. fixes #1949
2013-12-03 10:21:17 -08:00
Lito
abe7777b0a
Fixed string used as regular expression for ID attribute.
...
Signed-off-by: Igor Vaynberg <igor.vaynberg@gmail.com>
2013-12-03 08:32:27 -08:00
Igor Vaynberg
fc5ac5b137
Merge pull request #1728 from corinnaerin/master
...
Compatibility with jQuery 1.9 +
2013-11-29 22:49:06 -08:00
Igor Vaynberg
f8dda91171
Merge pull request #1014 from sjschukin/patch-1
...
.select2("data", null) causes an error
2013-11-29 22:40:52 -08:00
Igor Vaynberg
aa0fb730aa
Merge pull request #1938 from datapad/data-result-direct-children
...
Only pick up direct children when retrieving data in 'multiple' mode
2013-11-29 22:24:32 -08:00
Igor Vaynberg
816a46bf1a
Merge pull request #1940 from datapad/reset-filtered-dropdown
...
Fix dropdown items not being reset after filtering and selecting when `closeOnSelect` is `false`
2013-11-29 22:24:05 -08:00
Alek Storm
b5aa4688ea
Fix dropdown items not being reset after filtering and selecting when closeOnSelect is false
2013-11-27 17:24:11 -06:00
Alek Storm
e7bd3a3779
Only pick up direct children when retrieving data in 'multiple' mode:
...
Prevents accidentally returning the selected items of any select2's embedded in the HTML of
this selection's items.
2013-11-27 17:17:15 -06:00
riatiger
50f813c003
fix for Uncaught TypeError
...
Prevents "Uncaught TypeError: Object #<Object> has no method 'abort'"
error for case when non-jQuery promise is used as a handler (AngularJS
$promise for example).
2013-11-21 19:58:01 +02:00
Igor Vaynberg
0967c67776
Merge pull request #1865 from pborreli/typos
...
Fixed typos
2013-11-14 08:24:38 -08:00
Jake
ef9f1dea90
Fix for drop-auto-width collision detection and css border top
...
- collision detection was not moving the drop left based on the
difference between viewport and relative location of box (dropleft +
dropwidth)
- .select2-drop-active was overriding the .select2-drop-auto-width
making the shifted dropbox look a bit wierd
2013-11-07 16:21:52 -05:00
Igor Vaynberg
cb5b684ae5
Merge pull request #1887 from lukinpark/patch-1
...
Update select2.js
2013-11-07 10:09:07 -08:00
Igor Vaynberg
50698fd51c
Merge pull request #1685 from jdecuyper/feature-enable-formatResultCssClass
...
Enable function formatResultCssClass.
2013-11-07 09:51:38 -08:00
Igor Vaynberg
fc4bbbb5ef
Merge pull request #1846 from tpruvot/master
...
issue #1778 : prevent delayed focus when the list is hidden
2013-11-07 07:40:45 -08:00
lukinpark
85de8cc1d6
Update select2.js
...
above function doesn't work great
2013-11-07 11:45:05 +01:00
Jonathan Mahoney
78ccc05e04
Accessibility enhancements for single-value elements. Added correct ARIA attributes and associations. Much-improved screen-reader support (tested with NVDA on Firefox 25)
2013-11-06 12:55:12 +00:00
Pascal Borreli
9725363ada
Fixed typos
2013-10-31 23:20:45 +00:00
Max Bruchmann
2d13c0a00a
fixed invalid index in buildChangeDetails, fixes #1858
2013-10-31 17:55:19 +01:00
Tanguy Pruvot
b757fb987d
issue #1778 : prevent delayed focus when the list is hidden
...
This reset the focus color when the TAB key is pressed.
2013-10-28 11:37:45 +01:00
Igor Vaynberg
cb7aefaeda
fix keyboard removal of choices. fixes #1839
2013-10-26 07:57:53 -07:00
Riley Lynch
53d1fea248
Modified syncCssClasses to use output of adapter when applying a class rather than applying the original class
2013-10-20 13:14:31 -07:00
cmcnulty
d5297ccd6d
#1807 add support for MutationObserver
...
Better support mutation events in Firefox
2013-10-17 15:09:02 -05:00
Bob Renwick
8e46faa1d9
Fixing reference to undefined this triggering change on multiselect
2013-10-16 18:30:58 +01:00
Arend van Beelen
fc44b96e84
Don't rely on :selected, makes Select2 compatible with jQuery builds without Sizzle.
2013-10-14 14:37:41 +02:00
stan
2a9154e0c7
Remove unused var declarations
2013-10-10 20:15:26 +02:00
Igor Vaynberg
d1f51910ee
small cleanup in width regex matching. #1557
2013-10-09 08:30:26 -07:00
Igor Vaynberg
58f939ef3b
Merge pull request #1774 from avelis/master
...
Fix for #1518 . Update to select2.js to trigger properly named event.
2013-10-08 20:35:55 -07:00
Igor Vaynberg
2982be4ec9
fixes #1557 ...again...
2013-10-08 20:33:14 -07:00
Igor Vaynberg
0d0882942f
Merge pull request #1639 from francoispluchino/fix-close-focus
...
Fix the focus when list is closed on the mouse click event
2013-10-08 20:25:21 -07:00
Igor Vaynberg
a3e188afe1
Merge pull request #1772 from KyKyPy3/master
...
Fix selection first element from "postprocessResults"
2013-10-08 20:21:47 -07:00
Yoni Jah
a65a3ce038
#1776 and #1722 dropdown position issue
2013-10-08 12:37:37 +03:00
Andrew Velis
204d4a276e
Update to unselect method to support "select2-removing" triggers.
...
The goal here is send off a triggered event to a subscriber that an
element is going to be removed. It hasn't removed yet but would be
after the event fires. I have also added logic to determine if a
subscriber has prevented default. This will prove useful in the future
if a subscriber needs to extend the functionality for other usages.
2013-10-07 20:47:12 -07:00
Andrew Velis
f39ab3080e
Fix for #1518 . Update to select2.js to trigger properly named event.
...
By the documentation the event that should be fired is "select2-removed" however the event that actually gets fired is called "removed"
2013-10-06 21:27:40 -07:00
Efremenko Roman
9266d7cf55
Fix selection first element from "postprocessResults" - exclude selected elements from highlightable elements
2013-10-06 17:02:03 +04:00
Richard Huang
701e84ea21
append label only when formatted is not undefined
2013-09-19 11:19:10 +08:00
Corinna Schmidt
5bd41fc00c
Compatibility with jQuery 1.10
...
removeAttr("disabled') is no longer correct with the most recent version
of jQuery. Should use prop("disabled", false) instead.
2013-09-17 16:01:45 -04:00
Igor Vaynberg
9e7dde66b7
Merge pull request #1722 from yonjah/master
...
dropdown repostion fix when previous postion changes container position
2013-09-17 07:22:48 -07:00
Alexander Zaytsev
67699746b4
Use more specific selector for finding options of a select
2013-09-16 21:54:29 +02:00
Yoni Jah
e6840fdc37
dropdown repostion fix when previous postion changes container position
2013-09-15 10:25:35 +03:00
Edwin Vlieg
ca9b55fadb
Remove negative selector for .select2-selected
...
This broke scroll behaviour when displaying the selected items in the
dropdown.
2013-09-11 12:58:05 +02:00
cnanney
3b54482522
Fix focus on select
...
Focus should go back to select2-focusser, not select2-choice.
2013-09-06 18:57:41 -05:00
evangun
cfec9c6434
Edit the default initSelection function to pass all tag properties
...
The function will now pass all properties of the objects passed as tags to the constructor, not just the "id" and "text" properties. Because a tag is not always just an id and a text, just like when you provide the items with the "data" object instead.
This makes sure these properties are always available at the runtime of formatSelection() or formatResult(), which is not currently the case when the field is repopulated on a triggered "change" event.
My code looks like this :
$el.select2({
...,
tags: [{
//id
id: 1,
//the string that will matched against the user's query
text: 'martin smith greatmartin@provider.com'
//the label of the item that will be shown if this tag is selected
label: 'M. Smith',
}],
formatSelection: function(object, container){
return object.label || object.text;
},
//right now I have to override the default function:
initSelection: function(){...}
});
2013-09-05 18:18:50 +02:00
jdecuyper
fa4ce8e382
Enable function formatResultCssClass.
2013-09-03 23:29:42 -05:00
Igor Vaynberg
fb8bf6d51d
do not leak click events. fixes #1622
2013-09-03 21:16:16 -07:00
Igor Vaynberg
7d60f619ce
Merge pull request #1211 from jhinch/pixel-rounding-problems
...
Search width inconsistencies in different browsers due to fractional pixels
2013-09-03 20:48:35 -07:00
jdecuyper
02dea18dc9
Avoid locked options to be selected and deleted.
2013-09-03 17:20:35 -05:00
jdecuyper
a380ebabd5
Remove duplicated options from multi-valued select boxes.
2013-08-30 18:16:41 -05:00
Duncan Smart
edc0d86fd2
Added select2-clearing
event
...
that allows clearing selection to be canceled.
2013-08-30 21:35:01 +01:00
Igor Vaynberg
ca7550bf4d
Revert "Fixed Tab key not respecting opts.selectOnBlur" breaks tab key. fixes #1646 .
...
This reverts commit 6eb74930d5
.
2013-08-30 08:55:16 -07:00
markwellna
3c2d7f7310
Clicking outside of dropdown removes select2-container-active class.
...
Closes #1661 .
2013-08-28 13:05:41 -04:00
François Pluchino
9bc68f089e
Fix the focus when list is closed on the mouse click event
2013-08-21 12:16:50 +02:00