Cameron Spear
0675805621
Fix error: Cannot read property 'top' of undefined
...
Lines [1499](d487fc58a8/select2.js (L1499)
) and [1509](d487fc58a8/select2.js (L1509)
) make a call to `child.offset().top`. I don't know what's causing `child.offset()` to return undefined, but it is and it's breaking Select2 so that I can't select the last item in the list (this error occurs when I try hovering over or clicking on the last item in a list).
I can try and create a reduced case, but this fix is 100% backward compatibe, passes all the tests you have for the project and has a 0% chance of breaking anyone's working code. With this patch, my dropdown works just fine. At worst, this does *nothing* for people, at best, it fixes a rare edge case. Like my edge case. And I'm a pretty important person to me.
2014-06-06 19:04:14 -07:00
Kevin Brown
172f973d7b
Merge pull request #2436 from asapach/patch-2
...
updated russian translation to match template
2014-06-05 12:00:03 -04:00
Kevin Brown
108849038a
Merge pull request #2435 from asapach/patch-1
...
updated translation template to match master
2014-06-05 11:27:01 -04:00
Aliaksei Sapach
4871aa5469
updated russian translation
...
now matches the latest template, see #2435
2014-06-05 17:41:23 +03:00
Aliaksei Sapach
f6597ad1c5
updated translation template to match master
2014-06-05 17:05:44 +03:00
Kevin Brown
c23f978262
Merge pull request #2361 from rjbijl/rtl
...
Better support for RTL languages
2014-06-03 21:26:52 -04:00
Santi Albo
db86f19552
Remove added line
2014-05-28 18:17:31 +01:00
Santi Albo
b8ce36a65e
Add text function for formatResult and formatSelection
2014-05-28 18:13:26 +01:00
Kevin Brown
d487fc58a8
Merge pull request #2360 from ycdtosa/master
...
changes on updateResults, populate by @cervengoc on #781
2014-05-27 19:09:38 -04:00
Kevin Brown
f544f9d9ab
Merge pull request #2367 from gschizas/master
...
Added Greek accented characters to ignorable diacritics
2014-05-27 18:56:07 -04:00
Kevin Brown
fba74e3ccd
Merge pull request #2363 from thereloaded/master
...
query as third parameter to ajax results callback
2014-05-27 16:50:52 -04:00
Kevin Brown
a29dfc2e2a
Merge pull request #2410 from redbmk/master
...
IE8 does not support Array.prototype.forEach #2339
2014-05-27 16:46:07 -04:00
Kevin Brown
5a8394ba09
Merge pull request #2401 from Holek/patch-1
...
Reword Polish string for formatInputTooShort
2014-05-23 20:43:31 -04:00
Michał Połtyn
9d44e06dc1
Reword Polish string for formatInputTooShort
2014-05-23 22:36:51 +01:00
Braden M. Kelley
88c6a63937
IE8 does not support Array.prototype.forEach #2339
2014-05-23 10:29:25 -07:00
Kevin Brown
25f89bf49b
Merge pull request #2388 from cnicodeme/patch-1
...
Update select2.js
2014-05-20 09:03:36 -04:00
Cyril Nicodème
02d6e88747
Update select2.js
...
Fix an exception when called "destroy" on a still opened dropdown.
2014-05-20 09:30:35 +02:00
Kevin Brown
2a0c8444fb
Merge pull request #2377 from TheSisb/master
...
Handling mousemove more delicately
2014-05-19 19:41:18 -04:00
Kevin Brown
2a9407434d
Merge pull request #2385 from johngallagher/patch-1
...
Merge examples from wiki
2014-05-19 09:32:38 -04:00
John Gallagher
a5b6ee431b
Merge examples from wiki
2014-05-18 05:31:42 +01:00
TheSisb
e2cd841fe8
Handling mousemove more delicately
...
Mousemove fires very frequently and is a sure way of killing any app's FPS. This tweak makes sure it is only bound when it is in fact needed.
2014-05-14 15:25:05 -07:00
George Schizas
827a549ba8
Reverted formatting of diacritics variable, now is again in one line
2014-05-13 17:11:14 +03:00
George Schizas
68c64a1129
Enabled Greek for diacritics ignoring
2014-05-13 17:05:46 +03:00
George Schizas
df43e1a1ec
fixed word wrapping for DIACRITICS variable
2014-05-13 16:59:41 +03:00
ycdtosa
0f8a85b994
update populate at formatResults to use bulk append of nodes
...
this will make a small (25%) improvement on speed.
2014-05-13 12:27:52 +02:00
ycdtosa
c14f45cb6c
Revert "changes on updateResults, populate by @cervengoc on #781 "
...
This reverts commit 12e0de21ae
.
2014-05-13 09:54:00 +02:00
thereloaded
49a86e21ed
added query to function head jsdoc block
2014-05-13 09:34:16 +02:00
Robert-Jan Bijl
5470a453f9
Getting a few more pixels perfect in the RTL mode for multiple selects
2014-05-13 09:05:37 +02:00
Robert-Jan Bijl
fb91adaa57
More RTL style fixes, now for the multiple select
2014-05-13 08:44:20 +02:00
Joshua Jonah
64256f27f2
Stopped refresh to top when closeOnSelect: false
...
Not really sure how the noHighlightUpdate variable is supposed to work, it is undefined all the time so it appears to be broken. I just referred to `this.opts.closeOnSelect` to get the status directly.
2014-05-12 21:44:27 -04:00
thereloaded
f07bab5a6b
query as third parameter to ajax results callback
...
for e.g. proper cache implementation it is necessary to have the complete query in the results callback of the ajax function. to not break backwards compatibility i added it as third parameter and did not replace query.page parameter
2014-05-12 19:35:59 +02:00
Robert-Jan Bijl
06b93b2703
Better support for RTL languages
...
CSS changes to better support RTL languages. Most notable is the positioning of the arrow on the left side of the select2 for RTL
2014-05-12 15:34:40 +02:00
ycdtosa
12e0de21ae
changes on updateResults, populate by @cervengoc on #781
...
use string concatenation instead of DOM manipulation at populate. This
does gives about a 45% speed boost as measured with chrome v35. Code by
@cervengoc on #781
2014-05-12 11:39:54 +02:00
Kevin Brown
52425f93c8
Merge pull request #2355 from stephane/i18n
...
I18n
2014-05-09 15:52:31 -04:00
Stéphane Raimbault
00bad439bc
Add note about position of locale file
2014-05-09 21:09:07 +02:00
Stéphane Raimbault
1d26b2bc17
Remove execution flags on select2_locale_zh-TW.js
2014-05-09 21:09:07 +02:00
Stéphane Raimbault
c37640720e
Improve French translation
2014-05-09 21:09:07 +02:00
Kevin Brown
8fb7c15b4e
Merge pull request #2350 from soichih/master
...
Fixed the issue where multi-line item inside multi list will touch the ..
2014-05-07 22:02:55 -04:00
Kevin Brown
765cdbfdad
Merge pull request #2346 from sroe/patch-1
...
formatMatches translation added
2014-05-07 22:01:56 -04:00
Soichi Hayashi
09003853e4
Fixed the issue where multi-line item inside multi list will touch the right end of the container
2014-05-07 17:24:07 +00:00
sroe
7bf2f2eb75
formatMatches translation added
...
formatMatches translation added.
2014-05-06 10:41:08 +02:00
Kevin Brown
c864392ffb
Merge pull request #2326 from dawnhammond/feature/2084
...
Fix issue with dropdown menu getting stuck in IE when using multiselect
2014-05-05 19:23:36 -04:00
Kevin Brown
85a194dd0f
Merge pull request #2341 from seferov/locale_az
...
Azerbaijani translation added
2014-05-05 10:44:48 -04:00
seferov
d4fb3a3b00
typo fixed
2014-05-03 10:24:13 +03:00
seferov
344a4b19e2
Azerbaijani translation added.
2014-05-03 10:22:54 +03:00
Kevin Brown
ab6d38f9b4
Merge pull request #2338 from redbmk/master
...
keyword `this` inside closures referring to wrong object
2014-05-01 12:00:50 -04:00
Braden M. Kelley
2133129a74
keyword this
inside closures referring to wrong object
2014-05-01 08:54:32 -07:00
Kevin Brown
ea3c6766a2
Merge pull request #2164 from colemanw/evaluateFix
...
Provide context for evaluated functions
2014-05-01 10:08:42 -04:00
Kevin Brown
988eccb557
Merge pull request #2332 from FallSe7en/master
...
Unbind onpropertychange event handler on destroy for IE8-10
2014-05-01 10:05:20 -04:00
Kevin Brown
0db21bb26d
modified version identifiers in descriptors for release 3.4.8
2014-05-01 09:50:32 -04:00