1
0
mirror of synced 2024-11-28 15:46:03 +03:00
Commit Graph

2545 Commits

Author SHA1 Message Date
Kevin Brown
31931a4212 Add tests for when dropdownParent isn't in the document 2019-09-18 21:44:25 -04:00
Kevin Brown
2c5467b38c Fixes error when getting offset of element not in document
This fixes an error which is called out in jQuery Migrate but
probably never happens in real life. This is because we call
`jQuery.fn.offset` without checking if the element is in the
document. Based on testing done here and within the MediaWiki
team, I'm pretty sure jQuery never actually implemented explicit
checks and this jQuery Migrate warning is just to cover the case
where a browser might start returning inconsistnet results. And
we could at least reproduce the inconsistency, so that's something.

We now default the offset to 0/0 if the parent element happens to
not be in the document. This appears to be what jQuery used to do
in the past, and generally appears to be what people expect in
these cases.

This fixes #5584.
2019-09-18 21:33:13 -04:00
Kevin Brown
233424da2b
Merge pull request #5639 from select2/github-actions-updates
GitHub Actions updates
2019-09-11 23:53:51 -04:00
Kevin Brown
2e4c11339c Disable deploying to GPM
We have to wait to be cleared for the private beta access first before we can actually deploy to this.
2019-09-11 23:49:02 -04:00
Kevin Brown
3bc5e4ee40 Update README with new docs location 2019-09-11 23:48:01 -04:00
Kevin Brown
5f78d824ac Swap Travis CI badge with GitHub Actions badge
Since it's still in a private beta, we can't link to anything useful so the link has been dropped
2019-09-11 23:44:21 -04:00
Kevin Brown
581308337a
Merge pull request #5638 from select2/github-actions
Enable GitHub Actions to replace Travis CI
2019-09-11 23:34:01 -04:00
Kevin Brown
7688be5db5 Only deploy docs on releases 2019-09-11 23:27:04 -04:00
Kevin Brown
e1d64e92c4 HOST_FINGERPRINT is also required but unused 2019-09-11 23:15:02 -04:00
Kevin Brown
a31d56d47b HOST_IP is also required but unused 2019-09-11 23:12:52 -04:00
Kevin Brown
120065ed46 SSH_PUBLIC_KEY is required but unused 2019-09-11 23:10:22 -04:00
Kevin Brown
c95ed1796a Switch to using rsync 2019-09-11 23:07:31 -04:00
Kevin Brown
dea726d065 Use new syntax for args 2019-09-11 22:59:11 -04:00
Kevin Brown
bff3a777ae Try using strip.components with drone-scp
This should, in theory, strip out the leading docs directory when doing the copy.
2019-09-11 22:57:24 -04:00
Kevin Brown
29d01a00c5 Move docs into root directory before copying
Hopefully this fixes the issue where it was unpacking the enitre directory into the destination instead of the individually specified files.
2019-09-11 22:51:44 -04:00
Kevin Brown
b3c6d3ebfe Remove trailing slash on destination directory 2019-09-11 22:35:52 -04:00
Kevin Brown
5e32678e49 Proper syntax for copying dir contents 2019-09-11 22:29:43 -04:00
Kevin Brown
c891d2ec72 Deploy docs to the production location 2019-09-11 22:20:38 -04:00
Kevin Brown
8cb7e33766 Fix copying directory during deployment 2019-09-11 22:14:18 -04:00
Kevin Brown
b4c3eccd7b Merge branch 'docs-master' into merge-docs 2019-09-11 04:03:38 -04:00
Kevin Brown
3606801728 Remove old documentation
This is no longer used for deploying the old GitHub pages doucmentation.
2019-09-11 21:56:24 -04:00
Kevin Brown
fe208f1f86 Added workflow for deploying documentation
This does not yet deploy the actual documentation, but it instead deploys the old docs (which are now redirects) to a temporary folder for testing.
2019-09-11 21:49:00 -04:00
Kevin Brown
891993e39b Renamed deploy.yml to package-deploy.yml
Eventually we are going to want to do documentation deployments so it makes sense to split them up.
2019-09-11 21:22:02 -04:00
Kevin Brown
dafddb73c8 Made NPM deployment step consistent with GPM 2019-09-11 21:15:02 -04:00
Kevin Brown
7b1367c6a0 Switch to only deploying when pushing to develop/master
Hopefully this still allows the release trigger to work, but this is relying on undocumented behaviour that nobody else appears to have tried.
2019-09-11 21:13:28 -04:00
Kevin Brown
e0560c74f7 Move documentation to the docs folder 2019-09-11 04:02:16 -04:00
Kevin Brown
748d279107 Extract NPM deployment out to different workflow
This will allow us to limit what branches it runs on.
2019-09-11 03:08:03 -04:00
Kevin Brown
82c51a319c Remove dry run from publish 2019-09-11 20:57:40 -04:00
Kevin Brown
8b9a99d286 Enable dry runs for publishing 2019-09-10 20:56:45 -04:00
Kevin Brown
91838fe0a6 Add deploying to GPM and NPM
This also adds a handler for the release event, which is what we want to be using for pushing NPM builds out.
2019-09-10 20:07:35 -04:00
Kevin Brown
ffd98a493b Add steps for linting, minification, start deployments
The deployment step is not yet finished and this required splitting linting from running tests.
2019-09-10 19:44:27 -04:00
Kevin Brown
6758bb50b9 Fixed GitHub Actions syntax 2019-09-10 19:28:41 -04:00
Kevin Brown
f025d675a9 Added basic GitHub Actions workflow to build the project 2019-09-10 19:21:22 -04:00
Kevin Brown
d6acc57a7c
Merge pull request #42 from select2/develop
Release Select2 4.0.10
2019-08-28 21:27:53 -04:00
Kevin Brown
7f0800ceba Bump versions for 4.0.10 release 2019-08-28 21:26:12 -04:00
Kevin Brown
2a80567151
Merge pull request #5623 from select2/release/4.0.10
[Release] 4.0.10
2019-08-27 23:05:53 -04:00
Kevin Brown
3d52d08063 Updated changelog for 4.0.10 2019-08-27 23:03:06 -04:00
Kevin Brown
5f1a91c447 Recompiled dist for 4.0.10 2019-08-27 23:02:40 -04:00
Kevin Brown
919373e481 Bump versions for 4.0.10 release 2019-08-27 22:58:25 -04:00
Kevin Brown
64e829e447 Converting tests to unix newlines 2019-08-27 22:56:27 -04:00
Kevin Brown
d0c5aca962
Merge pull request #5622 from select2/GH-5373
Support passing in a selector for `dropdownParent` option
2019-08-27 22:54:06 -04:00
Mikhail Titov
01e68f4dd7 Test for dropdownParent option 2019-08-27 22:48:18 -04:00
Mikhail Titov
357c2a11c2 Allow passing non-jQuery objects as dropdownParent 2019-08-27 22:31:24 -04:00
Kevin Brown
9e4f842fb1
Merge pull request #5621 from select2/GH-5619
Fix bug where dropdowns pointing upwards were incorrectly positioned
2019-08-27 22:27:14 -04:00
Kevin Brown
d8d2aa5b03 Switch back to late binding the positioning handlers
This is how it used to work pre-4.0.9, where the bound handlers for
resizing and positioning the dropdown were bound at the first time
that the dropdown was opened. This was changed for the 4.0.9 release
as a part of 3f75227a693 where it was not clear why this late binding
was happening, so it was removed to simplify the code.

The late binding is necessary because the handlers within results for
generating the results, and thus the content within the dropdown,
are bound after the handlers for the dropdown are bound. This results
in situations where the handlers for positioning the dropdown are
bound before the dropdown is updated with content, resulting in the
positioning being calculated for the old content and thus being
incorrectly placed. By binding the positioning handlers after the
dropdow is opened for the first time, we can ensure that the
positioning handlers are bound after the result handlers, so we
won't have to worry about this issue.

The handlers are only bound once because they only need to perform
all the calculations a single time. There is no need to keep checking
all of the calculated styles more than we need to, so this is guarded
by a flag which ensures it is only bound a single time per dropdown.

Fixes #5619
Fixes #5620
2019-08-27 22:20:39 -04:00
Kevin Brown
bdeb9075f5
Merge pull request #40 from select2/develop
Release Select2 4.0.9
2019-08-21 21:25:07 -04:00
Kevin Brown
3f8c3c54a3 Bump versions for Select2 4.0.9 release 2019-08-21 21:22:19 -04:00
Kevin Brown
f8ded17ae7
Merge pull request #39 from MediaIQ/fix_data_properties_doc
Fix the doc for data-disabled property as not available
2019-08-21 21:18:26 -04:00
Kevin Brown
d54560f21e
Merge pull request #5613 from select2/release/4.0.9
[Release] 4.0.9
2019-08-21 20:59:42 -04:00
diesl
1a6d4a1ad8 Update de.js (#5604)
Improve German translation
2019-08-21 20:26:55 -04:00